Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t v2 1/1] tests/intel/xe_exec_sip_eudebug: skip eudebug tests on VF
@ 2025-04-03 11:53 Jan Sokolowski
  2025-04-03 18:59 ` ✓ i915.CI.BAT: success for series starting with [i-g-t,v2,1/1] " Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Jan Sokolowski @ 2025-04-03 11:53 UTC (permalink / raw)
  To: igt-dev
  Cc: Jan Sokolowski, Katarzyna Piecielska, Lukasz Laguna,
	Christoph Manszewski

Tests using eudebug are not compatible with VF functionality.
A way to check for that scenario is to check eudebug toggle
capability.

Skip a test that tries to use eudebug toggle if it doesn't
exist.

v2: Changed the idea from disabling a single test to disabling
all possible tests.

Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com>
Cc: Katarzyna Piecielska <katarzyna.piecielska@intel.com>
Reviewed-by: Lukasz Laguna <lukasz.laguna@intel.com>
Cc: Lukasz Laguna <lukasz.laguna@intel.com>
Reviewed-by: Christoph Manszewski <christoph.manszewski@intel.com>
Cc: Christoph Manszewski <christoph.manszewski@intel.com>
---
 lib/xe/xe_eudebug.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lib/xe/xe_eudebug.c b/lib/xe/xe_eudebug.c
index ec946058b..667c31c6e 100644
--- a/lib/xe/xe_eudebug.c
+++ b/lib/xe/xe_eudebug.c
@@ -1794,10 +1794,7 @@ bool xe_eudebug_enable(int fd, bool enable)
 	bool old = false;
 	int ret = __xe_eudebug_enable_getset(fd, &old, &enable);
 
-	if (ret) {
-		igt_skip_on(enable);
-		old = false;
-	}
+	igt_skip_on(ret);
 
 	return old;
 }
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-04-09 10:41 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-03 11:53 [PATCH i-g-t v2 1/1] tests/intel/xe_exec_sip_eudebug: skip eudebug tests on VF Jan Sokolowski
2025-04-03 18:59 ` ✓ i915.CI.BAT: success for series starting with [i-g-t,v2,1/1] " Patchwork
2025-04-03 20:30 ` ✓ Xe.CI.BAT: " Patchwork
2025-04-03 22:47 ` ✗ i915.CI.Full: failure " Patchwork
2025-04-04  1:56 ` ✗ Xe.CI.Full: " Patchwork
2025-04-09  9:08 ` [PATCH i-g-t v2 1/1] " Manszewski, Christoph
2025-04-09 10:41   ` Kamil Konieczny

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox