From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com, juhapekka.heikkila@gmail.com,
uma.shankar@intel.com, chaitanya.kumar.borah@intel.com,
Swati Sharma <swati2.sharma@intel.com>
Subject: [PATCH i-g-t, v2 1/3] lib/igt_chamelium: Add chamelium_frame_match_or_dump_frame_pair()
Date: Fri, 4 Apr 2025 12:59:28 +0530 [thread overview]
Message-ID: <20250404072930.695363-2-swati2.sharma@intel.com> (raw)
In-Reply-To: <20250404072930.695363-1-swati2.sharma@intel.com>
Add chamelium_frame_match_or_dump_frame_pair() to compare frame
dumps captured from chamelium. If they do not, this saves the
reference and captured frames to a png file.
v2: -let crc be computed from compared_frames_dump() (Chaitanya)
-remove passing of reference_crc (Chaitanya)
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
lib/igt_chamelium.c | 46 +++++++++++++++++++++++++++++++++++++++++++++
lib/igt_chamelium.h | 5 +++++
2 files changed, 51 insertions(+)
diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
index 620fbbf7d..c86773898 100644
--- a/lib/igt_chamelium.c
+++ b/lib/igt_chamelium.c
@@ -2070,6 +2070,52 @@ bool chamelium_frame_match_or_dump(struct chamelium *chamelium,
return match;
}
+/**
+ * chamelium_frame_match_or_dump_frame_pair:
+ * @chamelium: The chamelium instance the frame dump belongs to
+ * @frame0: The chamelium reference frame dump to match
+ * @frame1: The chamelium capture frame dump to match
+ * @check: the type of frame matching check to use
+ *
+ * Returns bool that the provided captured frames matches.
+ * If they do not, this saves the frames to a png file.
+ */
+bool chamelium_frame_match_or_dump_frame_pair(struct chamelium *chamelium,
+ struct chamelium_port *port,
+ const struct chamelium_frame_dump *frame0,
+ const struct chamelium_frame_dump *frame1,
+ enum chamelium_check check)
+{
+ cairo_surface_t *reference;
+ cairo_surface_t *capture;
+ bool match;
+
+ /* Grab the captured reference frame from chamelium */
+ reference = convert_frame_dump_argb32(frame0);
+
+ /* Grab the captured frame from chamelium */
+ capture = convert_frame_dump_argb32(frame1);
+
+ switch (check) {
+ case CHAMELIUM_CHECK_ANALOG:
+ match = igt_check_analog_frame_match(reference, capture);
+ break;
+ case CHAMELIUM_CHECK_CHECKERBOARD:
+ match = igt_check_checkerboard_frame_match(reference, capture);
+ break;
+ default:
+ igt_assert(false);
+ }
+
+ if (!match && igt_frame_dump_is_enabled())
+ compared_frames_dump(reference, capture, 0, 0);
+
+ cairo_surface_destroy(reference);
+ cairo_surface_destroy(capture);
+
+ return match;
+}
+
/**
* chamelium_analog_frame_crop:
* @chamelium: The Chamelium instance to use
diff --git a/lib/igt_chamelium.h b/lib/igt_chamelium.h
index d979de4a2..8882e13fb 100644
--- a/lib/igt_chamelium.h
+++ b/lib/igt_chamelium.h
@@ -257,6 +257,11 @@ bool chamelium_frame_match_or_dump(struct chamelium *chamelium,
const struct chamelium_frame_dump *frame,
struct igt_fb *fb,
enum chamelium_check check);
+bool chamelium_frame_match_or_dump_frame_pair(struct chamelium *chamelium,
+ struct chamelium_port *port,
+ const struct chamelium_frame_dump *frame0,
+ const struct chamelium_frame_dump *frame1,
+ enum chamelium_check check);
void chamelium_crop_analog_frame(struct chamelium_frame_dump *dump, int width,
int height);
void chamelium_destroy_frame_dump(struct chamelium_frame_dump *dump);
--
2.25.1
next prev parent reply other threads:[~2025-04-04 7:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 7:29 [PATCH i-g-t 0/3] Fix ctm-limited subtest Swati Sharma
2025-04-04 7:29 ` Swati Sharma [this message]
2025-04-06 9:31 ` [PATCH i-g-t,v2 1/3] lib/igt_chamelium: Add chamelium_frame_match_or_dump_frame_pair() Borah, Chaitanya Kumar
2025-04-04 7:29 ` [PATCH i-g-t 2/3] lib/igt_chamelium: Fix CRC calculation in compared_frames_dump() Swati Sharma
2025-04-06 9:33 ` Borah, Chaitanya Kumar
2025-04-04 7:29 ` [PATCH i-g-t, v3 3/3] tests/chamelium/kms_chamelium_color: Fix ctm-limited-range subtest Swati Sharma
2025-04-06 9:39 ` [PATCH i-g-t,v3 " Borah, Chaitanya Kumar
2025-04-04 9:17 ` ✓ i915.CI.BAT: success for Fix ctm-limited subtest (rev3) Patchwork
2025-04-04 9:49 ` ✓ Xe.CI.BAT: " Patchwork
2025-04-04 11:11 ` ✗ i915.CI.Full: failure " Patchwork
2025-04-04 20:54 ` ✗ Xe.CI.Full: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2025-03-28 18:10 [PATCH i-g-t 0/3] Fix ctm-limited subtest Swati Sharma
2025-03-28 18:10 ` [PATCH i-g-t, v2 1/3] lib/igt_chamelium: Add chamelium_frame_match_or_dump_frame_pair() Swati Sharma
2025-04-01 10:04 ` [PATCH i-g-t,v2 " Borah, Chaitanya Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250404072930.695363-2-swati2.sharma@intel.com \
--to=swati2.sharma@intel.com \
--cc=chaitanya.kumar.borah@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
--cc=uma.shankar@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox