Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com, juhapekka.heikkila@gmail.com,
	uma.shankar@intel.com, chaitanya.kumar.borah@intel.com,
	Swati Sharma <swati2.sharma@intel.com>
Subject: [PATCH i-g-t 2/3] lib/igt_chamelium: Fix CRC calculation in compared_frames_dump()
Date: Fri,  4 Apr 2025 12:59:29 +0530	[thread overview]
Message-ID: <20250404072930.695363-3-swati2.sharma@intel.com> (raw)
In-Reply-To: <20250404072930.695363-1-swati2.sharma@intel.com>

The CRC calculation in compared_frames_dump is incorrectly
using the reference frame instead of the captured frame when
capture_crc is NULL.
Fix this by correctly passing the captured frame to
chamelium_do_calculate_fb_crc().

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 lib/igt_chamelium.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
index c86773898..a96e36b5b 100644
--- a/lib/igt_chamelium.c
+++ b/lib/igt_chamelium.c
@@ -1878,7 +1878,7 @@ static void compared_frames_dump(cairo_surface_t *reference,
 	}
 
 	if (!capture_crc) {
-		chamelium_do_calculate_fb_crc(reference, &local_capture_crc);
+		chamelium_do_calculate_fb_crc(capture, &local_capture_crc);
 		capture_crc = &local_capture_crc;
 	}
 
-- 
2.25.1


  parent reply	other threads:[~2025-04-04  7:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04  7:29 [PATCH i-g-t 0/3] Fix ctm-limited subtest Swati Sharma
2025-04-04  7:29 ` [PATCH i-g-t, v2 1/3] lib/igt_chamelium: Add chamelium_frame_match_or_dump_frame_pair() Swati Sharma
2025-04-06  9:31   ` [PATCH i-g-t,v2 " Borah, Chaitanya Kumar
2025-04-04  7:29 ` Swati Sharma [this message]
2025-04-06  9:33   ` [PATCH i-g-t 2/3] lib/igt_chamelium: Fix CRC calculation in compared_frames_dump() Borah, Chaitanya Kumar
2025-04-04  7:29 ` [PATCH i-g-t, v3 3/3] tests/chamelium/kms_chamelium_color: Fix ctm-limited-range subtest Swati Sharma
2025-04-06  9:39   ` [PATCH i-g-t,v3 " Borah, Chaitanya Kumar
2025-04-04  9:17 ` ✓ i915.CI.BAT: success for Fix ctm-limited subtest (rev3) Patchwork
2025-04-04  9:49 ` ✓ Xe.CI.BAT: " Patchwork
2025-04-04 11:11 ` ✗ i915.CI.Full: failure " Patchwork
2025-04-04 20:54 ` ✗ Xe.CI.Full: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2025-03-28 18:10 [PATCH i-g-t 0/3] Fix ctm-limited subtest Swati Sharma
2025-03-28 18:10 ` [PATCH i-g-t 2/3] lib/igt_chamelium: Fix CRC calculation in compared_frames_dump() Swati Sharma
2025-04-01 10:02   ` Borah, Chaitanya Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250404072930.695363-3-swati2.sharma@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=juhapekka.heikkila@gmail.com \
    --cc=uma.shankar@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox