From: Ashutosh Dixit <ashutosh.dixit@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Subject: [PATCH i-g-t 4/6] tests/intel/xe_oa: Only sanity check timer PEC reports
Date: Tue, 8 Apr 2025 11:12:08 -0700 [thread overview]
Message-ID: <20250408181210.1052760-5-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20250408181210.1052760-1-ashutosh.dixit@intel.com>
Empirical testing revealed that when reports of different types/reasons are
intermixed, this throws off gpu_ticks and test_event1_cycles_xecore* in PEC
data, causing test failures. To avoid this, restrict testing to only
timer/periodic reports.
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
tests/intel/xe_oa.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
index eaf97ae0df..cc9702322d 100644
--- a/tests/intel/xe_oa.c
+++ b/tests/intel/xe_oa.c
@@ -1031,6 +1031,19 @@ static void pec_sanity_check_two(const u32 *report0, const u32 *report1,
u64 *pec0 = (u64 *)(report0 + 8);
u64 *pec1 = (u64 *)(report1 + 8);
+ /*
+ * Empirical testing revealed that when reports of different types/reasons are
+ * intermixed, this throws off gpu_ticks and test_event1_cycles_xecore* in PEC
+ * data, causing test failures. To avoid this, restrict testing to only
+ * timer/periodic reports.
+ */
+ if (strcmp(read_report_reason(report0), "timer") ||
+ strcmp(read_report_reason(report1), "timer")) {
+ igt_debug("Only checking timer reports: %s->%s\n",
+ read_report_reason(report0), read_report_reason(report1));
+ return;
+ }
+
igt_debug("tick delta = %#lx\n", tick_delta);
/* Difference in test_event1_cycles_xecore* values should be close to tick_delta */
--
2.48.1
next prev parent reply other threads:[~2025-04-08 18:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 18:12 [PATCH i-g-t 0/6] Sanity check Xe2 PEC OA reports Ashutosh Dixit
2025-04-08 18:12 ` [PATCH i-g-t 1/6] tests/intel/xe_oa: Rename check_reports to mmap_check_reports Ashutosh Dixit
2025-04-14 22:20 ` Umesh Nerlige Ramappa
2025-04-08 18:12 ` [PATCH i-g-t 2/6] tests/intel/xe_oa: Fix oa_tick_delta Ashutosh Dixit
2025-04-14 22:21 ` Umesh Nerlige Ramappa
2025-04-08 18:12 ` [PATCH i-g-t 3/6] tests/intel/xe_oa: Sanity check PEC report data for TestOa metric set Ashutosh Dixit
2025-04-14 23:16 ` Umesh Nerlige Ramappa
2025-04-15 16:57 ` Dixit, Ashutosh
2025-04-16 16:20 ` Umesh Nerlige Ramappa
2025-04-22 19:42 ` Dixit, Ashutosh
2025-04-08 18:12 ` Ashutosh Dixit [this message]
2025-04-14 22:36 ` [PATCH i-g-t 4/6] tests/intel/xe_oa: Only sanity check timer PEC reports Umesh Nerlige Ramappa
2025-04-08 18:12 ` [PATCH i-g-t 5/6] tests/intel/xe_oa: Reduce test_non_zero_reason execution time Ashutosh Dixit
2025-04-14 22:40 ` Umesh Nerlige Ramappa
2025-04-15 16:49 ` Dixit, Ashutosh
2025-04-08 18:12 ` [PATCH i-g-t 6/6] tests/intel/xe_oa: Use TestOa metric set also for OAM Ashutosh Dixit
2025-04-14 22:41 ` Umesh Nerlige Ramappa
2025-04-14 23:22 ` Dixit, Ashutosh
2025-04-08 19:58 ` ✓ i915.CI.BAT: success for Sanity check Xe2 PEC OA reports Patchwork
2025-04-08 20:04 ` ✓ Xe.CI.BAT: " Patchwork
2025-04-08 21:04 ` ✗ Xe.CI.Full: failure " Patchwork
2025-04-08 21:42 ` ✗ i915.CI.Full: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2025-04-22 19:34 [PATCH i-g-t 0/6] " Ashutosh Dixit
2025-04-22 19:34 ` [PATCH i-g-t 4/6] tests/intel/xe_oa: Only sanity check timer PEC reports Ashutosh Dixit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250408181210.1052760-5-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox