Re: [PATCH i-g-t 6/6] tests/intel/xe_oa: Use TestOa metric set also for OAM

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Mon, 14 Apr 2025 15:41:22 -0700, Umesh Nerlige Ramappa wrote:
>
> On Tue, Apr 08, 2025 at 11:12:10AM -0700, Ashutosh Dixit wrote:
> > The only means available for testing OA data is the TestOa metric set, so
> > use that also for media OA.
> >
> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>
> yeah, TestOa of OAM should be good enough.
>
> Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

Unfortunately, looks like TestOa does *not* work for OAM, the counters are
not incrementing by gpu_ticks etc. So this patch needs to be dropped. Thanks!

>
>
> > ---
> > tests/intel/xe_oa.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
> > index f3ce37ff5a..0914054460 100644
> > --- a/tests/intel/xe_oa.c
> > +++ b/tests/intel/xe_oa.c
> > @@ -338,7 +338,7 @@ static struct intel_xe_perf_metric_set *metric_set(const struct drm_xe_engine_cl
> >	else if ((hwe->engine_class == DRM_XE_ENGINE_CLASS_VIDEO_DECODE ||
> >		  hwe->engine_class == DRM_XE_ENGINE_CLASS_VIDEO_ENHANCE) &&
> >		 HAS_OAM(devid))
> > -		test_set_name = "MediaSet1";
> > +		test_set_name = "TestOa";
> >	else
> >		igt_assert(!"reached");
> >
> > --
> > 2.48.1
> >