From: Jonathan Cavitt <jonathan.cavitt@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com,
jonathan.cavitt@intel.com, umesh.nerlige.ramappa@intel.com,
ashutosh.dixit@intel.com
Subject: [PATCH] tests/intel/xe_oa: Remove buffer overflow guard from buffer-size tests
Date: Fri, 18 Apr 2025 20:51:54 +0000 [thread overview]
Message-ID: <20250418205154.345960-1-jonathan.cavitt@intel.com> (raw)
The guard was a holdover from i915 that is not relevant to Xe because
the buffer contents are preserved during an overflow. Remove the check.
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/4541
Suggested-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Suggested-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
---
tests/intel/xe_oa.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
index 1fc8bfaafe..7d13bd340a 100644
--- a/tests/intel/xe_oa.c
+++ b/tests/intel/xe_oa.c
@@ -2503,10 +2503,6 @@ test_non_zero_reason(const struct drm_xe_engine_class_instance *hwe, size_t oa_b
while (total_len < buf_size &&
((len = read(stream_fd, &buf[total_len], buf_size - total_len)) > 0 ||
(len == -1 && (errno == EINTR || errno == EIO)))) {
- if (errno == EIO) {
- oa_status = get_stream_status(stream_fd);
- igt_assert(!(oa_status & DRM_XE_OASTATUS_BUFFER_OVERFLOW));
- }
if (len > 0)
total_len += len;
}
--
2.43.0
next reply other threads:[~2025-04-18 20:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 20:51 Jonathan Cavitt [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-04-18 20:42 [PATCH] tests/intel/xe_oa: Remove buffer overflow guard from buffer-size tests Jonathan Cavitt
2025-04-18 20:45 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250418205154.345960-1-jonathan.cavitt@intel.com \
--to=jonathan.cavitt@intel.com \
--cc=alex.zuo@intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=saurabhg.gupta@intel.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox