Re: [PATCH] tests/intel/xe_oa: Remove buffer overflow guard from buffer-size tests

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Fri, 18 Apr 2025 13:42:02 -0700, Jonathan Cavitt wrote:
>
> The guard was a holdover from i915 that is not relevant to Xe because
> the buffer contents are preserved during an overflow.  Remove the check.
>
> Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/4541
> Suggested-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> Suggested-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> ---
>  tests/intel/xe_oa.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
> index 1fc8bfaafe..7d13bd340a 100644
> --- a/tests/intel/xe_oa.c
> +++ b/tests/intel/xe_oa.c
> @@ -2503,10 +2503,6 @@ test_non_zero_reason(const struct drm_xe_engine_class_instance *hwe, size_t oa_b
>	while (total_len < buf_size &&
>	       ((len = read(stream_fd, &buf[total_len], buf_size - total_len)) > 0 ||
>		(len == -1 && (errno == EINTR || errno == EIO)))) {
> -		if (errno == EIO) {
> -			oa_status = get_stream_status(stream_fd);
> -			igt_assert(!(oa_status & DRM_XE_OASTATUS_BUFFER_OVERFLOW));
> -		}

		if (errno == EIO) {
			oa_status = get_stream_status(stream_fd);

			/* Assert only for default OA buffer size */
			if (!oa_buffer_size)
				igt_assert(!(oa_status & DRM_XE_OASTATUS_BUFFER_OVERFLOW));
		}

>		if (len > 0)
>			total_len += len;
>	}
> --
> 2.43.0
>