Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cavitt <jonathan.cavitt@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: jonathan.cavitt@intel.com, satyanarayana.k.v.p@intel.com,
	michal.wajdeczko@intel.com, daniele.ceraolospurio@intel.com,
	lucas.demarchi@intel.com, francois.dugast@intel.com,
	rodrigo.vivi@intel.com, john.c.harrison@intel.com,
	kamil.konieczny@linux.intel.com
Subject: [PATCH v4 0/2] tests/intel/xe_fault_injection: Ignore all errors while injecting fault
Date: Fri,  6 Jun 2025 18:35:17 +0000	[thread overview]
Message-ID: <20250606183519.78736-1-jonathan.cavitt@intel.com> (raw)

Currently, numerous fault messages have been included in the dmesg
ignore list, and this list continues to expand.  Each time a new fault
injection point is introduced or a new feature is activated, additional
fault messages appear, making it cumbersome to manage the dmesg ignore
list.

However, we can safely assert that all dmesg reports that contain
*ERROR* in their message can be ignored, so add them to the dmesg ignore
list.  This unfortunately does not include the device probe error
itself, so that must be added separately.

While we're here, we should also assert that any errors we see are only
coming from the target PCI device.  We can do this by passing the
pci_slot name to the dmesg ignore list, which is generated during test
initialization.  In order to pass this information, all test functions
need to take the pci_slot name as a parameter.

Some functions already take the pci_slot name as a parameter but should
be modified to make the pci_slot parameter a const variable.

v2:
- Only ignore error-level dmesg reports (or, at least, reports with
  *ERROR* in them), and device probe failues
- Add PCI data to regex (Michal)

v3: (Michal)
- Revert name change
- Add change log
- Remove fixes tag from commit
- Rename ignore_faults_in_dmesg to igt_ignore_dmesg_errors_from_dut, and
  move to lib/igt_core.c
- Minor code fixes

v4:
- Return ignore_faults_in_dmesg to tests/intel/xe_fault_injection.c, but
  keep it renamed to ignore_dmesg_errors_from_dut (Kamil)

v5:
- Pass preexisting pci name instead of attempting to regenerate it on
  each run of ignore_dmesg_errors_from_dut (Daniele)
- Make pci_slot a const parameter (John)

Signed-off-by: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Suggested-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Suggested-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Francois Dugast <francois.dugast@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: John Harrison <john.c.harrison@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>

Jonathan Cavitt (1):
  tests/intel/xe_fault_injection: Make pci_slot const

Satyanarayana K V P (1):
  tests/intel/xe_fault_injection: Ignore all errors while injecting
    fault

 tests/intel/xe_fault_injection.c | 64 +++++++++++++++-----------------
 1 file changed, 29 insertions(+), 35 deletions(-)

-- 
2.43.0


             reply	other threads:[~2025-06-06 18:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-06 18:35 Jonathan Cavitt [this message]
2025-06-06 18:35 ` [PATCH v4 1/2] tests/intel/xe_fault_injection: Make pci_slot const Jonathan Cavitt
2025-06-09  8:29   ` K V P, Satyanarayana
2025-06-09 14:05     ` Cavitt, Jonathan
2025-06-10 10:54   ` Kamil Konieczny
2025-06-06 18:35 ` [PATCH v4 2/2] tests/intel/xe_fault_injection: Ignore all errors while injecting fault Jonathan Cavitt
2025-06-09 18:22   ` Daniele Ceraolo Spurio
2025-06-10 18:45     ` Kamil Konieczny
2025-06-06 19:22 ` ✓ Xe.CI.BAT: success for tests/intel/xe_fault_injection: Ignore all errors while injecting fault (rev6) Patchwork
2025-06-06 19:36 ` ✓ i915.CI.BAT: " Patchwork
2025-06-07  6:58 ` ✗ i915.CI.Full: failure " Patchwork
2025-06-09  1:41 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250606183519.78736-1-jonathan.cavitt@intel.com \
    --to=jonathan.cavitt@intel.com \
    --cc=daniele.ceraolospurio@intel.com \
    --cc=francois.dugast@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=john.c.harrison@intel.com \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=lucas.demarchi@intel.com \
    --cc=michal.wajdeczko@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=satyanarayana.k.v.p@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox