Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cavitt <jonathan.cavitt@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: jonathan.cavitt@intel.com, satyanarayana.k.v.p@intel.com,
	michal.wajdeczko@intel.com, daniele.ceraolospurio@intel.com,
	lucas.demarchi@intel.com, francois.dugast@intel.com,
	rodrigo.vivi@intel.com, john.c.harrison@intel.com,
	kamil.konieczny@linux.intel.com
Subject: [PATCH v4 1/2] tests/intel/xe_fault_injection: Make pci_slot const
Date: Fri,  6 Jun 2025 18:35:18 +0000	[thread overview]
Message-ID: <20250606183519.78736-2-jonathan.cavitt@intel.com> (raw)
In-Reply-To: <20250606183519.78736-1-jonathan.cavitt@intel.com>

The pci_slot string is passed to multiple functions in
xe_fault_injection.  It is also unmodified in those functions, so should
be passed as a const.

Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Suggested-by: John Harrison <john.c.harrison@intel.com>
---
 tests/intel/xe_fault_injection.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/intel/xe_fault_injection.c b/tests/intel/xe_fault_injection.c
index 9fe6bfe351..7a14ad1729 100644
--- a/tests/intel/xe_fault_injection.c
+++ b/tests/intel/xe_fault_injection.c
@@ -228,7 +228,7 @@ static void set_retval(const char function_name[], long long retval)
  * @xe_wopcm_init:			xe_wopcm_init
  */
 static int
-inject_fault_probe(int fd, char pci_slot[], const char function_name[])
+inject_fault_probe(int fd, const char pci_slot[], const char function_name[])
 {
 	int err = 0;
 	igt_info("Injecting error \"%s\" (%d) in function \"%s\"\n",
@@ -255,7 +255,7 @@ inject_fault_probe(int fd, char pci_slot[], const char function_name[])
  * @xe_guc_mmio_send_recv:     Inject an error when calling xe_guc_mmio_send_recv
  * @xe_guc_ct_send_recv:       Inject an error when calling xe_guc_ct_send_recv
  */
-static void probe_fail_guc(int fd, char pci_slot[], const char function_name[],
+static void probe_fail_guc(int fd, const char pci_slot[], const char function_name[],
                struct fault_injection_params *fault_params)
 {
 	int iter_start = 0, iter_end = 0, iter = 0;
-- 
2.43.0


  reply	other threads:[~2025-06-06 18:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-06 18:35 [PATCH v4 0/2] tests/intel/xe_fault_injection: Ignore all errors while injecting fault Jonathan Cavitt
2025-06-06 18:35 ` Jonathan Cavitt [this message]
2025-06-09  8:29   ` [PATCH v4 1/2] tests/intel/xe_fault_injection: Make pci_slot const K V P, Satyanarayana
2025-06-09 14:05     ` Cavitt, Jonathan
2025-06-10 10:54   ` Kamil Konieczny
2025-06-06 18:35 ` [PATCH v4 2/2] tests/intel/xe_fault_injection: Ignore all errors while injecting fault Jonathan Cavitt
2025-06-09 18:22   ` Daniele Ceraolo Spurio
2025-06-10 18:45     ` Kamil Konieczny
2025-06-06 19:22 ` ✓ Xe.CI.BAT: success for tests/intel/xe_fault_injection: Ignore all errors while injecting fault (rev6) Patchwork
2025-06-06 19:36 ` ✓ i915.CI.BAT: " Patchwork
2025-06-07  6:58 ` ✗ i915.CI.Full: failure " Patchwork
2025-06-09  1:41 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250606183519.78736-2-jonathan.cavitt@intel.com \
    --to=jonathan.cavitt@intel.com \
    --cc=daniele.ceraolospurio@intel.com \
    --cc=francois.dugast@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=john.c.harrison@intel.com \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=lucas.demarchi@intel.com \
    --cc=michal.wajdeczko@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=satyanarayana.k.v.p@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox