Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] tests/kms_plane: Allow planar-pixel-format-settings to pass on VKMS
@ 2026-02-16 18:52 Kamil Konieczny
  2026-02-16 19:43 ` ✓ Xe.CI.BAT: success for tests/kms_plane: Allow planar-pixel-format-settings to pass on VKMS (rev2) Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 13+ messages in thread
From: Kamil Konieczny @ 2026-02-16 18:52 UTC (permalink / raw)
  To: igt-dev
  Cc: Renjun Wang, Karthik B S, Swati Sharma, Louis Chauvet, Leo Li,
	Kamil Konieczny

From: Renjun Wang <renjunw0@foxmail.com>

Enable planar-pixel-format-settings subtests when running on VKMS
driver. VKMS currently accepts odd width|height for NV12, odd
horizontal panning for NV12, and odd vertical panning for P016
formats.

Cc: Karthik B S <karthik.b.s@intel.com>
Cc: Swati Sharma <swati2.sharma@intel.com>
Cc: Louis Chauvet <louis.chauvet@bootlin.com>
Cc: Leo Li <sunpeng.li@amd.com>
Signed-off-by: Renjun Wang <renjunw0@foxmail.com>
Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
Reformatted descriptions, also left one comment for Intel. Kamil

 tests/kms_plane.c | 28 ++++++++++++++++------------
 1 file changed, 16 insertions(+), 12 deletions(-)

diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 362748cdb..a6dcb5585 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -1331,11 +1331,9 @@ static void test_planar_settings(data_t *data)
 	int devid;
 	int display_ver = -1;
 	int rval;
+	bool is_intel = false;
+	bool is_vkms = false;
 
-	/*
-	 * If here is added non-intel tests below require will need to be
-	 * changed to if(..)
-	 */
 	igt_require_f(data->display.is_atomic, "Atomic mode-set not supported\n");
 	if (is_intel_device(data->drm_fd)) {
 		igt_require_intel(data->drm_fd);
@@ -1343,6 +1341,9 @@ static void test_planar_settings(data_t *data)
 		igt_require(intel_display_ver(devid) >= 9);
 		display_ver = intel_display_ver(devid);
 		igt_require(display_ver >= 9);
+		is_intel = true;
+	} else if (is_vkms_device(data->drm_fd)) {
+		is_vkms = true;
 	}
 
 	output = igt_get_single_output_for_pipe(&data->display, pipe);
@@ -1354,13 +1355,15 @@ static void test_planar_settings(data_t *data)
 	igt_display_commit_atomic(&data->display,
 				  DRM_MODE_ATOMIC_ALLOW_MODESET,
 				  NULL);
-
-	/* test against intel_plane_check_src_coordinates() in i915 */
+	/*
+	 * Test odd width for NV12 format.
+	 * For Intel i915/xe test against intel_plane_check_src_coordinates()
+	 */
 	if (igt_plane_has_format_mod(primary, DRM_FORMAT_NV12,
 				     DRM_FORMAT_MOD_LINEAR)) {
 		int expected_rval = -EINVAL;
 
-		if (display_ver >= 20)
+		if ((is_intel && display_ver >= 20) || is_vkms)
 			expected_rval = 0;
 
 		igt_create_fb(data->drm_fd, 257, 256,
@@ -1376,12 +1379,12 @@ static void test_planar_settings(data_t *data)
 		igt_debug("Odd width NV12 framebuffer test skipped\n");
 	}
 
-	/* test against intel_plane_check_src_coordinates() in i915 */
+	/* Test odd height for NV12 format. */
 	if (igt_plane_has_format_mod(primary, DRM_FORMAT_NV12,
 				     DRM_FORMAT_MOD_LINEAR)) {
 		int expected_rval = -EINVAL;
 
-		if (display_ver >= 20 && display_ver < 35)
+		if ((is_intel && display_ver >= 20 && display_ver < 35) || is_vkms)
 			expected_rval = 0;
 
 		igt_create_fb(data->drm_fd, 256, 257,
@@ -1397,12 +1400,12 @@ static void test_planar_settings(data_t *data)
 		igt_debug("Odd height NV12 framebuffer test skipped\n");
 	}
 
-	/* test against intel_plane_check_src_coordinates() in i915 */
+	/* Test odd horizontal panning for NV12 format. */
 	if (igt_plane_has_format_mod(primary, DRM_FORMAT_NV12,
 				     DRM_FORMAT_MOD_LINEAR)) {
 		int expected_rval = -EINVAL;
 
-		if (display_ver >= 35)
+		if ((is_intel && display_ver >= 35) || is_vkms)
 			expected_rval = 0;
 
 		igt_create_fb(data->drm_fd, 810, 590,
@@ -1419,11 +1422,12 @@ static void test_planar_settings(data_t *data)
 		igt_debug("Odd horizontal pan NV12 framebuffer test skipped\n");
 	}
 
+	/* Test odd vertical panning for P016 format. */
 	if (igt_plane_has_format_mod(primary, DRM_FORMAT_P016,
 					    DRM_FORMAT_MOD_LINEAR)) {
 		int expected_rval = -EINVAL;
 
-		if (display_ver >= 20 && display_ver < 35)
+		if ((is_intel && display_ver >= 20 && display_ver < 35) || is_vkms)
 			expected_rval = 0;
 
 		igt_create_color_fb(data->drm_fd, 256, 260,
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [PATCH i-g-t] tests/kms_plane: Allow planar-pixel-format-settings to pass on VKMS
@ 2026-03-20 10:16 Kamil Konieczny
  2026-03-24  9:44 ` Louis Chauvet
  0 siblings, 1 reply; 13+ messages in thread
From: Kamil Konieczny @ 2026-03-20 10:16 UTC (permalink / raw)
  To: igt-dev; +Cc: Renjun Wang, Swati Sharma, Kamil Konieczny

From: Renjun Wang <renjunw0@foxmail.com>

Enable planar-pixel-format-settings subtests when running on VKMS
driver. VKMS currently accepts odd width|height for NV12, odd
horizontal panning for NV12, and odd vertical panning for P016
format.

v2: remove is_intel var (Kamil), keep all comments (Swati)

Cc: Swati Sharma <swati2.sharma@intel.com>
Signed-off-by: Renjun Wang <renjunw0@foxmail.com>
Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
 tests/kms_plane.c | 35 +++++++++++++++++++++++------------
 1 file changed, 23 insertions(+), 12 deletions(-)

diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index d5bab62bb..7f7e2d9a6 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -1365,11 +1365,8 @@ static void test_planar_settings(data_t *data)
 	int devid;
 	int display_ver = -1;
 	int rval;
+	bool is_vkms = false;
 
-	/*
-	 * If here is added non-intel tests below require will need to be
-	 * changed to if(..)
-	 */
 	igt_require_f(data->display.is_atomic, "Atomic mode-set not supported\n");
 	if (is_intel_device(data->drm_fd)) {
 		igt_require_intel(data->drm_fd);
@@ -1377,6 +1374,8 @@ static void test_planar_settings(data_t *data)
 		igt_require(intel_display_ver(devid) >= 9);
 		display_ver = intel_display_ver(devid);
 		igt_require(display_ver >= 9);
+	} else if (is_vkms_device(data->drm_fd)) {
+		is_vkms = true;
 	}
 
 	crtc = igt_first_crtc_with_single_output(display, &output);
@@ -1387,13 +1386,15 @@ static void test_planar_settings(data_t *data)
 	igt_display_commit_atomic(&data->display,
 				  DRM_MODE_ATOMIC_ALLOW_MODESET,
 				  NULL);
-
-	/* test against intel_plane_check_src_coordinates() in i915 */
+	/*
+	 * Test odd width for NV12 format.
+	 * For Intel i915/xe test against intel_plane_check_src_coordinates()
+	 */
 	if (igt_plane_has_format_mod(primary, DRM_FORMAT_NV12,
 				     DRM_FORMAT_MOD_LINEAR)) {
 		int expected_rval = -EINVAL;
 
-		if (display_ver >= 20)
+		if (display_ver >= 20 || is_vkms)
 			expected_rval = 0;
 
 		igt_create_fb(data->drm_fd, 257, 256,
@@ -1409,12 +1410,15 @@ static void test_planar_settings(data_t *data)
 		igt_debug("Odd width NV12 framebuffer test skipped\n");
 	}
 
-	/* test against intel_plane_check_src_coordinates() in i915 */
+	/*
+	 * Test odd height for NV12 format.
+	 * For Intel i915/xe test against intel_plane_check_src_coordinates()
+	 */
 	if (igt_plane_has_format_mod(primary, DRM_FORMAT_NV12,
 				     DRM_FORMAT_MOD_LINEAR)) {
 		int expected_rval = -EINVAL;
 
-		if (display_ver >= 20 && display_ver < 35)
+		if ((display_ver >= 20 && display_ver < 35) || is_vkms)
 			expected_rval = 0;
 
 		igt_create_fb(data->drm_fd, 256, 257,
@@ -1430,12 +1434,15 @@ static void test_planar_settings(data_t *data)
 		igt_debug("Odd height NV12 framebuffer test skipped\n");
 	}
 
-	/* test against intel_plane_check_src_coordinates() in i915 */
+	/*
+	 * Test odd horizontal panning for NV12 format.
+	 * For Intel i915/xe test against intel_plane_check_src_coordinates()
+	 */
 	if (igt_plane_has_format_mod(primary, DRM_FORMAT_NV12,
 				     DRM_FORMAT_MOD_LINEAR)) {
 		int expected_rval = -EINVAL;
 
-		if (display_ver >= 35)
+		if (display_ver >= 35 || is_vkms)
 			expected_rval = 0;
 
 		igt_create_fb(data->drm_fd, 810, 590,
@@ -1452,11 +1459,15 @@ static void test_planar_settings(data_t *data)
 		igt_debug("Odd horizontal pan NV12 framebuffer test skipped\n");
 	}
 
+	/*
+	 * Test odd vertical panning for P016 format.
+	 * For Intel i915/xe test against intel_plane_check_src_coordinates()
+	 */
 	if (igt_plane_has_format_mod(primary, DRM_FORMAT_P016,
 					    DRM_FORMAT_MOD_LINEAR)) {
 		int expected_rval = -EINVAL;
 
-		if (display_ver >= 20 && display_ver < 35)
+		if ((display_ver >= 20 && display_ver < 35) || is_vkms)
 			expected_rval = 0;
 
 		igt_create_color_fb(data->drm_fd, 256, 260,
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [PATCH i-g-t] tests/kms_plane: Allow planar-pixel-format-settings to pass on VKMS
@ 2026-02-01  6:11 Renjun Wang
  2026-02-04 12:29 ` Kamil Konieczny
  0 siblings, 1 reply; 13+ messages in thread
From: Renjun Wang @ 2026-02-01  6:11 UTC (permalink / raw)
  To: igt-dev; +Cc: Renjun Wang

Set expected_rval to 0 for planar-pixel-format-settings tests when
running on VKMS driver. VKMS currently accepts odd width/height for
NV12, odd horizontal panning for NV12, and odd vertical panning for
P016 formats.

Signed-off-by: Renjun Wang <renjunw0@foxmail.com>
---
 tests/kms_plane.c | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 21d80847c..57adfe199 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -1313,11 +1313,9 @@ static void test_planar_settings(data_t *data)
 	int devid;
 	int display_ver = -1;
 	int rval;
+	bool is_intel = false;
+	bool is_vkms = false;
 
-	/*
-	 * If here is added non-intel tests below require will need to be
-	 * changed to if(..)
-	 */
 	igt_require_f(data->display.is_atomic, "Atomic mode-set not supported\n");
 	if (is_intel_device(data->drm_fd)) {
 		igt_require_intel(data->drm_fd);
@@ -1325,6 +1323,9 @@ static void test_planar_settings(data_t *data)
 		igt_require(intel_display_ver(devid) >= 9);
 		display_ver = intel_display_ver(devid);
 		igt_require(display_ver >= 9);
+		is_intel = true;
+	} else if (is_vkms_device(data->drm_fd)) {
+		is_vkms = true;
 	}
 
 	output = igt_get_single_output_for_pipe(&data->display, pipe);
@@ -1337,12 +1338,12 @@ static void test_planar_settings(data_t *data)
 				  DRM_MODE_ATOMIC_ALLOW_MODESET,
 				  NULL);
 
-	/* test against intel_plane_check_src_coordinates() in i915 */
+	/* Test odd width for NV12 format */
 	if (igt_plane_has_format_mod(primary, DRM_FORMAT_NV12,
 				     DRM_FORMAT_MOD_LINEAR)) {
 		int expected_rval = -EINVAL;
 
-		if (display_ver >= 20)
+		if ((is_intel && display_ver >= 20) || is_vkms)
 			expected_rval = 0;
 
 		igt_create_fb(data->drm_fd, 257, 256,
@@ -1358,12 +1359,12 @@ static void test_planar_settings(data_t *data)
 		igt_debug("Odd width NV12 framebuffer test skipped\n");
 	}
 
-	/* test against intel_plane_check_src_coordinates() in i915 */
+	/* Test odd height for NV12 format */
 	if (igt_plane_has_format_mod(primary, DRM_FORMAT_NV12,
 				     DRM_FORMAT_MOD_LINEAR)) {
 		int expected_rval = -EINVAL;
 
-		if (display_ver >= 20 && display_ver < 35)
+		if ((is_intel && display_ver >= 20 && display_ver < 35) || is_vkms)
 			expected_rval = 0;
 
 		igt_create_fb(data->drm_fd, 256, 257,
@@ -1378,13 +1379,12 @@ static void test_planar_settings(data_t *data)
 	} else {
 		igt_debug("Odd height NV12 framebuffer test skipped\n");
 	}
-
-	/* test against intel_plane_check_src_coordinates() in i915 */
+	/*Test odd horizontal panning for NV12 format */
 	if (igt_plane_has_format_mod(primary, DRM_FORMAT_NV12,
 				     DRM_FORMAT_MOD_LINEAR)) {
 		int expected_rval = -EINVAL;
 
-		if (display_ver >= 35)
+		if ((is_intel && display_ver >= 35) || is_vkms)
 			expected_rval = 0;
 
 		igt_create_fb(data->drm_fd, 810, 590,
@@ -1401,11 +1401,12 @@ static void test_planar_settings(data_t *data)
 		igt_debug("Odd horizontal pan NV12 framebuffer test skipped\n");
 	}
 
+	/* Test odd vertical panning for P016 format */
 	if (igt_plane_has_format_mod(primary, DRM_FORMAT_P016,
 					    DRM_FORMAT_MOD_LINEAR)) {
 		int expected_rval = -EINVAL;
 
-		if (display_ver >= 20 && display_ver < 35)
+		if ((is_intel && display_ver >= 20 && display_ver < 35) || is_vkms)
 			expected_rval = 0;
 
 		igt_create_color_fb(data->drm_fd, 256, 260,
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2026-03-24  9:43 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-16 18:52 [PATCH i-g-t] tests/kms_plane: Allow planar-pixel-format-settings to pass on VKMS Kamil Konieczny
2026-02-16 19:43 ` ✓ Xe.CI.BAT: success for tests/kms_plane: Allow planar-pixel-format-settings to pass on VKMS (rev2) Patchwork
2026-02-16 20:03 ` ✓ i915.CI.BAT: " Patchwork
2026-02-16 22:22 ` ✗ i915.CI.Full: failure " Patchwork
2026-02-16 23:52 ` ✗ Xe.CI.FULL: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2026-03-20 10:16 [PATCH i-g-t] tests/kms_plane: Allow planar-pixel-format-settings to pass on VKMS Kamil Konieczny
2026-03-24  9:44 ` Louis Chauvet
2026-02-01  6:11 Renjun Wang
2026-02-04 12:29 ` Kamil Konieczny
2026-02-20 12:09   ` Sharma, Swati2
2026-03-19  8:16     ` Renjun Wang
2026-03-19 18:11       ` Sharma, Swati2
2026-03-23 19:07         ` Kamil Konieczny

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox