public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Lukasz Laguna <lukasz.laguna@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: zbigniew.kempczynski@intel.com, lukasz.laguna@intel.com
Subject: [PATCH i-g-t] lib/igt_device_scan: Fix attributes fetching
Date: Mon, 23 Feb 2026 19:59:06 +0100	[thread overview]
Message-ID: <20260223185906.16168-2-lukasz.laguna@intel.com> (raw)
In-Reply-To: <20260223185906.16168-1-lukasz.laguna@intel.com>

Don't skip NULL attribute values too early, as some symlinks are not
resolved by udev and are handled later in igt_device_add_attr().

Signed-off-by: Lukasz Laguna <lukasz.laguna@intel.com>
---
 lib/igt_device_scan.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
index fc01fc375b..7c7995224b 100644
--- a/lib/igt_device_scan.c
+++ b/lib/igt_device_scan.c
@@ -593,8 +593,6 @@ static void get_attrs_limited(struct udev_device *dev, struct igt_device *idev)
 
 	for (int i = 0; i < ARRAY_SIZE(attrs); i++) {
 		value = udev_device_get_sysattr_value(dev, attrs[i]);
-		if (!value)
-			continue;
 		igt_device_add_attr(idev, attrs[i], value);
 		DBG("attr: %s, val: %s\n", attrs[i], value);
 	}
-- 
2.40.0


  reply	other threads:[~2026-02-23 19:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23 18:59 [PATCH i-g-t] lib/igt_device_scan: Fix attributes fetching Lukasz Laguna
2026-02-23 18:59 ` Lukasz Laguna [this message]
2026-02-24  7:44   ` Zbigniew Kempczyński
2026-02-23 23:05 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-02-23 23:23 ` ✗ i915.CI.BAT: failure " Patchwork
2026-02-24 14:58 ` ✓ Xe.CI.FULL: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260223185906.16168-2-lukasz.laguna@intel.com \
    --to=lukasz.laguna@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox