public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH i-g-t v2 1/3] tests/intel/xe_exec_reset: Add a comment about return for syncobj wait
@ 2026-04-13 21:19 Stuart Summers
  2026-04-13 21:19 ` [PATCH i-g-t v2 2/3] tests/intel/xe_exec_reset: Add checks for hanging queue wait_ufence return Stuart Summers
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: Stuart Summers @ 2026-04-13 21:19 UTC (permalink / raw)
  Cc: apoorva.singh, igt-dev, niranjana.vishwanathapura, daniel.charles,
	fei.yang, katarzyna.piecielska, priyanka.dandamudi,
	kamil.konieczny, Stuart Summers

Add a comment to the syncobj wait after a hanging submission
to indicate that even for the hang case, we expect the syncobj
wait to return successfully as opposed to the wait ufence case
where we only return successful if hardware did in fact execute
the batch through the MI_USER_INTERRUPT to satisfy the wait ufence.

Signed-off-by: Stuart Summers <stuart.summers@intel.com>
Reviewed-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
---
 lib/xe/xe_legacy.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/lib/xe/xe_legacy.c b/lib/xe/xe_legacy.c
index 084445305..6aeddc578 100644
--- a/lib/xe/xe_legacy.c
+++ b/lib/xe/xe_legacy.c
@@ -181,8 +181,13 @@ xe_legacy_test_mode(int fd, struct drm_xe_engine_class_instance *eci,
 		return;
 	}
 
-	for (i = 0; i < n_exec_queues && n_execs; i++)
+	for (i = 0; i < n_exec_queues && n_execs; i++) {
+		/*
+		 * Expectation here is that on reset, submissions will
+		 * still satisfy the syncobj_wait.
+		 */
 		igt_assert(syncobj_wait(fd, &syncobjs[i], 1, INT64_MAX, 0, NULL));
+	}
 
 	igt_assert(syncobj_wait(fd, &sync[0].handle, 1, INT64_MAX, 0, NULL));
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-04-14  8:51 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-13 21:19 [PATCH i-g-t v2 1/3] tests/intel/xe_exec_reset: Add a comment about return for syncobj wait Stuart Summers
2026-04-13 21:19 ` [PATCH i-g-t v2 2/3] tests/intel/xe_exec_reset: Add checks for hanging queue wait_ufence return Stuart Summers
2026-04-13 21:19 ` [PATCH i-g-t v2 3/3] tests/intel/xe_exec_reset: Add multi queue subtests Stuart Summers
2026-04-14  2:22 ` ✓ i915.CI.BAT: success for series starting with [i-g-t,v2,1/3] tests/intel/xe_exec_reset: Add a comment about return for syncobj wait Patchwork
2026-04-14  2:39 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-14  6:11 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-04-14  8:50 ` ✗ i915.CI.Full: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox