From: Alex Hung <alex.hung@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: <aurabindo.pillai@amd.com>, Alex Hung <alex.hung@amd.com>
Subject: [PATCH] tests/amdgpu: Fix typos and grammar in comments
Date: Wed, 15 Apr 2026 10:53:24 -0600 [thread overview]
Message-ID: <20260415165324.918274-1-alex.hung@amd.com> (raw)
Fix spelling and grammar issues in the following tests.
amd_dp_dsc.c:
- 'Maximumm' -> 'Maximum'
- 'outpus' -> 'outputs'
- 'horisontal' -> 'horizontal'
- 'v_ative' -> 'v_active'
amd_hotplug.c:
- Capitalize 'return' to 'Return' in function comment
- Add missing article 'the' before 'reference image'
amd_mem_leak.c:
- 'amdpgu' -> 'amdgpu'
- 'memroy' -> 'memory'
amd_vrr_range.c:
- 'Maximumm' -> 'Maximum'
- 'more safe margin' -> 'more safety margin'
- Add missing article 'a' before 'golden sample'
- 'Cannot parsing' -> 'Cannot parse'
Assisted-by: GitHubCopilot:claude-sonnet-4.6
Signed-off-by: Alex Hung <alex.hung@amd.com>
---
tests/amdgpu/amd_dp_dsc.c | 8 ++++----
tests/amdgpu/amd_hotplug.c | 4 ++--
tests/amdgpu/amd_mem_leak.c | 4 ++--
tests/amdgpu/amd_vrr_range.c | 8 ++++----
4 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/tests/amdgpu/amd_dp_dsc.c b/tests/amdgpu/amd_dp_dsc.c
index b84411636..1742c7df4 100644
--- a/tests/amdgpu/amd_dp_dsc.c
+++ b/tests/amdgpu/amd_dp_dsc.c
@@ -28,7 +28,7 @@
#define NUM_SLICE_SLOTS 4
-/* Maximumm pipes on any AMD ASIC. */
+/* Maximum pipes on any AMD ASIC. */
#define MAX_PIPES 6
/* Common test data. */
@@ -82,7 +82,7 @@ static void test_init(data_t *data)
if (!igt_output_is_connected(output))
continue;
- /* Ensure that outpus are DP, DSC & FEC capable */
+ /* Ensure that outputs are DP, DSC & FEC capable */
if (!(is_dp_fec_supported(data->fd, output->name) &&
is_dp_dsc_supported(data->fd, output->name)))
continue;
@@ -236,7 +236,7 @@ static bool update_slice_width(data_t *data,
igt_plane_set_fb(data->primary[conn_idx], &ref_fb);
igt_display_commit_atomic(&data->display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
- igt_info("Forcing slice width: slice width %d num slices horisontal %d\n", slice_width, num_slices[i]);
+ igt_info("Forcing slice width: slice width %d num slices horizontal %d\n", slice_width, num_slices[i]);
act_slice_width = igt_amd_read_dsc_param_slice_width(data->fd, output->name);
@@ -293,7 +293,7 @@ static void test_dsc_slice_dimensions_change(data_t *data)
h_addressable = data->mode->hdisplay;
v_addressable = data->mode->vdisplay;
- igt_info("Mode info: v_ative %d h_active %d\n", v_addressable, h_addressable);
+ igt_info("Mode info: v_active %d h_active %d\n", v_addressable, h_addressable);
/* Save pipe's initial DSC state */
dsc_before = igt_amd_read_dsc_clock_status(data->fd, output->name);
diff --git a/tests/amdgpu/amd_hotplug.c b/tests/amdgpu/amd_hotplug.c
index 83ad55ea0..c54288e90 100644
--- a/tests/amdgpu/amd_hotplug.c
+++ b/tests/amdgpu/amd_hotplug.c
@@ -122,7 +122,7 @@ static bool is_system_s2idle(void)
return strstr(dst, "[s2idle]");
}
-/* return the last hw_sleep duration time */
+/* Return the last hw_sleep duration time */
static int get_last_hw_sleep_time(void)
{
int fd;
@@ -189,7 +189,7 @@ static void test_hotplug_basic(data_t *data, bool suspend)
"Suspend did not reach hardware sleep state\n");
}
- /* Trigger hotplug and confirm reference image is the same. */
+ /* Trigger hotplug and confirm the reference image is the same. */
for_each_crtc(&data->display, crtc) {
output = data->output[crtc->crtc_index];
if (!output || !igt_output_is_connected(output))
diff --git a/tests/amdgpu/amd_mem_leak.c b/tests/amdgpu/amd_mem_leak.c
index 1e55fe785..1d7aa3a2f 100644
--- a/tests/amdgpu/amd_mem_leak.c
+++ b/tests/amdgpu/amd_mem_leak.c
@@ -45,7 +45,7 @@ static void test_init(data_t *data)
{
igt_display_t *display = &data->display;
- /* It doesn't matter which pipe we choose on amdpgu. */
+ /* It doesn't matter which pipe we choose on amdgpu. */
data->crtc = igt_first_crtc(&data->display);
igt_display_reset(display);
@@ -167,7 +167,7 @@ int igt_main()
igt_describe("Test memory leaks after resume from suspend");
igt_subtest("connector-suspend-resume") test_suspend_resume(&data);
- igt_describe("Test memroy leaks after connector hotplug");
+ igt_describe("Test memory leaks after connector hotplug");
igt_subtest("connector-hotplug") test_hotplug(&data);
igt_describe("Test memory leaks with driver unload");
igt_subtest("driver-unload") test_driver_unload(&data);
diff --git a/tests/amdgpu/amd_vrr_range.c b/tests/amdgpu/amd_vrr_range.c
index cc3323df3..4397f3c15 100644
--- a/tests/amdgpu/amd_vrr_range.c
+++ b/tests/amdgpu/amd_vrr_range.c
@@ -28,7 +28,7 @@
IGT_TEST_DESCRIPTION("Test EDID parsing and debugfs reporting on Freesync displays");
-/* Maximumm pipes on any AMD ASIC. */
+/* Maximum pipes on any AMD ASIC. */
#define MAX_PIPES 6
#define EDID_SIZE 256
#define EDID_PATH "/sys/class/drm/card%d-%s/edid"
@@ -249,7 +249,7 @@ static void trigger_edid_parse(data_t *data, igt_output_t *output, uint32_t test
else
igt_amd_trigger_hotplug(data->fd, output->name);
- /* more safe margin until resume and hotplug is completed */
+ /* more safety margin until resume and hotplug is completed */
usleep(1500000);
}
@@ -325,7 +325,7 @@ static bool find_vrr_range_from_edid(data_t *data, igt_output_t *output)
}
/* Check if EDID parsing is correctly reporting Freesync capability
- * by overriding EDID with ones from golden sample.
+ * by overriding EDID with ones from a golden sample.
*/
static void test_freesync_parsing_base(data_t *data, uint32_t test_flags)
{
@@ -354,7 +354,7 @@ static void test_freesync_parsing_base(data_t *data, uint32_t test_flags)
trigger_edid_parse(data, output, test_flags);
igt_assert_f(find_vrr_range_from_edid(data, output),
- "Cannot parsing VRR range from EDID\n");
+ "Cannot parse VRR range from EDID\n");
expected_range.min = data->expected_range.min;
expected_range.max = data->expected_range.max;
--
2.43.0
next reply other threads:[~2026-04-15 16:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 16:53 Alex Hung [this message]
2026-04-15 17:56 ` ✓ Xe.CI.BAT: success for tests/amdgpu: Fix typos and grammar in comments Patchwork
2026-04-15 18:23 ` ✓ i915.CI.BAT: " Patchwork
2026-04-15 19:01 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-04-16 5:42 ` [PATCH] " Karthik B S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260415165324.918274-1-alex.hung@amd.com \
--to=alex.hung@amd.com \
--cc=aurabindo.pillai@amd.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox