public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] tests/kms_invalid_mode: Remove outdated fixed mode check
@ 2026-04-15 18:28 Swati Sharma
  2026-04-15 21:20 ` ✓ Xe.CI.BAT: success for " Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Swati Sharma @ 2026-04-15 18:28 UTC (permalink / raw)
  To: igt-dev; +Cc: Swati Sharma, Ville Syrjälä

Remove the has_scaling_mode_prop() check and associated FIXME in
adjust_mode_clock_too_high(). The kernel already rejects modes
whose vrefresh doesn't match any of the connector's fixed modes,
making this skip unnecessary.

v2: -remove the outdated fixed mode check entirely

Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_invalid_mode.c | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c
index 5edffb649..8bdfa70ef 100644
--- a/tests/kms_invalid_mode.c
+++ b/tests/kms_invalid_mode.c
@@ -72,14 +72,6 @@ struct _data {
 	bool (*adjust_mode)(data_t *data, drmModeModeInfoPtr mode);
 };
 
-static bool has_scaling_mode_prop(data_t *data)
-{
-	return kmstest_get_property(data->drm_fd,
-				    data->output->id,
-				    DRM_MODE_OBJECT_CONNECTOR,
-				    "scaling mode",
-				    NULL, NULL, NULL);
-}
 static bool
 can_bigjoiner(data_t *data)
 {
@@ -128,17 +120,6 @@ adjust_mode_clock_too_high(data_t *data, drmModeModeInfoPtr mode)
 
 	igt_require(max_dotclock != 0);
 
-	/*
-	 * FIXME When we have a fixed mode, the kernel will ignore
-	 * the user timings apart from hdisplay/vdisplay. Should
-	 * fix the kernel to at least make sure the requested
-	 * refresh rate as specified by the user timings will
-	 * roughly match the user will get. For now skip the
-	 * test on  any connector with a fixed mode.
-	 */
-	if (has_scaling_mode_prop(data))
-		return false;
-
 	/*
 	 * Newer platforms can support modes higher than the maximum dot clock
 	 * by using pipe joiner, so set the mode clock twice that of maximum
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-04-16  4:56 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-15 18:28 [PATCH i-g-t] tests/kms_invalid_mode: Remove outdated fixed mode check Swati Sharma
2026-04-15 21:20 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-04-15 21:32 ` ✓ i915.CI.BAT: " Patchwork
2026-04-15 23:09 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-04-16  3:04 ` [PATCH i-g-t] " Karthik B S
2026-04-16  4:56 ` ✓ i915.CI.Full: success for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox