From: Mohammed Thasleem <mohammed.thasleem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: swati2.sharma@intel.com, Mohammed Thasleem <mohammed.thasleem@intel.com>
Subject: [PATCH v2 1/7] Revert "tests/intel/kms_pm_dc: Ensure eDP detection before skipping test"
Date: Fri, 17 Apr 2026 14:05:00 +0530 [thread overview]
Message-ID: <20260417083506.33404-2-mohammed.thasleem@intel.com> (raw)
In-Reply-To: <20260417083506.33404-1-mohammed.thasleem@intel.com>
This reverts commit d063ceaeaf2d2d561670945e9e81b8976a16f080.
Signed-off-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
---
tests/intel/kms_pm_dc.c | 39 ++++++++++++++++-----------------------
1 file changed, 16 insertions(+), 23 deletions(-)
diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c
index 8138933d4..da74a21ce 100644
--- a/tests/intel/kms_pm_dc.c
+++ b/tests/intel/kms_pm_dc.c
@@ -543,38 +543,31 @@ static void test_deep_pkgc_state(data_t *data)
time_t delay;
igt_crtc_t *crtc;
bool pkgc_flag = false;
- bool flip = true, edp_found = false;
+ bool flip = true;
igt_display_t *display = &data->display;
igt_plane_t *primary;
igt_output_t *output = NULL;
drmModeModeInfo *mode;
- for_each_crtc_with_valid_output(display, crtc, output) {
- if (output->config.connector->connector_type == DRM_MODE_CONNECTOR_eDP) {
-
- edp_found = true;
- /* Check VRR capabilities before setting up */
- if (igt_output_has_prop(output, IGT_CONNECTOR_VRR_CAPABLE) &&
- igt_output_get_prop(output, IGT_CONNECTOR_VRR_CAPABLE)) {
- /*
- * TODO: Add check for vmin = vmax = flipline if VRR enabled
- * when KMD allows for such capability.
- */
- igt_crtc_set_prop_value(crtc, IGT_CRTC_VRR_ENABLED, false);
- igt_assert(igt_display_try_commit_atomic(display,
- DRM_MODE_ATOMIC_ALLOW_MODESET,
- NULL) == 0);
- }
+ for_each_pipe_with_valid_output(display, pipe, output) {
+ if (output->config.connector->connector_type != DRM_MODE_CONNECTOR_eDP)
+ igt_skip("No eDP output found, skipping the test.\n");
+ /* Check VRR capabilities before setting up */
+ if (igt_output_has_prop(output, IGT_CONNECTOR_VRR_CAPABLE) &&
+ igt_output_get_prop(output, IGT_CONNECTOR_VRR_CAPABLE)) {
+ /*
+ * TODO: Add check for vmin = vmax = flipline if VRR enabled
+ * when KMD allows for such capability.
+ */
+ igt_pipe_set_prop_value(display, pipe,
+ IGT_CRTC_VRR_ENABLED, false);
+ igt_assert(igt_display_try_commit_atomic(display,
+ DRM_MODE_ATOMIC_ALLOW_MODESET,
+ NULL) == 0);
break;
}
}
-
- if (!edp_found) {
- igt_skip("No eDP output found, skipping the test.\n");
- return;
- }
-
igt_display_reset(display);
igt_output_set_crtc(output, crtc);
--
2.43.0
next prev parent reply other threads:[~2026-04-17 8:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 8:34 [PATCH v2 0/7] Remove deep-pkgc subtest Mohammed Thasleem
2026-04-17 8:35 ` Mohammed Thasleem [this message]
2026-04-17 10:45 ` [PATCH v2 1/7] Revert "tests/intel/kms_pm_dc: Ensure eDP detection before skipping test" Kamil Konieczny
2026-04-20 12:58 ` Thasleem, Mohammed
2026-04-17 8:35 ` [PATCH v2 2/7] Revert "tests/intel/kms_pm_dc: Add polling for deep-pkgc" Mohammed Thasleem
2026-04-17 8:35 ` [PATCH v2 3/7] Revert "tests/intel/kms_pm_dc: Update test duration to 4 seconds" Mohammed Thasleem
2026-04-17 8:35 ` [PATCH v2 4/7] Revert "tests/intel/kms_pm_dc: Update VRR handling and eDP output check" Mohammed Thasleem
2026-04-17 8:35 ` [PATCH v2 5/7] Revert "tests/intel/kms_pm_dc: Add time unit macros and update delay calculation" Mohammed Thasleem
2026-04-17 8:35 ` [PATCH v2 6/7] Revert "tests/intel/kms_pm_dc: Add a new test to validate the deep sleep state during extended vblank" Mohammed Thasleem
2026-04-17 8:35 ` [PATCH v2 7/7] tests/intel/kms_pm_dc: Remove unused pkgc functions Mohammed Thasleem
2026-04-17 8:53 ` [PATCH v2 0/7] Remove deep-pkgc subtest Jani Nikula
2026-04-17 9:38 ` Sharma, Swati2
2026-04-17 10:29 ` Jani Nikula
2026-04-17 12:34 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260417083506.33404-2-mohammed.thasleem@intel.com \
--to=mohammed.thasleem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox