Re: [PATCH v2 0/7] Remove deep-pkgc subtest

[Jani Nikula <jani.nikula@intel.com>]

On Fri, 17 Apr 2026, "Sharma, Swati2" <swati2.sharma@intel.com> wrote:
> Hi Jani
>
> On 17-04-2026 02:23 pm, Jani Nikula wrote:
>> On Fri, 17 Apr 2026, Mohammed Thasleem <mohammed.thasleem@intel.com> wrote:
>>> Remove the deep-pkgc subtest as it depends on other display IPs which makes
>>> testing unreliable. Current validation uses Package C-state counters that
>>> are affected by unrelated system components and requires platform-specific
>>> checks that vary across different platforms.
>>> A redesigned test with proper display IP isolation will be implemented
>>> in a future patch.
>> Doing this in reverts like this breaks bisect.
>
> Then what's the best approach to follow?
>
> Even in git log, I can see such reverts.

Reverts are fine *in general*, but in this case it reverts back to
states that won't build. For example patch 1 adds
for_each_pipe_with_valid_output() which doesn't exist anymore.

Maybe you need to squash enough of these together to form commits that
build. Or all of them.

BR,
Jani.


>
>>
>> I basically do this on all of my series before submitting:
>>
>> $ git rebase -i origin -x 'ninja -C build'
>>
>>
>> BR,
>> Jani.
>>
>>> Mohammed Thasleem (7):
>>>    Revert "tests/intel/kms_pm_dc: Ensure eDP detection before skipping
>>>      test"
>>>    Revert "tests/intel/kms_pm_dc: Add polling for deep-pkgc"
>>>    Revert "tests/intel/kms_pm_dc: Update test duration to 4 seconds"
>>>    Revert "tests/intel/kms_pm_dc: Update VRR handling and eDP output
>>>      check"
>>>    Revert "tests/intel/kms_pm_dc: Add time unit macros and update delay
>>>      calculation"
>>>    Revert "tests/intel/kms_pm_dc: Add a new test to validate the deep
>>>      sleep state during extended vblank"
>>>    tests/intel/kms_pm_dc: Remove unused pkgc functions
>>>
>>>   tests/intel/kms_pm_dc.c | 98 -----------------------------------------
>>>   1 file changed, 98 deletions(-)

-- 
Jani Nikula, Intel