public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jing-Ping Jan <jingpingjan@google.com>
To: igt-dev@lists.freedesktop.org
Cc: Jing-Ping Jan <jingpingjan@google.com>
Subject: [PATCH i-g-t] tests/kms: correct index validation logic
Date: Mon, 20 Apr 2026 15:49:25 +0800	[thread overview]
Message-ID: <20260420074925.1710024-1-jingpingjan@google.com> (raw)

Based on the original implementation and the comment above the function,
it appears the expected behavior is for the plane indices to remain
consistent with those in crtc->planes. Therefore, after swapping the old
and new primary planes, we must update the index in igt_plane_t to
ensure it matches the corresponding index in crtc->planes.

Therefore, we should expect the indices of the old and new primary
planes to remain unchanged after swapping them.

Signed-off-by: Jing-Ping Jan <jingpingjan@google.com>
---
 lib/igt_kms.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index bec96f267..405a04640 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -2982,8 +2982,8 @@ void igt_display_reset_outputs(igt_display_t *display)
 				igt_swap(*old_primary, *new_primary);
 				igt_swap(old_primary->index, new_primary->index);
 
-				igt_assert_neq(old_primary->index, 0);
-				igt_assert_eq(new_primary->index, 0);
+				igt_assert_eq(old_primary->index, 0);
+				igt_assert_neq(new_primary->index, 0);
 			} else {
 				igt_assert(old_primary == new_primary);
 
-- 
2.54.0.rc1.513.gad8abe7a5a-goog


             reply	other threads:[~2026-04-20  9:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20  7:49 Jing-Ping Jan [this message]
2026-04-20 18:16 ` [PATCH i-g-t] tests/kms: correct index validation logic Kamil Konieczny
2026-04-21  2:07   ` Jing-Ping Jan
2026-04-21  6:13     ` Karthik B S
2026-04-21  6:43       ` [PATCH i-g-t v2] " Jing-Ping Jan
2026-04-21  9:28         ` Karthik B S
2026-04-21 12:02         ` Jani Nikula
2026-04-22 17:05           ` Kamil Konieczny
2026-04-22 17:23             ` Ville Syrjälä
2026-04-23  9:21               ` Jing-Ping Jan
2026-04-23  9:28                 ` [PATCH i-g-t v3] " Jing-Ping Jan
2026-04-23 10:27                 ` [PATCH i-g-t v2] " Kamil Konieczny
2026-04-23 10:40                 ` Ville Syrjälä
2026-04-21 21:28 ` ✓ i915.CI.BAT: success for tests/kms: correct index validation logic (rev2) Patchwork
2026-04-21 22:20 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-22  2:36 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-04-22  5:16 ` ✓ i915.CI.Full: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260420074925.1710024-1-jingpingjan@google.com \
    --to=jingpingjan@google.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox