public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH i-g-t v2] lib/drmtest: Create proper error report when open driver fails
@ 2026-04-21 14:59 Kamil Konieczny
  2026-04-21 15:42 ` Zbigniew Kempczyński
                   ` (5 more replies)
  0 siblings, 6 replies; 11+ messages in thread
From: Kamil Konieczny @ 2026-04-21 14:59 UTC (permalink / raw)
  To: igt-dev
  Cc: Kamil Konieczny, Ashutosh Dixit, Karthik B S,
	Zbigniew Kempczyński

When first try for opening driver fails then opening function is
searching for next available device. When that also fails
reporting is printing last errno which could mislead developer:

$ build/tests/kms_dp_aux_dev
IGT-Version: 2.3-NO-GIT (x86_64) (Linux: 6.17.0-19-generic x86_64)
Test requirement not met in function drm_open_driver, file ../lib/drmtest.c:754:
Test requirement: !(fd<0)
No known gpu found for chipset flags 0x4294965755 (any)
Last errno: 2, No such file or directory
SKIP (0.006s)

ls /dev/dri
by-path  card1  renderD128

The real problem here is lack of permissions as there was a card
but program could not open it. Break looking for a card as soon
as an error is different from ENOENT. It will create a proper
error report which will print:

Last errno: 13, Permission denied

Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Cc: Karthik B S <karthik.b.s@intel.com>
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
 lib/drmtest.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/drmtest.c b/lib/drmtest.c
index 4a788ea7a..66982f653 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -443,6 +443,11 @@ static int __search_and_open(const char *base, int offset, unsigned int chipset,
 		fd = __drm_open_device(name, chipset);
 		if (fd != -1)
 			return fd;
+
+		if (errno == ENOENT)
+			continue;
+
+		break;
 	}
 
 	return -1;
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2026-04-28 12:38 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-21 14:59 [PATCH i-g-t v2] lib/drmtest: Create proper error report when open driver fails Kamil Konieczny
2026-04-21 15:42 ` Zbigniew Kempczyński
2026-04-22 16:58   ` Kamil Konieczny
2026-04-22  0:07 ` ✓ i915.CI.BAT: success for lib/drmtest: Create proper error report when open driver fails (rev2) Patchwork
2026-04-22  1:32 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-22  6:18 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-04-22  7:44 ` [PATCH i-g-t v2] lib/drmtest: Create proper error report when open driver fails Jani Nikula
2026-04-22 16:41   ` Zbigniew Kempczyński
2026-04-28 12:38     ` Kamil Konieczny
2026-04-28  9:04   ` Kamil Konieczny
2026-04-22  9:02 ` ✗ i915.CI.Full: failure for lib/drmtest: Create proper error report when open driver fails (rev2) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox