Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Shekhar Chauhan <shekhar.chauhan@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: shekhar.chauhan@intel.com, ashutosh.dixit@intel.com,
	gustavo.sousa@intel.com
Subject: [PATCH v4 2/2] tests/intel/xe_oa: Wa_14026633728
Date: Tue,  5 May 2026 11:17:41 +0530	[thread overview]
Message-ID: <20260505054741.486361-3-shekhar.chauhan@intel.com> (raw)
In-Reply-To: <20260505054741.486361-1-shekhar.chauhan@intel.com>

For MERTOA in CRI, oa buffer can be in device memory. Because of slower
device mem access, OA exponent values lower than 8 can result in buffer
overflows. Bump the OA exponent value.

Signed-off-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
---
 tests/intel/xe_oa.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
index 988c46df6..c7e756426 100644
--- a/tests/intel/xe_oa.c
+++ b/tests/intel/xe_oa.c
@@ -24,6 +24,7 @@
 #include "igt_device.h"
 #include "igt_syncobj.h"
 #include "igt_sysfs.h"
+#include "intel_wa.h"
 #include "xe/xe_ioctl.h"
 #include "xe/xe_query.h"
 #include "xe/xe_oa.h"
@@ -2643,8 +2644,15 @@ test_buffer_fill(const struct drm_xe_oa_unit *oau)
 static void
 test_non_zero_reason(const struct drm_xe_oa_unit *oau, size_t oa_buffer_size)
 {
-	/* ~20 micro second period */
-	int oa_exponent = max_oa_exponent_for_period_lte(20000);
+	/*
+	 * Wa_14026633728: For MERTOA in CRI, oa buffer can be in device memory.
+	 * Because of slower device mem access, OA exponent values lower than 8 can
+	 * result in buffer overflows.
+	 * By default, use ~20 micro second period.
+	 */
+	int oa_exponent = max(max_oa_exponent_for_period_lte(20000),
+			      (oau->oa_unit_type == DRM_XE_OA_UNIT_TYPE_MERT &&
+			       igt_has_intel_wa(drm_fd, "14026633728") > 0) ? 8 : 0);
 	struct intel_xe_perf_metric_set *test_set = oa_unit_metric_set(oau);
 	uint64_t fmt = test_set->perf_oa_format;
 	size_t report_size = get_oa_format(fmt).size;
-- 
2.53.0


  parent reply	other threads:[~2026-05-05  5:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-05  5:47 [PATCH v4 0/2] Wa_14026633728 Shekhar Chauhan
2026-05-05  5:47 ` [PATCH v4 1/2] lib/intel_wa: Add workaround check for a wa within debugfs file Shekhar Chauhan
2026-05-05 13:34   ` Gustavo Sousa
2026-05-05 14:26     ` Jani Nikula
2026-05-05 14:50       ` Gustavo Sousa
2026-05-05 14:53         ` Jani Nikula
2026-05-05  5:47 ` Shekhar Chauhan [this message]
2026-05-05 16:42   ` [PATCH v4 2/2] tests/intel/xe_oa: Wa_14026633728 Dixit, Ashutosh
2026-05-05  6:59 ` ✓ i915.CI.BAT: success for Wa_14026633728 Patchwork
2026-05-05  7:25 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-05 11:50 ` ✓ i915.CI.Full: " Patchwork
2026-05-05 14:43 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260505054741.486361-3-shekhar.chauhan@intel.com \
    --to=shekhar.chauhan@intel.com \
    --cc=ashutosh.dixit@intel.com \
    --cc=gustavo.sousa@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox