Re: [PATCH v4 1/2] lib/intel_wa: Add workaround check for a wa within debugfs file

[Jani Nikula <jani.nikula@intel.com>]

On Tue, 05 May 2026, Gustavo Sousa <gustavo.sousa@intel.com> wrote:
> Jani Nikula <jani.nikula@intel.com> writes:
>
>> On Tue, 05 May 2026, Gustavo Sousa <gustavo.sousa@intel.com> wrote:
>>> I think there is room for improvement on how those functions are
>>> implemented: the use of strstr() is not very robust, since it can return
>>> partial matches; and this function is currently xe-specific (i.e. can't
>>> be used for i915), so we need some assert to make sure that it is being
>>> called only for xe.  However, those are unrelated to this patch and
>>> could be fixed as a follow-up change.
>>
>> There are already lib/i915 and lib/xe directories. lib/i915 and lib/
>> have a number of things that are specific to Intel (either i915 or
>> xe). lib/ has a number of things that are specific to either i915 or xe,
>> but not both.
>>
>> There's a lot of room for moving things about to improve clarity here.
>
> Yeah... Should we reorganize stuff into 3 separate directories then?
>
>   - lib/intel for things common to both drivers;
>   - lib/i915 for things specific to i915;
>   - lib/xe for things specific to xe.

That's what I thought I was suggesting, but I realize now I didn't
really write that. ;D

BR,
Jani.

>
> --
> Gustavo Sousa
>
>>
>> BRm,
>> Jani.
>>
>> -- 
>> Jani Nikula, Intel

-- 
Jani Nikula, Intel