Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sowmiya S <sowmiya.s@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: swati2.sharma@intel.com, chaitanya.kumar.borah@intel.com,
	Sowmiya S <sowmiya.s@intel.com>
Subject: [PATCH i-g-t v2 1/3] tests/intel/kms_pipe_stress: fix inverted condition skipping plane setup
Date: Tue,  2 Jun 2026 21:54:13 +0530	[thread overview]
Message-ID: <20260602162422.3360253-2-sowmiya.s@intel.com> (raw)
In-Reply-To: <20260602162422.3360253-1-sowmiya.s@intel.com>

The condition after commit_mode() was "if (!ret) return ret;"
which returned immediately on success, skipping the entire plane
and cursor setup loop. Fix to "if (ret)" so the loop runs on
success and returns only on failure.

Signed-off-by: Sowmiya S <sowmiya.s@intel.com>
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/intel/kms_pipe_stress.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/intel/kms_pipe_stress.c b/tests/intel/kms_pipe_stress.c
index 36e3842c6..8724a674c 100644
--- a/tests/intel/kms_pipe_stress.c
+++ b/tests/intel/kms_pipe_stress.c
@@ -411,7 +411,7 @@ static int crtc_stress(struct data *data, igt_output_t *output,
 		ret = commit_mode(data, output,
 				  crtc, mode);
 
-		if (!ret)
+		if (ret)
 			return ret;
 
 		data->last_mode[crtc->pipe] = mode;
-- 
2.43.0


  reply	other threads:[~2026-06-02 16:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02 16:24 [PATCH i-g-t v2 0/3] tests/intel/kms_pipe_stress: fix plane setup and cursor handling Sowmiya S
2026-06-02 16:24 ` Sowmiya S [this message]
2026-06-02 16:24 ` [PATCH i-g-t v2 2/3] tests/intel/kms_pipe_stress: fix plane source crop and separate cursor loop Sowmiya S
2026-06-29 19:28   ` Juha-Pekka Heikkilä
2026-06-02 16:24 ` [PATCH i-g-t v2 3/3] tests/intel/kms_pipe_stress: use ARGB8888/LINEAR for cursor framebuffer Sowmiya S
2026-06-04  7:22   ` Borah, Chaitanya Kumar
2026-06-03  6:10 ` ✓ Xe.CI.BAT: success for tests/intel/kms_pipe_stress: fix plane setup and cursor handling (rev2) Patchwork
2026-06-03  6:23 ` ✓ i915.CI.BAT: " Patchwork
2026-06-03 17:46 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-06-04  2:29 ` ✗ i915.CI.Full: " Patchwork
2026-06-09 15:51 ` ✓ i915.CI.Full: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260602162422.3360253-2-sowmiya.s@intel.com \
    --to=sowmiya.s@intel.com \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox