Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>
To: Sowmiya S <sowmiya.s@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: <swati2.sharma@intel.com>
Subject: Re: [PATCH i-g-t v2 3/3] tests/intel/kms_pipe_stress: use ARGB8888/LINEAR for cursor framebuffer
Date: Thu, 4 Jun 2026 12:52:04 +0530	[thread overview]
Message-ID: <760d09d4-34ae-4e27-89e6-021f3bf1df14@intel.com> (raw)
In-Reply-To: <20260602162422.3360253-4-sowmiya.s@intel.com>



On 6/2/2026 9:54 PM, Sowmiya S wrote:
> Cursor planes on Intel hardware accept only

nit: s/accept/accepts

> DRM_FORMAT_MOD_LINEAR, regardless of the overlay
> format and modifier used by the test variant. Using

and DRM_FORMAT_ARGB8888, unlike the formats and modifier
used for primary and overlay planes in the test.

Other than that LGTM.

Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>


> data->modifier (e.g. 4-tiled) caused -EINVAL on the
> cursor commit.
> Bspec: 69833
> 
> v2: Add bspec reference in commit message (Swati)
> 
> Signed-off-by: Sowmiya S <sowmiya.s@intel.com>
> Reviewed-by: Swati Sharma <swati2.sharma@intel.com>
> ---
>   tests/intel/kms_pipe_stress.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/intel/kms_pipe_stress.c b/tests/intel/kms_pipe_stress.c
> index a84433b9d..5362fe9f3 100644
> --- a/tests/intel/kms_pipe_stress.c
> +++ b/tests/intel/kms_pipe_stress.c
> @@ -736,8 +736,8 @@ static void create_framebuffers(struct data *data)
>   		if (!data->cursor_fb[i].fb_id) {
>   			igt_create_color_fb(data->drm_fd,
>   					    cursor_width, cursor_height,
> -					    data->format,
> -					    data->modifier,
> +					    DRM_FORMAT_ARGB8888,
> +					    DRM_FORMAT_MOD_LINEAR,
>   					    1.0, 0.0, 0.0,
>   					    &data->cursor_fb[i]);
>   		}


  reply	other threads:[~2026-06-04  7:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02 16:24 [PATCH i-g-t v2 0/3] tests/intel/kms_pipe_stress: fix plane setup and cursor handling Sowmiya S
2026-06-02 16:24 ` [PATCH i-g-t v2 1/3] tests/intel/kms_pipe_stress: fix inverted condition skipping plane setup Sowmiya S
2026-06-02 16:24 ` [PATCH i-g-t v2 2/3] tests/intel/kms_pipe_stress: fix plane source crop and separate cursor loop Sowmiya S
2026-06-29 19:28   ` Juha-Pekka Heikkilä
2026-06-02 16:24 ` [PATCH i-g-t v2 3/3] tests/intel/kms_pipe_stress: use ARGB8888/LINEAR for cursor framebuffer Sowmiya S
2026-06-04  7:22   ` Borah, Chaitanya Kumar [this message]
2026-06-03  6:10 ` ✓ Xe.CI.BAT: success for tests/intel/kms_pipe_stress: fix plane setup and cursor handling (rev2) Patchwork
2026-06-03  6:23 ` ✓ i915.CI.BAT: " Patchwork
2026-06-03 17:46 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-06-04  2:29 ` ✗ i915.CI.Full: " Patchwork
2026-06-09 15:51 ` ✓ i915.CI.Full: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=760d09d4-34ae-4e27-89e6-021f3bf1df14@intel.com \
    --to=chaitanya.kumar.borah@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=sowmiya.s@intel.com \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox