Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] tests/xe_debugfs: Add debugfs entry read/write validation in root-dir
@ 2026-06-11  9:43 Sobin Thomas
  2026-06-11 11:43 ` ✓ Xe.CI.BAT: success for tests/xe_debugfs: Add debugfs entry read/write validation in root-dir (rev2) Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Sobin Thomas @ 2026-06-11  9:43 UTC (permalink / raw)
  To: igt-dev, piotr.piorkowski; +Cc: kamil.konieczny, nishit.sharma, Sobin Thomas

Extend the root-dir subtest to validate additional Xe debugfs entries:

- dgfx_pkg_residencies: Validate counter reads (optional, non-empty)
- dgfx_pcie_link_residencies: Validate PCIE LINK string content (optional)
- sriov_info: Validate entry is non-empty (optional)
- workarounds: Validate entry is non-empty (optional)
- atomic_svm_timeslice_ms: Validate integer read/write (optional)
- poor_man_system_atomic_support: Validate boolean read/write (optional)
- disable_late_binding: Validate boolean read/write (optional)

Signed-off-by: Sobin Thomas <sobin.thomas@intel.com>
---
 tests/intel/xe_debugfs.c | 198 +++++++++++++++++++++++++++++++++++----
 1 file changed, 180 insertions(+), 18 deletions(-)

diff --git a/tests/intel/xe_debugfs.c b/tests/intel/xe_debugfs.c
index 587e3e785..5e59424fe 100644
--- a/tests/intel/xe_debugfs.c
+++ b/tests/intel/xe_debugfs.c
@@ -39,11 +39,24 @@ IGT_TEST_DESCRIPTION("Validate Xe debugfs devnodes and their contents");
 	__m && ((__i) = __builtin_ctz(__m), 1);	\
 	__m &= __m - 1)
 
+/* Validation types for debugfs read tests */
+enum debugfs_validate_type {
+	VALIDATE_NONE,		/* Just check file exists */
+	VALIDATE_NON_EMPTY,	/* Just check buffer is not empty */
+	VALIDATE_CONTAINS_STR,	/* Check buffer contains expected string */
+	VALIDATE_INT_GE_ZERO,	/* Parse as integer, verify >= 0 */
+	VALIDATE_BOOL,		/* Check bool value (0 or 1) */
+};
+
 struct check_entry {
 	const char *name_fmt;
 	int mode;
-	bool (*condition)(struct xe_device *xe_dev);
+	bool optional;
+	bool (*condition)(struct xe_device *xe_dev, void *params);
+	void *cond_params;
 	unsigned int (*iter_mask)(struct xe_device *xe_dev);
+	enum debugfs_validate_type validate;
+	const char *expected_str;
 };
 
 static unsigned int gt_iter_mask(struct xe_device *xe_dev)
@@ -56,8 +69,13 @@ static unsigned int tile_iter_mask(struct xe_device *xe_dev)
 	return xe_dev->tile_mask;
 }
 
-static bool has_vram(struct xe_device *xe_dev)
+static bool has_vram_region(struct xe_device *xe_dev, void *params)
 {
+	uint8_t tile = (uint8_t)(uintptr_t)params;
+
+	if (!(xe_dev->tile_mask & (1u << tile)))
+		return false;
+
 	return xe_dev->has_vram;
 }
 
@@ -131,16 +149,140 @@ static bool find_not_tested_files(int dir_fd, struct igt_list_head *hit_entries)
 	return found_not_tested;
 }
 
-static bool file_in_dir_exists(int dirfd, const char *file_name, int mode)
+/* Validate that debugfs buffer is non-empty or contains expected string */
+static bool validate_string(int dirfd, const char *file_name, const char *expected_str)
+{
+	char buf[4096];
+	int ret = 0;
+
+	ret = igt_sysfs_read(dirfd, file_name, buf, sizeof(buf) - 1);
+	if (ret < 0)
+		return false;
+	buf[ret] = '\0';
+
+	/* Check for empty buffer */
+	if (strlen(buf) == 0) {
+		igt_warn("Empty output from %s\n", file_name);
+		return false;
+	}
+
+	/* If expecting specific string, verify it's present */
+	if (expected_str && !strstr(buf, expected_str)) {
+		igt_warn("Expected '%s' not found in %s\n", expected_str, file_name);
+		return false;
+	}
+
+	if (expected_str)
+		igt_debug("Successfully read %s: found '%s'\n", file_name, expected_str);
+	else
+		igt_debug("Successfully read %s: %zd bytes\n%s\n", file_name, strlen(buf), buf);
+
+	return true;
+}
+
+static const char *mode_to_str(int mode)
+{
+	switch (mode & O_ACCMODE) {
+	case O_RDONLY: return "RO";
+	case O_WRONLY: return "WO";
+	case O_RDWR:   return "RW";
+	default:       return "UNKNOWN";
+	}
+}
+
+static bool validate_bool_file(int dirfd, const char *file_name, int mode)
+{
+	int orig_val = 0, read_val = 0, test_val = 0;
+
+	if (igt_sysfs_scanf(dirfd, file_name, "%d", &orig_val) != 1 ||
+	    (orig_val != 0 && orig_val != 1))
+		return false;
+
+	if (mode == O_RDWR) {
+		test_val = (orig_val == 0) ? 1 : 0;
+
+		if (igt_sysfs_printf(dirfd, file_name, "%d", test_val) < 0)
+			return false;
+
+		if (igt_sysfs_scanf(dirfd, file_name, "%d", &read_val) != 1 || read_val != test_val)
+			return false;
+
+		/* Restore original value */
+		if (igt_sysfs_printf(dirfd, file_name, "%d", orig_val) < 0) {
+			igt_warn("Failed to restore original value for %s\n", file_name);
+			return false;
+		}
+	}
+
+	igt_info("Successfully validated %s bool %s\n", mode_to_str(mode), file_name);
+	return true;
+}
+
+static bool validate_int_file(int dirfd, const char *file_name, int mode)
+{
+	long orig_val = 0, new_val = 0, read_val = 0;
+
+	if (igt_sysfs_scanf(dirfd, file_name, "%ld", &orig_val) != 1)
+		return false;
+
+	if (orig_val < 0)
+		return false;
+
+	if (mode == O_RDWR) {
+		new_val = orig_val + 1;
+		if (igt_sysfs_printf(dirfd, file_name, "%ld", new_val) < 0)
+			return false;
+		if (igt_sysfs_scanf(dirfd, file_name, "%ld", &read_val) != 1)
+			return false;
+		if (read_val != new_val)
+			return false;
+		/* Restore original value */
+		if (igt_sysfs_printf(dirfd, file_name, "%ld", orig_val) < 0) {
+			igt_warn("Failed to restore original value for %s\n", file_name);
+			return false;
+		}
+
+		igt_debug("Successfully validated %s int %s: %ld -> %ld -> %ld\n",
+			  mode_to_str(mode), file_name, orig_val, new_val, orig_val);
+	} else {
+		igt_debug("Successfully validated %s int %s: %ld\n",
+			  mode_to_str(mode), file_name, orig_val);
+	}
+	return true;
+}
+
+static bool validate_debugfs_file(int dirfd, const char *file_name, int mode,
+				  enum debugfs_validate_type validate, const char *expected_str)
 {
-	int fd = openat(dirfd, file_name, mode);
+	bool result = true;
 
-	if (fd >= 0) {
-		close(fd);
+	if (faccessat(dirfd, file_name, F_OK, 0) < 0) {
+		igt_debug("%s does not exist\n", file_name);
+		return false;
+	}
+	if (validate == VALIDATE_NONE)
 		return true;
+
+	switch (validate) {
+	case VALIDATE_NON_EMPTY:
+		result = validate_string(dirfd, file_name, NULL);
+		break;
+	case VALIDATE_CONTAINS_STR:
+		result = validate_string(dirfd, file_name, expected_str);
+		break;
+	case VALIDATE_INT_GE_ZERO:
+		result = validate_int_file(dirfd, file_name, mode);
+		break;
+	case VALIDATE_BOOL:
+		result = validate_bool_file(dirfd, file_name, mode);
+		break;
+	default:
+		igt_warn("Unknown validate type %d for %s\n", validate, file_name);
+		result = false;
+		break;
 	}
 
-	return false;
+	return result;
 }
 
 /*
@@ -160,7 +302,7 @@ static int debugfs_validate_entries(struct xe_device *xe_dev, int dir_fd,
 		unsigned int mask;
 		unsigned int j;
 
-		if (check->condition && !check->condition(xe_dev))
+		if (check->condition && !check->condition(xe_dev, check->cond_params))
 			continue;
 
 		if (!check->iter_mask)
@@ -209,10 +351,18 @@ static int debugfs_validate_entries(struct xe_device *xe_dev, int dir_fd,
 #pragma GCC diagnostic pop
 			}
 
-			if (!file_in_dir_exists(dir_fd, entry->name, check->mode)) {
-				igt_warn("Missing debugfs file: %s\n", entry->name);
-				missing_count++;
+			if (!validate_debugfs_file(dir_fd, entry->name, check->mode,
+						   check->validate, check->expected_str)) {
+				if (check->optional) {
+					igt_info("Optional entry %s not found/invalid (skipped)\n",
+						 entry->name);
+				} else {
+					igt_warn("Missing or invalid debugfs file: %s\n",
+						 entry->name);
+					missing_count++;
+				}
 			}
+
 		}
 	}
 
@@ -239,14 +389,25 @@ out:
 static void test_root_dir(struct xe_device *xe_dev)
 {
 	const struct check_entry expected_files[] = {
-		{ "clients", O_RDONLY },
+		{ "clients", O_RDONLY, .validate = VALIDATE_NON_EMPTY },
+		{ "disable_late_binding", O_RDWR, .optional = true, .validate = VALIDATE_BOOL },
 		{ "forcewake_all", O_WRONLY },
 		{ "gem_names", O_RDONLY },
-		{ "gt%u", O_RDONLY, NULL, gt_iter_mask }, /* gt0, gt1, ... */
-		{ "gtt_mm", O_RDONLY },
-		{ "info", O_RDONLY },
-		{ "name", O_RDONLY },
-		{ "tile%u", O_RDONLY, NULL, tile_iter_mask }, /* tile0, tile1, ... */
+		{ "gt%u", O_RDONLY, .iter_mask = gt_iter_mask },
+		{ "gtt_mm", O_RDONLY, },
+		{ "info", O_RDONLY, .validate = VALIDATE_NON_EMPTY },
+		{ "name", O_RDONLY, .validate = VALIDATE_NON_EMPTY },
+		{ "poor_man_system_atomic_support", O_RDWR, .optional = true,
+		  .validate = VALIDATE_BOOL },
+		{ "dgfx_pkg_residencies", O_RDONLY, .optional = true,
+		  .validate = VALIDATE_NON_EMPTY },
+		{ "dgfx_pcie_link_residencies", O_RDONLY, .optional = true,
+		  .validate = VALIDATE_CONTAINS_STR, .expected_str = "PCIE LINK" },
+		{ "sriov_info", O_RDONLY, .optional = true, .validate = VALIDATE_NON_EMPTY },
+		{ "workarounds", O_RDONLY, .optional = true, .validate = VALIDATE_NON_EMPTY },
+		{ "atomic_svm_timeslice_ms", O_RDWR, .optional = true,
+		  .validate = VALIDATE_INT_GE_ZERO },
+		{ "tile%u", O_RDONLY, .iter_mask = tile_iter_mask },
 	};
 	int debugfs_fd = igt_debugfs_dir(xe_dev->fd);
 	int missing_count;
@@ -276,7 +437,8 @@ static void test_tile_dir(struct xe_device *xe_dev, uint8_t tile)
 	const struct check_entry expected_files[] = {
 		{ "ggtt", O_RDONLY },
 		{ "sa_info", O_RDONLY },
-		{ "vram_mm", O_RDONLY, has_vram },
+		{ "vram_mm", O_RDONLY, .condition = has_vram_region,
+		  .cond_params = (void *)(uintptr_t)tile },
 	};
 	int debugfs_fd = igt_debugfs_tile_dir(xe_dev->fd, tile);
 	int missing_count;
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2026-06-15  9:20 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-11  9:43 [PATCH i-g-t] tests/xe_debugfs: Add debugfs entry read/write validation in root-dir Sobin Thomas
2026-06-11 11:43 ` ✓ Xe.CI.BAT: success for tests/xe_debugfs: Add debugfs entry read/write validation in root-dir (rev2) Patchwork
2026-06-11 11:51 ` ✓ i915.CI.BAT: " Patchwork
2026-06-11 13:14 ` [PATCH i-g-t] tests/xe_debugfs: Add debugfs entry read/write validation in root-dir Kamil Konieczny
2026-06-15  4:17   ` Thomas, Sobin
2026-06-15  9:20     ` Kamil Konieczny
2026-06-11 22:43 ` ✓ Xe.CI.FULL: success for tests/xe_debugfs: Add debugfs entry read/write validation in root-dir (rev2) Patchwork
2026-06-12  9:16 ` ✗ i915.CI.Full: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox