Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: adam.miszczak@linux.intel.com, jakub1.kolakowski@intel.com,
	lukasz.laguna@intel.com,
	Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
Subject: [PATCH v2 i-g-t 5/6] tests/xe: Arm SR-IOV exit cleanup with callback
Date: Mon, 15 Jun 2026 12:32:19 +0200	[thread overview]
Message-ID: <20260615103220.281656-6-marcin.bernatowicz@linux.intel.com> (raw)
In-Reply-To: <20260615103220.281656-1-marcin.bernatowicz@linux.intel.com>

Install SR-IOV exit handler in xe_pmu, xe_sriov_admin, and
xe_sriov_scheduling.

Use xe_sriov_admin_exit_cleanup_restore_defaults() as exit callback to
restore Xe SR-IOV admin scheduling defaults. Clear handler after explicit
teardown succeeds.

Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
Cc: Adam Miszczak <adam.miszczak@linux.intel.com>
Cc: Jakub Kolakowski <jakub1.kolakowski@intel.com>
Cc: Lukasz Laguna <lukasz.laguna@intel.com>
Reviewed-by: Lukasz Laguna <lukasz.laguna@intel.com>
---
 tests/intel/xe_pmu.c              | 4 ++++
 tests/intel/xe_sriov_admin.c      | 4 ++++
 tests/intel/xe_sriov_scheduling.c | 4 ++++
 3 files changed, 12 insertions(+)

diff --git a/tests/intel/xe_pmu.c b/tests/intel/xe_pmu.c
index fb4b871e7..bb6d21b9f 100644
--- a/tests/intel/xe_pmu.c
+++ b/tests/intel/xe_pmu.c
@@ -994,6 +994,9 @@ static unsigned int enable_and_provision_vfs(int fd)
 	igt_require(xe_sriov_admin_is_present(fd));
 	igt_require(igt_sriov_get_enabled_vfs(fd) == 0);
 	xe_sriov_require_default_scheduling_attributes(fd);
+	igt_sriov_install_exit_handler(fd,
+				       xe_sriov_admin_exit_cleanup_restore_defaults,
+				       NULL);
 	autoprobe = igt_sriov_is_driver_autoprobe_enabled(fd);
 
 	/* Enable VF's */
@@ -1035,6 +1038,7 @@ static void unprovision_and_disable_vfs(int fd)
 
 	igt_abort_on_f(autoprobe != igt_sriov_is_driver_autoprobe_enabled(fd),
 		       "Failed to restore sriov_drivers_autoprobe value\n");
+	igt_sriov_clear_exit_handler();
 }
 
 static void stash_gt_freq(int fd, uint32_t **stash_min, uint32_t **stash_max)
diff --git a/tests/intel/xe_sriov_admin.c b/tests/intel/xe_sriov_admin.c
index 5c7f5d621..8b400a01f 100644
--- a/tests/intel/xe_sriov_admin.c
+++ b/tests/intel/xe_sriov_admin.c
@@ -346,6 +346,9 @@ int igt_main()
 		igt_require(igt_sriov_is_pf(pf_fd));
 		igt_require(igt_sriov_get_enabled_vfs(pf_fd) == 0);
 		igt_require(xe_sriov_admin_is_present(pf_fd));
+		igt_sriov_install_exit_handler(pf_fd,
+					       xe_sriov_admin_exit_cleanup_restore_defaults,
+					       NULL);
 		total_vfs = igt_sriov_get_total_vfs(pf_fd);
 	}
 
@@ -429,6 +432,7 @@ int igt_main()
 		igt_abort_on_f(igt_sriov_get_enabled_vfs(pf_fd) > 0,
 			       "Failed to disable VF(s)");
 		igt_abort_on_f(ret, "Failed to restore default profile values\n");
+		igt_sriov_clear_exit_handler();
 		drm_close_driver(pf_fd);
 	}
 }
diff --git a/tests/intel/xe_sriov_scheduling.c b/tests/intel/xe_sriov_scheduling.c
index de697dbf5..47cc5d9b0 100644
--- a/tests/intel/xe_sriov_scheduling.c
+++ b/tests/intel/xe_sriov_scheduling.c
@@ -1469,6 +1469,9 @@ int igt_main_args("", long_opts, help_str, subm_opts_handler, NULL)
 		igt_require(igt_sriov_is_pf(pf_fd));
 		igt_require(igt_sriov_get_enabled_vfs(pf_fd) == 0);
 		igt_require(xe_sriov_admin_is_present(pf_fd));
+		igt_sriov_install_exit_handler(pf_fd,
+					       xe_sriov_admin_exit_cleanup_restore_defaults,
+					       NULL);
 		autoprobe = igt_sriov_is_driver_autoprobe_enabled(pf_fd);
 		xe_sriov_require_default_scheduling_attributes(pf_fd);
 		xe_perf_device(pf_fd, perf_device, sizeof(perf_device));
@@ -1635,6 +1638,7 @@ int igt_main_args("", long_opts, help_str, subm_opts_handler, NULL)
 			       "Failed to restore sriov_drivers_autoprobe value\n");
 		igt_abort_on_f(ret,
 			       "Failed to restore scheduling params\n");
+		igt_sriov_clear_exit_handler();
 		drm_close_driver(pf_fd);
 	}
 }
-- 
2.43.0


  parent reply	other threads:[~2026-06-15 10:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-15 10:32 [PATCH v2 i-g-t 0/6] Add SR-IOV exit-handler-based cleanup Marcin Bernatowicz
2026-06-15 10:32 ` [PATCH v2 i-g-t 1/6] lib/igt_device_sriov: Add generic SR-IOV exit cleanup helper Marcin Bernatowicz
2026-06-15 10:32 ` [PATCH v2 i-g-t 2/6] lib/xe/xe_sriov_admin: Add SR-IOV admin exit cleanup restore helper Marcin Bernatowicz
2026-06-15 10:32 ` [PATCH v2 i-g-t 3/6] tests/sriov_basic: Arm SR-IOV exit cleanup Marcin Bernatowicz
2026-06-15 10:32 ` [PATCH v2 i-g-t 4/6] tests/xe: " Marcin Bernatowicz
2026-06-15 10:32 ` Marcin Bernatowicz [this message]
2026-06-15 10:32 ` [PATCH v2 i-g-t 6/6] tests/intel/xe_sriov_flr: " Marcin Bernatowicz
2026-06-15 17:36 ` ✓ i915.CI.BAT: success for Add SR-IOV exit-handler-based cleanup (rev2) Patchwork
2026-06-15 17:36 ` ✓ Xe.CI.BAT: " Patchwork
2026-06-15 18:44 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-06-16  1:02 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260615103220.281656-6-marcin.bernatowicz@linux.intel.com \
    --to=marcin.bernatowicz@linux.intel.com \
    --cc=adam.miszczak@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jakub1.kolakowski@intel.com \
    --cc=lukasz.laguna@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox