From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Swati Sharma <swati2.sharma@intel.com>,
Nemesa Garg <nemesa.garg@intel.com>
Subject: [PATCH i-g-t 1/2] tests/intel/kms_sharpness_filter: Skip joiner modes
Date: Thu, 9 Jul 2026 00:43:05 +0530 [thread overview]
Message-ID: <20260708191306.2995928-2-swati2.sharma@intel.com> (raw)
In-Reply-To: <20260708191306.2995928-1-swati2.sharma@intel.com>
get_modes_for_filter_taps() could select modes requiring
bigjoiner (e.g. 7680x2160@60) for tap filter testing, but
joiner + CASF is currently unsupported. Filter out such modes
using igt_bigjoiner_possible() against the platform's max
dotclock.
Assisted-by: GitHub Copilot:Claude Opus 4.6
Reviewed-by: Nemesa Garg <nemesa.garg@intel.com>
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
tests/intel/kms_sharpness_filter.c | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/tests/intel/kms_sharpness_filter.c b/tests/intel/kms_sharpness_filter.c
index ff7b4540c..171a3e99c 100644
--- a/tests/intel/kms_sharpness_filter.c
+++ b/tests/intel/kms_sharpness_filter.c
@@ -358,9 +358,11 @@ static void cleanup(data_t *data)
cleanup_fbs(data);
}
-static void get_modes_for_filter_taps(igt_output_t *output, drmModeModeInfo *mode[3])
+static void get_modes_for_filter_taps(int drm_fd, igt_output_t *output,
+ drmModeModeInfo *mode[3])
{
drmModeConnector *connector = output->config.connector;
+ int max_dotclock = igt_get_max_dotclock(drm_fd);
int total_pixels = 0;
/*
@@ -368,8 +370,14 @@ static void get_modes_for_filter_taps(igt_output_t *output, drmModeModeInfo *mod
* TAP 5: (mode->hdisplay > 1920 && mode->hdisplay < 3840) &&
* (mode->vdisplay > 1080 && mode->vdisplay < 2160)
* TAP 7: mode->hdisplay >= 3840 && mode->vdisplay >= 2160
+ *
+ * Skip modes requiring joiner since joiner + CASF is unsupported.
*/
for (int i = 0; i < connector->count_modes; i++) {
+ if (igt_bigjoiner_possible(drm_fd, &connector->modes[i],
+ max_dotclock))
+ continue;
+
total_pixels = connector->modes[i].hdisplay * connector->modes[i].vdisplay;
if (total_pixels <= MAX_PIXELS_FOR_3_TAP_FILTER)
@@ -670,11 +678,15 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
if (type == TEST_FILTER_TAP) {
drmModeModeInfo *modes[3] = { NULL, NULL, NULL };
- get_modes_for_filter_taps(output, modes);
+ get_modes_for_filter_taps(data->drm_fd, output, modes);
for (int i = 0; i < 3; i++) {
data->filter_tap = filter_tap_list[i];
- if (!modes[i])
+ if (!modes[i]) {
+ igt_info("No valid non-joiner mode for tap-%d on %s\n",
+ data->filter_tap,
+ igt_output_name(data->output));
continue;
+ }
data->mode = modes[i];
igt_info("Mode %dx%d@%d on output %s\n",
data->mode->hdisplay,
--
2.25.1
next prev parent reply other threads:[~2026-07-08 19:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 19:13 [PATCH i-g-t 0/2] tests/intel/kms_sharpness_filter: Fix tap filter test failures Swati Sharma
2026-07-08 19:13 ` Swati Sharma [this message]
2026-07-08 19:13 ` [PATCH i-g-t 2/2] tests/intel/kms_sharpness_filter: Restore CRTC binding Swati Sharma
2026-07-08 20:01 ` ✓ Xe.CI.BAT: success for tests/intel/kms_sharpness_filter: Fix tap filter test failures (rev2) Patchwork
2026-07-08 20:19 ` ✓ i915.CI.BAT: " Patchwork
2026-07-09 19:20 ` ✓ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260708191306.2995928-2-swati2.sharma@intel.com \
--to=swati2.sharma@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=nemesa.garg@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox