From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Swati Sharma <swati2.sharma@intel.com>,
Nemesa Garg <nemesa.garg@intel.com>
Subject: [PATCH i-g-t 2/2] tests/intel/kms_sharpness_filter: Restore CRTC binding
Date: Thu, 9 Jul 2026 00:43:06 +0530 [thread overview]
Message-ID: <20260708191306.2995928-3-swati2.sharma@intel.com> (raw)
In-Reply-To: <20260708191306.2995928-1-swati2.sharma@intel.com>
After each tap iteration, cleanup() calls igt_display_reset()
which clears the output's pending_crtc binding. Subsequent tap
iterations (e.g. tap-5 after tap-3) then fail with -EIO during
pipe CRC collection because the output has no CRTC assigned.
Fix by conditionally restoring the CRTC binding via
igt_output_set_crtc() when pending_crtc is NULL.
Assisted-by: GitHub Copilot:Claude Opus 4.6
Reviewed-by: Nemesa Garg <nemesa.garg@intel.com>
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
tests/intel/kms_sharpness_filter.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/intel/kms_sharpness_filter.c b/tests/intel/kms_sharpness_filter.c
index 171a3e99c..8c6073669 100644
--- a/tests/intel/kms_sharpness_filter.c
+++ b/tests/intel/kms_sharpness_filter.c
@@ -695,6 +695,9 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
igt_output_name(data->output));
igt_output_override_mode(data->output,
data->mode);
+ if (!data->output->pending_crtc)
+ igt_output_set_crtc(data->output,
+ data->crtc);
snprintf(name, sizeof(name), "-tap-%d",
data->filter_tap);
--
2.25.1
next prev parent reply other threads:[~2026-07-08 19:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 19:13 [PATCH i-g-t 0/2] tests/intel/kms_sharpness_filter: Fix tap filter test failures Swati Sharma
2026-07-08 19:13 ` [PATCH i-g-t 1/2] tests/intel/kms_sharpness_filter: Skip joiner modes Swati Sharma
2026-07-08 19:13 ` Swati Sharma [this message]
2026-07-08 20:01 ` ✓ Xe.CI.BAT: success for tests/intel/kms_sharpness_filter: Fix tap filter test failures (rev2) Patchwork
2026-07-08 20:19 ` ✓ i915.CI.BAT: " Patchwork
2026-07-09 19:20 ` ✓ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260708191306.2995928-3-swati2.sharma@intel.com \
--to=swati2.sharma@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=nemesa.garg@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox