Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Michał Grzelak" <michal.grzelak@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Mohammed Thasleem" <mohammed.thasleem@intel.com>,
	"Michał Grzelak" <michal.grzelak@intel.com>
Subject: [PATCH i-g-t v1 13/16] tests/kms_sharpness_filter: limit #crtcs tested during suspend
Date: Mon, 13 Jul 2026 10:55:12 +0200	[thread overview]
Message-ID: <20260713085515.463575-14-michal.grzelak@intel.com> (raw)
In-Reply-To: <20260713085515.463575-1-michal.grzelak@intel.com>

We are iterating through each crtc while testing suspend. This results
in extended execution time. In turn this leads to hitting CI enforced
timeout.

Limit number of tested crtcs to first and last. Test each crtc when
passing commandline parameter.

v1->v2
- remove unused vars (Jani)

Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
---
 tests/intel/kms_sharpness_filter.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/tests/intel/kms_sharpness_filter.c b/tests/intel/kms_sharpness_filter.c
index adec4a60c5..a8578cf4fc 100644
--- a/tests/intel/kms_sharpness_filter.c
+++ b/tests/intel/kms_sharpness_filter.c
@@ -233,6 +233,7 @@ static const struct subtest_entry {
 typedef struct {
 	int drm_fd;
 	bool limited;
+	bool all_crtcs;
 	bool all_outputs;
 	struct igt_fb fb[4];
 	igt_crtc_t *crtc;
@@ -635,6 +636,10 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
 
 			igt_output_set_crtc(data->output, data->crtc);
 
+			if (type == TEST_FILTER_SUSPEND && !data->all_crtcs && crtc->crtc_index != 0 &&
+						crtc->crtc_index != display->n_crtcs-1)
+					continue;
+
 			/*
 			 * FIXME: Joiner + CASF currently unsupported.
 			 * Remove this check once support is implemented.
@@ -776,6 +781,9 @@ static int opt_handler(int opt, int opt_index, void *_data)
 	case 'l':
 		data->limited = true;
 		break;
+	case 'c':
+		data->all_crtcs = true;
+		break;
 	case 'o':
 		data->all_outputs = true;
 		break;
@@ -788,11 +796,12 @@ static int opt_handler(int opt, int opt_index, void *_data)
 
 static const char help_str[] =
 	"  --limited|-l\t\tLimit execution to 1 valid pipe-output combo\n"
-	"  --all-outputs|-o\t\tExtend suspend tests for all outputs\n";
+	"  --all-outputs|-o\t\tExtend suspend tests for all outputs\n"
+	"  --all-crtcs|-c\t\tExtend suspend tests for all crtcs\n";
 
 data_t data = {};
 
-int igt_main_args("lo", NULL, help_str, opt_handler, &data)
+int igt_main_args("loc", NULL, help_str, opt_handler, &data)
 {
 	igt_fixture() {
 		data.drm_fd = drm_open_driver_master(DRIVER_ANY);
-- 
2.45.2


  parent reply	other threads:[~2026-07-13  9:03 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-13  8:54 [PATCH i-g-t v2 00/16] limiting suspend tests Michał Grzelak
2026-07-13  8:55 ` [PATCH i-g-t v2 01/16] lib/igt_aux: remove typos Michał Grzelak
2026-07-13  8:55 ` [PATCH i-g-t v1 02/16] lib/igt_kms: s/pipe/crtc/ Michał Grzelak
2026-07-13  8:55 ` [PATCH i-g-t v1 03/16] tests/kms_async_flips: split outer test loop into two Michał Grzelak
2026-07-13  8:55 ` [PATCH i-g-t v1 04/16] tests/kms_async_flips: limit #outputs tested during suspend Michał Grzelak
2026-07-13  8:55 ` [PATCH i-g-t v1 05/16] tests/kms_frontbuffer_tracking: remove TEST_MODE_ITER_BEGIN() from `suspend` Michał Grzelak
2026-07-13  8:55 ` [PATCH i-g-t v1 06/16] tests/kms_frontbuffer_tracking: remove TEST_MODE_ITER_BEGIN() from `fliptrack` Michał Grzelak
2026-07-13  8:55 ` [PATCH i-g-t v1 07/16] tests/kms_pipe_crc_basic: limit #crtcs tested during suspend Michał Grzelak
2026-07-13  8:55 ` [PATCH i-g-t v1 08/16] tests/kms_psr: limit #outputs " Michał Grzelak
2026-07-13  8:55 ` [PATCH i-g-t v2 09/16] tests/kms_vblank: split outer test loop into two Michał Grzelak
2026-07-13  8:55 ` [PATCH i-g-t v1 10/16] tests/kms_vblank: limit #outputs tested during suspend Michał Grzelak
2026-07-13  8:55 ` [PATCH i-g-t v1 11/16] tests/kms_sharpness_filter: fix typo Michał Grzelak
2026-07-14 10:05   ` Garg, Nemesa
2026-07-13  8:55 ` [PATCH i-g-t v1 12/16] tests/kms_sharpness_filter: limit #outputs tested during suspend Michał Grzelak
2026-07-14 13:03   ` Garg, Nemesa
2026-07-13  8:55 ` Michał Grzelak [this message]
2026-07-13  8:55 ` [PATCH i-g-t v1 14/16] tests/kms_ccs: split outer test loop into two Michał Grzelak
2026-07-13  8:55 ` [PATCH i-g-t v1 15/16] tests/kms_ccs: limit #outputs tested during suspend Michał Grzelak
2026-07-13  8:55 ` [PATCH i-g-t v1 16/16] tests/kms_ccs: limit #crtcs " Michał Grzelak
2026-07-13 12:04 ` ✓ Xe.CI.BAT: success for limiting suspend tests Patchwork
2026-07-13 12:24 ` ✓ i915.CI.BAT: " Patchwork
2026-07-13 14:39 ` ✓ Xe.CI.FULL: " Patchwork
2026-07-13 16:40 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260713085515.463575-14-michal.grzelak@intel.com \
    --to=michal.grzelak@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=mohammed.thasleem@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox