From: "Michał Grzelak" <michal.grzelak@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Mohammed Thasleem" <mohammed.thasleem@intel.com>,
"Michał Grzelak" <michal.grzelak@intel.com>
Subject: [PATCH i-g-t v1 03/16] tests/kms_async_flips: split outer test loop into two
Date: Mon, 13 Jul 2026 10:55:02 +0200 [thread overview]
Message-ID: <20260713085515.463575-4-michal.grzelak@intel.com> (raw)
In-Reply-To: <20260713085515.463575-1-michal.grzelak@intel.com>
for_each_crtc_with_valid_output() iterates over every crtc with
connected output. Split it into two loops. This is needed to handle
cases per output.
Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
---
tests/kms_async_flips.c | 63 ++++++++++++++++++++++-------------------
1 file changed, 34 insertions(+), 29 deletions(-)
diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
index ef4b28eb52..03348d958d 100644
--- a/tests/kms_async_flips.c
+++ b/tests/kms_async_flips.c
@@ -877,39 +877,44 @@ static void run_test(data_t *data, void (*test)(data_t *))
if (data->atomic_path)
require_atomic_async_cap(data);
- for_each_crtc_with_valid_output(display, crtc, data->output) {
- data->crtc = crtc;
- igt_display_reset(display);
+ for_each_connected_output(display, data->output) {
+ for_each_crtc(&data->display, crtc) {
+ if(!igt_crtc_connector_valid(crtc, data->output))
+ continue;
- igt_output_set_crtc(data->output,
- crtc);
- if (!intel_pipe_output_combo_valid(display))
- continue;
+ data->crtc = crtc;
+ igt_display_reset(display);
- test_init(data);
+ igt_output_set_crtc(data->output,
+ crtc);
+ if (!intel_pipe_output_combo_valid(display))
+ continue;
- if (data->linear_modifier)
- data->modifier = DRM_FORMAT_MOD_LINEAR;
- else
- data->modifier = default_modifier(data);
-
- igt_require(igt_format_mods_has_modifier(&data->plane->format_mods_async,
- data->modifier));
-
- igt_dynamic_f("pipe-%s-%s", igt_crtc_name(crtc),
- data->output->name) {
- /*
- * FIXME: joiner+async flip is busted currently in KMD.
- * Remove this check once the issues are fixed in KMD.
- */
- igt_skip_on_f(is_joiner_mode(data->drm_fd, data->output),
- "Skipping, async flip not supported on joiner mode\n");
- test_init_fbs(data);
- test(data);
+ test_init(data);
+
+ if (data->linear_modifier)
+ data->modifier = DRM_FORMAT_MOD_LINEAR;
+ else
+ data->modifier = default_modifier(data);
+
+ igt_require(igt_format_mods_has_modifier(&data->plane->format_mods_async,
+ data->modifier));
+
+ igt_dynamic_f("pipe-%s-%s", igt_crtc_name(crtc),
+ data->output->name) {
+ /*
+ * FIXME: joiner+async flip is busted currently in KMD.
+ * Remove this check once the issues are fixed in KMD.
+ */
+ igt_skip_on_f(is_joiner_mode(data->drm_fd, data->output),
+ "Skipping, async flip not supported on joiner mode\n");
+ test_init_fbs(data);
+ test(data);
+ }
+ /* Restrict to single pipe in simulation */
+ if (data->single_pipe)
+ break;
}
- /* Restrict to single pipe in simulation */
- if (data->single_pipe)
- break;
}
}
--
2.45.2
next prev parent reply other threads:[~2026-07-13 8:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 8:54 [PATCH i-g-t v2 00/16] limiting suspend tests Michał Grzelak
2026-07-13 8:55 ` [PATCH i-g-t v2 01/16] lib/igt_aux: remove typos Michał Grzelak
2026-07-13 8:55 ` [PATCH i-g-t v1 02/16] lib/igt_kms: s/pipe/crtc/ Michał Grzelak
2026-07-13 8:55 ` Michał Grzelak [this message]
2026-07-13 8:55 ` [PATCH i-g-t v1 04/16] tests/kms_async_flips: limit #outputs tested during suspend Michał Grzelak
2026-07-13 8:55 ` [PATCH i-g-t v1 05/16] tests/kms_frontbuffer_tracking: remove TEST_MODE_ITER_BEGIN() from `suspend` Michał Grzelak
2026-07-13 8:55 ` [PATCH i-g-t v1 06/16] tests/kms_frontbuffer_tracking: remove TEST_MODE_ITER_BEGIN() from `fliptrack` Michał Grzelak
2026-07-13 8:55 ` [PATCH i-g-t v1 07/16] tests/kms_pipe_crc_basic: limit #crtcs tested during suspend Michał Grzelak
2026-07-13 8:55 ` [PATCH i-g-t v1 08/16] tests/kms_psr: limit #outputs " Michał Grzelak
2026-07-13 8:55 ` [PATCH i-g-t v2 09/16] tests/kms_vblank: split outer test loop into two Michał Grzelak
2026-07-13 8:55 ` [PATCH i-g-t v1 10/16] tests/kms_vblank: limit #outputs tested during suspend Michał Grzelak
2026-07-13 8:55 ` [PATCH i-g-t v1 11/16] tests/kms_sharpness_filter: fix typo Michał Grzelak
2026-07-14 10:05 ` Garg, Nemesa
2026-07-13 8:55 ` [PATCH i-g-t v1 12/16] tests/kms_sharpness_filter: limit #outputs tested during suspend Michał Grzelak
2026-07-14 13:03 ` Garg, Nemesa
2026-07-13 8:55 ` [PATCH i-g-t v1 13/16] tests/kms_sharpness_filter: limit #crtcs " Michał Grzelak
2026-07-13 8:55 ` [PATCH i-g-t v1 14/16] tests/kms_ccs: split outer test loop into two Michał Grzelak
2026-07-13 8:55 ` [PATCH i-g-t v1 15/16] tests/kms_ccs: limit #outputs tested during suspend Michał Grzelak
2026-07-13 8:55 ` [PATCH i-g-t v1 16/16] tests/kms_ccs: limit #crtcs " Michał Grzelak
2026-07-13 12:04 ` ✓ Xe.CI.BAT: success for limiting suspend tests Patchwork
2026-07-13 12:24 ` ✓ i915.CI.BAT: " Patchwork
2026-07-13 14:39 ` ✓ Xe.CI.FULL: " Patchwork
2026-07-13 16:40 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713085515.463575-4-michal.grzelak@intel.com \
--to=michal.grzelak@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=mohammed.thasleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox