Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] lib/igt_device: Extract helper setting device filter from fd
@ 2026-07-23  9:57 Lukasz Laguna
  2026-07-23  9:57 ` [PATCH 2/2] tests/sriov_basic: Validate PF unbind with VFs enabled Lukasz Laguna
                   ` (5 more replies)
  0 siblings, 6 replies; 8+ messages in thread
From: Lukasz Laguna @ 2026-07-23  9:57 UTC (permalink / raw)
  To: igt-dev; +Cc: marcin.bernatowicz, janusz.krzysztofik

Helper sets device filter to the device corresponding to DRM device file
descriptor. Move the implementation from core_hotunplug test into the
library, so it can be reused in other tests.

Signed-off-by: Lukasz Laguna <lukasz.laguna@intel.com>
---
 lib/igt_device.c       | 22 ++++++++++++++++++++++
 lib/igt_device.h       |  1 +
 tests/core_hotunplug.c | 18 ++----------------
 3 files changed, 25 insertions(+), 16 deletions(-)

diff --git a/lib/igt_device.c b/lib/igt_device.c
index c617a98bc..b7227dc91 100644
--- a/lib/igt_device.c
+++ b/lib/igt_device.c
@@ -31,6 +31,7 @@
 #endif
 #include "igt.h"
 #include "igt_device.h"
+#include "igt_device_scan.h"
 #include "igt_sysfs.h"
 #include "igt_pci.h"
 
@@ -351,3 +352,24 @@ igt_device_get_pci_upstream_port(int fd)
 
 	return NULL;
 }
+
+/**
+ * igt_device_set_filter_from_fd:
+ * @fd: DRM device file descriptor
+ *
+ * Set device filter to the device corresponding to @fd.
+ */
+void igt_device_set_filter_from_fd(int fd)
+{
+	const char *filter_type = "sys:";
+	char filter[strlen(filter_type) + PATH_MAX + 1];
+	char *dst = stpcpy(filter, filter_type);
+	char path[PATH_MAX + 1];
+
+	igt_assert(igt_sysfs_path(fd, path, PATH_MAX));
+	igt_ignore_warn(strncat(path, "/device", PATH_MAX - strlen(path)));
+	igt_assert(realpath(path, dst));
+
+	igt_device_filter_free_all();
+	igt_assert_eq(igt_device_filter_add(filter), 1);
+}
diff --git a/lib/igt_device.h b/lib/igt_device.h
index 781a72235..3ad08d3ee 100644
--- a/lib/igt_device.h
+++ b/lib/igt_device.h
@@ -38,4 +38,5 @@ struct pci_device *igt_device_get_pci_root_port(int fd);
 struct pci_device *igt_device_get_pci_upstream_port(int fd);
 
 void igt_device_get_pci_slot_name(int fd, char *pci_slot_name);
+void igt_device_set_filter_from_fd(int fd);
 #endif /* __IGT_DEVICE_H__ */
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index 7c9dae1bf..c6e9d4854 100644
--- a/tests/core_hotunplug.c
+++ b/tests/core_hotunplug.c
@@ -35,6 +35,7 @@
 #include "i915/gem_create.h"
 #include "i915/perf.h"
 #include "igt.h"
+#include "igt_device.h"
 #include "igt_device_scan.h"
 #include "igt_kmod.h"
 #include "igt_sysfs.h"
@@ -550,21 +551,6 @@ static void post_healthcheck(struct hotunplug *priv)
 	cleanup(priv);
 }
 
-static void set_filter_from_device(int fd)
-{
-	const char *filter_type = "sys:";
-	char filter[strlen(filter_type) + PATH_MAX + 1];
-	char *dst = stpcpy(filter, filter_type);
-	char path[PATH_MAX + 1];
-
-	igt_assert(igt_sysfs_path(fd, path, PATH_MAX));
-	igt_ignore_warn(strncat(path, "/device", PATH_MAX - strlen(path)));
-	igt_assert(realpath(path, dst));
-
-	igt_device_filter_free_all();
-	igt_assert_eq(igt_device_filter_add(filter), 1);
-}
-
 /* Subtests */
 
 static void unbind_rebind(struct hotunplug *priv)
@@ -713,7 +699,7 @@ int igt_main()
 		}
 
 		/* Make sure subtests always reopen the same device */
-		set_filter_from_device(fd_drm);
+		igt_device_set_filter_from_fd(fd_drm);
 
 		igt_assert_eq(close_device(fd_drm, "", "selected "), -1);
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH 1/2] lib/igt_device_scan: Extract helper setting device filter from fd
@ 2026-07-29 10:09 Lukasz Laguna
  2026-07-29 10:09 ` [PATCH 2/2] tests/sriov_basic: Validate PF unbind with VFs enabled Lukasz Laguna
  0 siblings, 1 reply; 8+ messages in thread
From: Lukasz Laguna @ 2026-07-29 10:09 UTC (permalink / raw)
  To: igt-dev; +Cc: marcin.bernatowicz, janusz.krzysztofik

Helper sets device filter to the device corresponding to DRM device file
descriptor. Move the implementation from core_hotunplug test into the
library, so it can be reused in other tests.

Signed-off-by: Lukasz Laguna <lukasz.laguna@intel.com>
---
v3:
 - move it to igt_device_scan (Janusz)
---
 lib/igt_device_scan.c  | 23 +++++++++++++++++++++++
 lib/igt_device_scan.h  |  2 ++
 tests/core_hotunplug.c | 17 +----------------
 3 files changed, 26 insertions(+), 16 deletions(-)

diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
index 7c7995224..decf19646 100644
--- a/lib/igt_device_scan.c
+++ b/lib/igt_device_scan.c
@@ -2477,3 +2477,26 @@ int igt_device_prepare_filtered_view(const char *vendor)
 
 	return gpu_count;
 }
+
+/**
+ * igt_device_set_filter_from_fd:
+ * @fd: DRM device file descriptor
+ *
+ * Set device filter to the device corresponding to @fd.
+ */
+void igt_device_set_filter_from_fd(int fd)
+{
+	const char *filter_type = "sys:";
+	char filter[strlen(filter_type) + PATH_MAX + 1];
+	char *dst = stpcpy(filter, filter_type);
+	char path[PATH_MAX + 1];
+	struct stat st;
+
+	igt_assert(!fstat(fd, &st) && S_ISCHR(st.st_mode));
+	snprintf(path, sizeof(path), "/sys/dev/char/%d:%d/device",
+		 major(st.st_rdev), minor(st.st_rdev));
+	igt_assert(realpath(path, dst));
+
+	igt_device_filter_free_all();
+	igt_assert_eq(igt_device_filter_add(filter), 1);
+}
diff --git a/lib/igt_device_scan.h b/lib/igt_device_scan.h
index f24a193cd..ac75fea8c 100644
--- a/lib/igt_device_scan.h
+++ b/lib/igt_device_scan.h
@@ -103,4 +103,6 @@ int igt_open_render(struct igt_device_card *card);
 /* Add or use filters to match multiGPU devices */
 int igt_device_prepare_filtered_view(const char *vendor);
 
+void igt_device_set_filter_from_fd(int fd);
+
 #endif /* __IGT_DEVICE_SCAN_H__ */
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index 7c9dae1bf..33de65369 100644
--- a/tests/core_hotunplug.c
+++ b/tests/core_hotunplug.c
@@ -550,21 +550,6 @@ static void post_healthcheck(struct hotunplug *priv)
 	cleanup(priv);
 }
 
-static void set_filter_from_device(int fd)
-{
-	const char *filter_type = "sys:";
-	char filter[strlen(filter_type) + PATH_MAX + 1];
-	char *dst = stpcpy(filter, filter_type);
-	char path[PATH_MAX + 1];
-
-	igt_assert(igt_sysfs_path(fd, path, PATH_MAX));
-	igt_ignore_warn(strncat(path, "/device", PATH_MAX - strlen(path)));
-	igt_assert(realpath(path, dst));
-
-	igt_device_filter_free_all();
-	igt_assert_eq(igt_device_filter_add(filter), 1);
-}
-
 /* Subtests */
 
 static void unbind_rebind(struct hotunplug *priv)
@@ -713,7 +698,7 @@ int igt_main()
 		}
 
 		/* Make sure subtests always reopen the same device */
-		set_filter_from_device(fd_drm);
+		igt_device_set_filter_from_fd(fd_drm);
 
 		igt_assert_eq(close_device(fd_drm, "", "selected "), -1);
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2026-07-29 10:10 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-23  9:57 [PATCH 1/2] lib/igt_device: Extract helper setting device filter from fd Lukasz Laguna
2026-07-23  9:57 ` [PATCH 2/2] tests/sriov_basic: Validate PF unbind with VFs enabled Lukasz Laguna
2026-07-23 11:21 ` [PATCH 1/2] lib/igt_device: Extract helper setting device filter from fd Krzysztofik, Janusz
2026-07-23 13:28 ` ✓ Xe.CI.BAT: success for series starting with [1/2] " Patchwork
2026-07-23 13:48 ` ✓ i915.CI.BAT: " Patchwork
2026-07-24 13:37 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-07-24 17:11 ` ✗ i915.CI.Full: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2026-07-29 10:09 [PATCH 1/2] lib/igt_device_scan: " Lukasz Laguna
2026-07-29 10:09 ` [PATCH 2/2] tests/sriov_basic: Validate PF unbind with VFs enabled Lukasz Laguna

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox