From: Mark Yacoub <markyacoub@google.com>
To: igt-dev@lists.freedesktop.org
Cc: louis.chauvet@bootlin.com, Mark Yacoub <markyacoub@google.com>
Subject: [PATCH] unigraf: Use proper hardware API for HPD pulsing
Date: Thu, 13 Aug 2026 12:45:00 -0400 [thread overview]
Message-ID: <20260813164500.2287576-1-markyacoub@google.com> (raw)
With the latest Unigraf firmware, hardware HPD pulsing works reliably.
Switch to using the `unigraf_write_u32(TSI_DPRX_HPD_PULSE_W, ...)` API
directly rather than circumventing it with manual assert/deassert
time-based toggles.
Signed-off-by: Mark Yacoub <markyacoub@google.com>
---
lib/vendor/unigraf/unigraf.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/lib/vendor/unigraf/unigraf.c b/lib/vendor/unigraf/unigraf.c
index 30ee3c72b..627ec65b1 100644
--- a/lib/vendor/unigraf/unigraf.c
+++ b/lib/vendor/unigraf/unigraf.c
@@ -612,13 +612,7 @@ void unigraf_hpd_assert(void)
*/
void unigraf_hpd_pulse(int duration)
{
- /* In theory this should work:
- * unigraf_write_u32(TSI_DPRX_HPD_PULSE_W, duration);
- * But this seems to be broken and this works:
- */
- unigraf_hpd_deassert();
- usleep(duration);
- unigraf_hpd_assert();
+ unigraf_write_u32(TSI_DPRX_HPD_PULSE_W, duration);
}
/**
--
2.55.0.691.gc56d675ccc-goog
reply other threads:[~2026-08-13 16:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260813164500.2287576-1-markyacoub@google.com \
--to=markyacoub@google.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=louis.chauvet@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).