Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] unigraf: Use proper hardware API for HPD pulsing
@ 2026-08-13 16:45 Mark Yacoub
  0 siblings, 0 replies; only message in thread
From: Mark Yacoub @ 2026-08-13 16:45 UTC (permalink / raw)
  To: igt-dev; +Cc: louis.chauvet, Mark Yacoub

With the latest Unigraf firmware, hardware HPD pulsing works reliably.
Switch to using the `unigraf_write_u32(TSI_DPRX_HPD_PULSE_W, ...)` API
directly rather than circumventing it with manual assert/deassert
time-based toggles.

Signed-off-by: Mark Yacoub <markyacoub@google.com>
---
 lib/vendor/unigraf/unigraf.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/lib/vendor/unigraf/unigraf.c b/lib/vendor/unigraf/unigraf.c
index 30ee3c72b..627ec65b1 100644
--- a/lib/vendor/unigraf/unigraf.c
+++ b/lib/vendor/unigraf/unigraf.c
@@ -612,13 +612,7 @@ void unigraf_hpd_assert(void)
  */
 void unigraf_hpd_pulse(int duration)
 {
-	/* In theory this should work:
-	 * unigraf_write_u32(TSI_DPRX_HPD_PULSE_W, duration);
-	 * But this seems to be broken and this works:
-	 */
-	unigraf_hpd_deassert();
-	usleep(duration);
-	unigraf_hpd_assert();
+	unigraf_write_u32(TSI_DPRX_HPD_PULSE_W, duration);
 }
 
 /**
-- 
2.55.0.691.gc56d675ccc-goog


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-08-13 16:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-13 16:45 [PATCH] unigraf: Use proper hardware API for HPD pulsing Mark Yacoub

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox