From: Sowmiya S <sowmiya.s@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com, kunal1.joshi@intel.com,
Sowmiya S <sowmiya.s@intel.com>
Subject: [PATCH i-g-t v5 2/4] tests/intel/kms_dp_linktrain_fallback: Reset traversed MST output count
Date: Mon, 17 Aug 2026 13:56:10 +0530 [thread overview]
Message-ID: <20260817082612.1101382-3-sowmiya.s@intel.com> (raw)
In-Reply-To: <20260817082612.1101382-1-sowmiya.s@intel.com>
run_lt_fallback_test() tracks which MST outputs it has already
traversed in a file-static counter that is never cleared. Today it
has a single caller so the counter is implicitly zero, but a second
caller would silently inherit the first run's state and skip every
MST sibling as "already visited".
Reset the counter on entry so the function is safe to call more than
once per binary. The DSC path never reaches setup_mst_outputs(), so
run_dsc_sst_fallaback_test() does not need the same treatment.
v4: reworded commit message to explain this is a no-op prep patch
until run_lt_fallback_test() gains a second caller (Kunal)
Signed-off-by: Sowmiya S <sowmiya.s@intel.com>
---
tests/intel/kms_dp_linktrain_fallback.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tests/intel/kms_dp_linktrain_fallback.c b/tests/intel/kms_dp_linktrain_fallback.c
index 115183d2d..44b875ab9 100644
--- a/tests/intel/kms_dp_linktrain_fallback.c
+++ b/tests/intel/kms_dp_linktrain_fallback.c
@@ -431,6 +431,13 @@ static bool run_lt_fallback_test(data_t *data)
bool ran = false;
igt_output_t *output;
+ /*
+ * Reset per invocation so MST traversal state from a previous subtest
+ * (e.g. dp-fallback followed by dsc-fallback) doesn't leak and cause
+ * MST siblings to be silently skipped as "already visited".
+ */
+ traversed_mst_output_count = 0;
+
for_each_connected_output(&data->display, output) {
data->output = output;
--
2.43.0
next prev parent reply other threads:[~2026-08-17 8:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 8:26 [PATCH i-g-t v5 0/4] kms_dp_linktrain_fallback: Add UHBR-to-HBR fallback subtest Sowmiya S
2026-08-17 8:26 ` [PATCH i-g-t v5 1/4] lib/i915/i915_dp: Add UHBR helpers and const-correct set_link_params Sowmiya S
2026-08-19 5:24 ` Joshi, Kunal1
2026-08-17 8:26 ` Sowmiya S [this message]
2026-08-19 5:24 ` [PATCH i-g-t v5 2/4] tests/intel/kms_dp_linktrain_fallback: Reset traversed MST output count Joshi, Kunal1
2026-08-17 8:26 ` [PATCH i-g-t v5 3/4] tests/intel/kms_dp_linktrain_fallback: Add UHBR-to-HBR fallback subtest Sowmiya S
2026-08-19 5:25 ` Joshi, Kunal1
2026-08-17 8:26 ` [PATCH i-g-t v5 4/4] tests/intel/kms_dp_linktrain_fallback: commit display reset before fallback Sowmiya S
2026-08-19 5:16 ` Joshi, Kunal1
2026-08-17 9:02 ` [PATCH i-g-t v5 0/4] kms_dp_linktrain_fallback: Add UHBR-to-HBR fallback subtest Jani Nikula
2026-08-17 9:21 ` S, Sowmiya
2026-08-17 9:50 ` Jani Nikula
2026-08-17 16:23 ` ✓ Xe.CI.BAT: success for kms_dp_linktrain_fallback: Add UHBR-to-HBR fallback subtest (rev3) Patchwork
2026-08-17 16:39 ` ✓ i915.CI.BAT: " Patchwork
2026-08-17 19:04 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-08-18 6:30 ` ✗ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260817082612.1101382-3-sowmiya.s@intel.com \
--to=sowmiya.s@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karthik.b.s@intel.com \
--cc=kunal1.joshi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox