From: Sowmiya S <sowmiya.s@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com, kunal1.joshi@intel.com,
Sowmiya S <sowmiya.s@intel.com>
Subject: [PATCH i-g-t v5 4/4] tests/intel/kms_dp_linktrain_fallback: commit display reset before fallback
Date: Mon, 17 Aug 2026 13:56:12 +0530 [thread overview]
Message-ID: <20260817082612.1101382-5-sowmiya.s@intel.com> (raw)
In-Reply-To: <20260817082612.1101382-1-sowmiya.s@intel.com>
igt_display_reset() only clears IGT's in-memory state without a
commit, so the link from a previous run stays trained as-is. The
next setup_outputs() call re-applies the same mode on the same pipe,
which the driver satisfies with a fastset instead of a real modeset,
so the link never gets retrained from the sink's max. This makes
prev_link_rate/lane_count start from an already-reduced config and
fail with "Fallback unsuccessful".
Fix it by committing the reset, forcing the pipe off and the link
retrained from the max before each run.
Signed-off-by: Sowmiya S <sowmiya.s@intel.com>
---
tests/intel/kms_dp_linktrain_fallback.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/intel/kms_dp_linktrain_fallback.c b/tests/intel/kms_dp_linktrain_fallback.c
index 2e72957e1..4ceaad8b5 100644
--- a/tests/intel/kms_dp_linktrain_fallback.c
+++ b/tests/intel/kms_dp_linktrain_fallback.c
@@ -383,6 +383,7 @@ static bool test_fallback(data_t *data, bool is_mst, bool force_uhbr)
retries = SPURIOUS_HPD_RETRY;
igt_display_reset(&data->display);
+ igt_display_commit2(&data->display, COMMIT_ATOMIC);
/*
* For the UHBR-to-HBR fallback case, pin the link at the highest
--
2.43.0
next prev parent reply other threads:[~2026-08-17 8:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 8:26 [PATCH i-g-t v5 0/4] kms_dp_linktrain_fallback: Add UHBR-to-HBR fallback subtest Sowmiya S
2026-08-17 8:26 ` [PATCH i-g-t v5 1/4] lib/i915/i915_dp: Add UHBR helpers and const-correct set_link_params Sowmiya S
2026-08-19 5:24 ` Joshi, Kunal1
2026-08-17 8:26 ` [PATCH i-g-t v5 2/4] tests/intel/kms_dp_linktrain_fallback: Reset traversed MST output count Sowmiya S
2026-08-19 5:24 ` Joshi, Kunal1
2026-08-17 8:26 ` [PATCH i-g-t v5 3/4] tests/intel/kms_dp_linktrain_fallback: Add UHBR-to-HBR fallback subtest Sowmiya S
2026-08-19 5:25 ` Joshi, Kunal1
2026-08-17 8:26 ` Sowmiya S [this message]
2026-08-19 5:16 ` [PATCH i-g-t v5 4/4] tests/intel/kms_dp_linktrain_fallback: commit display reset before fallback Joshi, Kunal1
2026-08-17 9:02 ` [PATCH i-g-t v5 0/4] kms_dp_linktrain_fallback: Add UHBR-to-HBR fallback subtest Jani Nikula
2026-08-17 9:21 ` S, Sowmiya
2026-08-17 9:50 ` Jani Nikula
2026-08-17 16:23 ` ✓ Xe.CI.BAT: success for kms_dp_linktrain_fallback: Add UHBR-to-HBR fallback subtest (rev3) Patchwork
2026-08-17 16:39 ` ✓ i915.CI.BAT: " Patchwork
2026-08-17 19:04 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-08-18 6:30 ` ✗ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260817082612.1101382-5-sowmiya.s@intel.com \
--to=sowmiya.s@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karthik.b.s@intel.com \
--cc=kunal1.joshi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).