Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: George Zhang <george.zhang@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: Fangzhi Zuo <jerry.zuo@amd.com>,
	Ivan Lipski <ivan.lipski@amd.com>,
	"Alex Hung" <alex.hung@amd.com>,
	Harry Wentland <harry.wentland@amd.com>,
	"George Zhang" <george.zhang@amd.com>
Subject: [i-g-t, v2 1/2] tests/amdgpu/amd_dp_dsc: Do not disable DSC for high bw panels
Date: Thu, 3 Sep 2026 15:24:51 -0400	[thread overview]
Message-ID: <20260903192458.1149302-1-george.zhang@amd.com> (raw)

The test previously attempted to disable DSC even on high bandwidth
panels. This would erroneously fail the dsc_enable test even though DSC
is on.

Fix this by checking what mode the panel defaults to when set to
automatic. If DSC is on, then do not attempt to force it off later.

Signed-off-by: George Zhang <george.zhang@amd.com>
---
 tests/amdgpu/amd_dp_dsc.c | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/tests/amdgpu/amd_dp_dsc.c b/tests/amdgpu/amd_dp_dsc.c
index dc71e903e..690a6c39d 100644
--- a/tests/amdgpu/amd_dp_dsc.c
+++ b/tests/amdgpu/amd_dp_dsc.c
@@ -137,6 +137,9 @@ static void test_dsc_enable(data_t *data)
 		igt_output_set_crtc(output,
 				    crtc);
 		igt_plane_set_fb(data->primary[crtc->crtc_index], &ref_fb);
+
+		/* Make sure we are in automatic mode before we start */
+		igt_amd_write_dsc_clock_en(data->fd, output->name, DSC_AUTOMATIC);
 		igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, 0);
 
 		test_conn_cnt++;
@@ -153,8 +156,12 @@ static void test_dsc_enable(data_t *data)
 		/* Check if DSC is enabled */
 		dsc_on = igt_amd_read_dsc_clock_status(data->fd, output->name) == 1;
 
-		/* Revert DSC to automatic state */
-		igt_amd_write_dsc_clock_en(data->fd, output->name, DSC_FORCE_OFF);
+		/**
+		 * We can only force off if the panel is capable of running with DSC disabled.
+		 * If DSC was ON in automatic mode, we cannot (and should not) force it OFF.
+		 */
+		if (!dsc_before)
+			igt_amd_write_dsc_clock_en(data->fd, output->name, DSC_FORCE_OFF);
 
 		igt_plane_set_fb(data->primary[crtc->crtc_index], &ref_fb);
 		igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
@@ -286,6 +293,7 @@ static void test_dsc_slice_dimensions_change(data_t *data)
 		igt_output_set_crtc(output,
 				    crtc);
 		igt_plane_set_fb(data->primary[crtc->crtc_index], &ref_fb);
+		igt_amd_write_dsc_clock_en(data->fd, output->name, DSC_AUTOMATIC);
 		igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, 0);
 
 		test_conn_cnt++;
@@ -316,8 +324,12 @@ static void test_dsc_slice_dimensions_change(data_t *data)
 							     ref_fb);
 		}
 
-		/* Force disable DSC */
-		igt_amd_write_dsc_clock_en(data->fd, output->name, DSC_FORCE_OFF);
+		/**
+		 * We can only force off if the panel is capable of running with DSC disabled.
+		 * If DSC was ON in automatic mode, we cannot (and should not) force it OFF.
+		 */
+		if (!dsc_before)
+			igt_amd_write_dsc_clock_en(data->fd, output->name, DSC_FORCE_OFF);
 
 		igt_plane_set_fb(data->primary[crtc->crtc_index], &ref_fb);
 		igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
-- 
2.55.0


             reply	other threads:[~2026-09-03 19:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03 19:24 George Zhang [this message]
2026-09-03 19:24 ` [i-g-t, v2 2/2] tests/amdgpu/amd_dp_dsc: Reset link settings after subtest George Zhang
2026-09-03 20:51   ` Alex Hung
2026-09-03 20:50 ` [i-g-t,v2 1/2] tests/amdgpu/amd_dp_dsc: Do not disable DSC for high bw panels Alex Hung
2026-09-03 22:12 ` ✓ Xe.CI.BAT: success for series starting with [i-g-t,v2,1/2] " Patchwork
2026-09-03 22:22 ` ✓ i915.CI.BAT: " Patchwork
2026-09-04 10:49 ` ✓ Xe.CI.FULL: " Patchwork
2026-09-04 14:10 ` ✓ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260903192458.1149302-1-george.zhang@amd.com \
    --to=george.zhang@amd.com \
    --cc=alex.hung@amd.com \
    --cc=harry.wentland@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=ivan.lipski@amd.com \
    --cc=jerry.zuo@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox