Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t] tests/amdgpu: insert pause mnemonic only on x86 / x86_64 platforms
Date: Fri,  2 Oct 2026 22:14:01 +0300	[thread overview]
Message-ID: <20261002191401.469214-1-dmitry.baryshkov@oss.qualcomm.com> (raw)

The "pause" assembly mnemonic is only available on IA-32 platforms,
breaking e.g. debug IGT builds on ARM / AArch64. The issue manifests
only with -O1 or -O0, the default -O2 seems to optimize the condition
away.

Guard this inline assembly with the preprocessor checks, making sure
that other platforms don't see the invalid assembly.

FAILED: [code=1] tests/amdgpu/amd_basic.p/amd_basic.c.o
Assembler messages:
{standard input}:3702: Error: unknown mnemonic `pause' -- `pause'

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
 tests/amdgpu/amd_basic.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/amdgpu/amd_basic.c b/tests/amdgpu/amd_basic.c
index 418db286f81f..494934c1c321 100644
--- a/tests/amdgpu/amd_basic.c
+++ b/tests/amdgpu/amd_basic.c
@@ -705,8 +705,10 @@ static int wait_for_value64(volatile uint64_t *ptr, uint64_t expected,
 		/* Sleep if interval specified, otherwise tight loop */
 		if (check_interval_ns > 0)
 			nanosleep(&sleep_time, NULL);
+#if defined(x86_64) || defined(i386)
 		else
 			__asm__ __volatile__("pause" ::: "memory"); /* CPU hint for spin-wait */
+#endif
 	}
 }
 
-- 
2.53.0


             reply	other threads:[~2026-10-02 19:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02 19:14 Dmitry Baryshkov [this message]
2026-10-02 20:35 ` ✓ Xe.CI.BAT: success for tests/amdgpu: insert pause mnemonic only on x86 / x86_64 platforms Patchwork
2026-10-02 20:45 ` ✓ i915.CI.BAT: " Patchwork
2026-10-02 22:26 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-10-03 18:32 ` ✗ i915.CI.Full: " Patchwork
2026-10-06 14:29 ` [PATCH i-g-t] " Kamil Konieczny
2026-10-06 23:08   ` vitaly prosyak
2026-10-20 19:31     ` Kamil Konieczny
2026-10-21 14:58       ` vitaly prosyak
2026-10-22 13:13         ` Kamil Konieczny
2026-10-08 14:21 ` Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261002191401.469214-1-dmitry.baryshkov@oss.qualcomm.com \
    --to=dmitry.baryshkov@oss.qualcomm.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox