Re: [PATCH i-g-t] tests/amdgpu: insert pause mnemonic only on x86 / x86_64 platforms

[vitaly prosyak <vprosyak@amd.com>]

Thanks Dmitry!

Reviewed-by: Vitaly Prosyak <vitaly.prosyak@amd.com>

On 2026-10-06 10:29, Kamil Konieczny wrote:
> Hi Dmitry,
> On 2026-10-02 at 22:14:01 +0300, Dmitry Baryshkov wrote:
>> The "pause" assembly mnemonic is only available on IA-32 platforms,
>> breaking e.g. debug IGT builds on ARM / AArch64. The issue manifests
>> only with -O1 or -O0, the default -O2 seems to optimize the condition
>> away.
>>
>> Guard this inline assembly with the preprocessor checks, making sure
>> that other platforms don't see the invalid assembly.
>>
>> FAILED: [code=1] tests/amdgpu/amd_basic.p/amd_basic.c.o
>> Assembler messages:
>> {standard input}:3702: Error: unknown mnemonic `pause' -- `pause'
>>
> Please add in Cc amdgpu devs, found by git log -- testname.c
> here
> Cc: Jesse Zhang <jesse.zhang@amd.com>
> Cc: Vitaly Prosyak <vitaly.prosyak@amd.com>
>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> LGTM
> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>
>
> Regards,
> Kamil
>
>> ---
>>  tests/amdgpu/amd_basic.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/tests/amdgpu/amd_basic.c b/tests/amdgpu/amd_basic.c
>> index 418db286f81f..494934c1c321 100644
>> --- a/tests/amdgpu/amd_basic.c
>> +++ b/tests/amdgpu/amd_basic.c
>> @@ -705,8 +705,10 @@ static int wait_for_value64(volatile uint64_t *ptr, uint64_t expected,
>>  		/* Sleep if interval specified, otherwise tight loop */
>>  		if (check_interval_ns > 0)
>>  			nanosleep(&sleep_time, NULL);
>> +#if defined(x86_64) || defined(i386)
>>  		else
>>  			__asm__ __volatile__("pause" ::: "memory"); /* CPU hint for spin-wait */
>> +#endif
>>  	}
>>  }
>>  
>> -- 
>> 2.53.0
>>