From: "Michał Grzelak" <michal.grzelak@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com, swati2.sharma@intel.com,
juhapekka.heikkila@gmail.com, jani.nikula@intel.com,
michal.grzelak@intel.com,
"Michał Grzelak" <michal.grzelak@linux.intel.com>
Subject: [PATCH i-g-t v7 1/7] tests/kms_async_flips: split outer test loop into two
Date: Fri, 2 Oct 2026 22:15:19 +0200 [thread overview]
Message-ID: <20261002201525.466080-2-michal.grzelak@linux.intel.com> (raw)
In-Reply-To: <20261002201525.466080-1-michal.grzelak@linux.intel.com>
for_each_crtc_with_valid_output() iterates over every crtc with
connected output. Split it into two loops. This is needed to handle
cases per output.
v3->v4
- break outer loop as well (Thasleem)
- add missing space (Thasleem)
Signed-off-by: Michał Grzelak <michal.grzelak@linux.intel.com>
---
tests/kms_async_flips.c | 63 ++++++++++++++++++++++-------------------
1 file changed, 34 insertions(+), 29 deletions(-)
diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
index ef4b28eb52..8884efd8ba 100644
--- a/tests/kms_async_flips.c
+++ b/tests/kms_async_flips.c
@@ -877,39 +877,44 @@ static void run_test(data_t *data, void (*test)(data_t *))
if (data->atomic_path)
require_atomic_async_cap(data);
- for_each_crtc_with_valid_output(display, crtc, data->output) {
- data->crtc = crtc;
- igt_display_reset(display);
+ for_each_connected_output(display, data->output) {
+ for_each_crtc(&data->display, crtc) {
+ if (!igt_crtc_connector_valid(crtc, data->output))
+ continue;
- igt_output_set_crtc(data->output,
- crtc);
- if (!intel_pipe_output_combo_valid(display))
- continue;
+ data->crtc = crtc;
+ igt_display_reset(display);
- test_init(data);
+ igt_output_set_crtc(data->output,
+ crtc);
+ if (!intel_pipe_output_combo_valid(display))
+ continue;
- if (data->linear_modifier)
- data->modifier = DRM_FORMAT_MOD_LINEAR;
- else
- data->modifier = default_modifier(data);
-
- igt_require(igt_format_mods_has_modifier(&data->plane->format_mods_async,
- data->modifier));
-
- igt_dynamic_f("pipe-%s-%s", igt_crtc_name(crtc),
- data->output->name) {
- /*
- * FIXME: joiner+async flip is busted currently in KMD.
- * Remove this check once the issues are fixed in KMD.
- */
- igt_skip_on_f(is_joiner_mode(data->drm_fd, data->output),
- "Skipping, async flip not supported on joiner mode\n");
- test_init_fbs(data);
- test(data);
+ test_init(data);
+
+ if (data->linear_modifier)
+ data->modifier = DRM_FORMAT_MOD_LINEAR;
+ else
+ data->modifier = default_modifier(data);
+
+ igt_require(igt_format_mods_has_modifier(&data->plane->format_mods_async,
+ data->modifier));
+
+ igt_dynamic_f("pipe-%s-%s", igt_crtc_name(crtc),
+ data->output->name) {
+ /*
+ * FIXME: joiner+async flip is busted currently in KMD.
+ * Remove this check once the issues are fixed in KMD.
+ */
+ igt_skip_on_f(is_joiner_mode(data->drm_fd, data->output),
+ "Skipping, async flip not supported on joiner mode\n");
+ test_init_fbs(data);
+ test(data);
+ }
+ /* Restrict to single pipe in simulation */
+ if (data->single_pipe)
+ return;
}
- /* Restrict to single pipe in simulation */
- if (data->single_pipe)
- break;
}
}
--
2.45.2
next prev parent reply other threads:[~2026-10-02 20:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 20:15 [PATCH i-g-t v7 0/7] tests: limiting suspend tests Michał Grzelak
2026-10-02 20:15 ` Michał Grzelak [this message]
2026-10-02 20:15 ` [PATCH i-g-t v7 2/7] tests/kms_async_flips: limit #pipes tested during suspend Michał Grzelak
2026-10-02 20:15 ` [PATCH i-g-t v7 3/7] tests/kms_vblank: limit #outputs " Michał Grzelak
2026-10-02 20:15 ` [PATCH i-g-t v7 4/7] tests/intel/kms_ccs: split outer test loop into two Michał Grzelak
2026-10-02 20:15 ` [PATCH i-g-t v7 5/7] tests/intel/kms_ccs: limit #outputs tested during suspend Michał Grzelak
2026-10-02 20:15 ` [PATCH i-g-t v7 6/7] tests/intel/kms_ccs: limit #pipes " Michał Grzelak
2026-10-02 20:15 ` [PATCH i-g-t v7 7/7] tests/kms_hdr: run on 3 outputs when testing suspend Michał Grzelak
2026-10-02 21:00 ` ✓ Xe.CI.BAT: success for tests: limiting suspend tests (rev6) Patchwork
2026-10-02 21:12 ` ✓ i915.CI.BAT: " Patchwork
2026-10-02 22:58 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-10-03 19:30 ` ✗ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002201525.466080-2-michal.grzelak@linux.intel.com \
--to=michal.grzelak@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=juhapekka.heikkila@gmail.com \
--cc=karthik.b.s@intel.com \
--cc=michal.grzelak@intel.com \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox