Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Michał Grzelak" <michal.grzelak@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com, swati2.sharma@intel.com,
	juhapekka.heikkila@gmail.com, jani.nikula@intel.com,
	michal.grzelak@intel.com,
	"Michał Grzelak" <michal.grzelak@linux.intel.com>
Subject: [PATCH i-g-t v7 6/7] tests/intel/kms_ccs: limit #pipes tested during suspend
Date: Fri,  2 Oct 2026 22:15:24 +0200	[thread overview]
Message-ID: <20261002201525.466080-7-michal.grzelak@linux.intel.com> (raw)
In-Reply-To: <20261002201525.466080-1-michal.grzelak@linux.intel.com>

Limit execution of suspend tests to first and last active pipe unless
using `extended` flag. This reduces default execution time of the test.
In turn this can lower chances of hitting CI timeout.

Alternatively test could be run on first and last CRTC; but due to pipe
reordering, this would result in using arbitrary pipes. Thus use first
and last hardware pipe when running suspend tests.

v6->v7
- use first and last hardware pipe instead of CRTCs (J-P, Jani)

v5->v6
- describe how pipe reordering affects the test (Jani)

v3->v4
- set `first' and `last' indices outside of crtc loop (Thasleem)

Signed-off-by: Michał Grzelak <michal.grzelak@linux.intel.com>
---
 tests/intel/kms_ccs.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/tests/intel/kms_ccs.c b/tests/intel/kms_ccs.c
index 8526f1ccfd..f9c713d85b 100644
--- a/tests/intel/kms_ccs.c
+++ b/tests/intel/kms_ccs.c
@@ -191,6 +191,7 @@ typedef struct {
 	int fb_list_length;
 	bool do_hibernate;
 	bool all_outputs;
+	bool all_crtcs;
 	struct {
 		struct igt_fb fb;
 		int width, height;
@@ -1132,12 +1133,15 @@ static void test_output(data_t *data, const int testnum)
 	igt_crtc_t *crtc;
 	uint16_t dev_id;
 	int output_count = 0;
+	int n_crtcs;
 
 	igt_fixture()
 		dev_id = intel_get_drm_devid(data->drm_fd);
 
 	data->flags = tests[testnum].flags;
 
+	n_crtcs = igt_display_n_crtcs(&data->display);
+
 	for (int i = 0; i < ARRAY_SIZE(ccs_modifiers); i++) {
 		if (!valid_modifier_test(ccs_modifiers[i].modifier,
 					 data->flags))
@@ -1176,6 +1180,10 @@ static void test_output(data_t *data, const int testnum)
 					if (!intel_pipe_output_combo_valid(&data->display))
 						continue;
 
+					if (!data->all_crtcs && (data->flags & TEST_SUSPEND) &&
+					    crtc->hardware_pipe != PIPE_A && crtc->hardware_pipe != PIPE_NONE + n_crtcs)
+						continue;
+
 					igt_dynamic_f("pipe-%s-%s", igt_crtc_name(crtc), data->output->name) {
 						int valid_tests = 0;
 
@@ -1232,6 +1240,9 @@ static int opt_handler(int opt, int opt_index, void *opt_data)
 	case 'n':
 		data->all_outputs = true;
 		break;
+	case 'e':
+		data->all_crtcs = true;
+		break;
 	default:
 		return IGT_OPT_HANDLER_ERROR;
 	}
@@ -1246,9 +1257,10 @@ static const char *help_str =
 "  -s <seed>\tSeed for random number generator\n"
 "  -r\t\tOn suspend test do full hibernate with reboot\n"
 "  -n\t\tRun on all connectors. (By default suspend subtests will run on 3 connectors)\n"
+"  -e\t\tRun on all CRTCs. (By default subtests will run on two CRTCs)\n"
 ;
 
-int igt_main_args("csrn:", NULL, help_str, opt_handler, &data)
+int igt_main_args("csrne:", NULL, help_str, opt_handler, &data)
 {
 	igt_fixture() {
 		data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);
-- 
2.45.2


  parent reply	other threads:[~2026-10-02 20:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02 20:15 [PATCH i-g-t v7 0/7] tests: limiting suspend tests Michał Grzelak
2026-10-02 20:15 ` [PATCH i-g-t v7 1/7] tests/kms_async_flips: split outer test loop into two Michał Grzelak
2026-10-02 20:15 ` [PATCH i-g-t v7 2/7] tests/kms_async_flips: limit #pipes tested during suspend Michał Grzelak
2026-10-02 20:15 ` [PATCH i-g-t v7 3/7] tests/kms_vblank: limit #outputs " Michał Grzelak
2026-10-02 20:15 ` [PATCH i-g-t v7 4/7] tests/intel/kms_ccs: split outer test loop into two Michał Grzelak
2026-10-02 20:15 ` [PATCH i-g-t v7 5/7] tests/intel/kms_ccs: limit #outputs tested during suspend Michał Grzelak
2026-10-02 20:15 ` Michał Grzelak [this message]
2026-10-02 20:15 ` [PATCH i-g-t v7 7/7] tests/kms_hdr: run on 3 outputs when testing suspend Michał Grzelak
2026-10-02 21:00 ` ✓ Xe.CI.BAT: success for tests: limiting suspend tests (rev6) Patchwork
2026-10-02 21:12 ` ✓ i915.CI.BAT: " Patchwork
2026-10-02 22:58 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-10-03 19:30 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261002201525.466080-7-michal.grzelak@linux.intel.com \
    --to=michal.grzelak@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=juhapekka.heikkila@gmail.com \
    --cc=karthik.b.s@intel.com \
    --cc=michal.grzelak@intel.com \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox