Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_pread/pwrite: Rename "basic"

["Ser, Simon" <simon.ser@intel.com>]

On Thu, 2019-06-27 at 08:36 +0100, Chris Wilson wrote:
> The "basic" subtests perform no verification that the read/write work,
> only function as mere API exercisers and loose benchmarks. Rename them
> to reflect that they are poor benchmarks instead.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Simon Ser <simon.ser@intel.com>

> ---
>  tests/i915/gem_pread.c                | 2 +-
>  tests/i915/gem_pwrite.c               | 2 +-
>  tests/intel-ci/fast-feedback.testlist | 2 --
>  3 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/i915/gem_pread.c b/tests/i915/gem_pread.c
> index c64787653..0d3e10b80 100644
> --- a/tests/i915/gem_pread.c
> +++ b/tests/i915/gem_pread.c
> @@ -159,7 +159,7 @@ igt_main_args("s:", NULL, help_str, opt_handler, NULL)
>  		dst_user = malloc(object_size);
>  	}
>  
> -	igt_subtest("basic") {
> +	igt_subtest("bench") {
>  		for (count = 1; count <= 1<<17; count <<= 1) {
>  			struct timeval start, end;
>  
> diff --git a/tests/i915/gem_pwrite.c b/tests/i915/gem_pwrite.c
> index 97703a2aa..37e978791 100644
> --- a/tests/i915/gem_pwrite.c
> +++ b/tests/i915/gem_pwrite.c
> @@ -286,7 +286,7 @@ igt_main_args("s:", NULL, help_str, opt_handler, NULL)
>  		src_user = malloc(object_size);
>  	}
>  
> -	igt_subtest("basic") {
> +	igt_subtest("bench") {
>  		for (count = 1; count <= 1<<17; count <<= 1) {
>  			struct timeval start, end;
>  
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index 8618dfd28..5fcb5e76d 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -87,8 +87,6 @@ igt@gem_mmap_gtt@basic-write-gtt-no-prefault
>  igt@gem_mmap_gtt@basic-write-no-prefault
>  igt@gem_mmap_gtt@basic-write-read
>  igt@gem_mmap_gtt@basic-write-read-distinct
> -igt@gem_pread@basic
> -igt@gem_pwrite@basic
>  igt@gem_render_linear_blits@basic
>  igt@gem_render_tiled_blits@basic
>  igt@gem_ringfill@basic-default
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx