From: Martin Peres <martin.peres@linux.intel.com>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>,
"Ser, Simon" <simon.ser@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] i915/gem_pread/pwrite: Rename "basic"
Date: Thu, 27 Jun 2019 16:29:28 +0300 [thread overview]
Message-ID: <67c02a5c-6c0d-d6c1-ec67-80f9443f4079@linux.intel.com> (raw)
In-Reply-To: <20190627132635.ylxu4jmeslcxobva@ahiler-desk1.fi.intel.com>
On 27/06/2019 16:26, Arkadiusz Hiler wrote:
> On Thu, Jun 27, 2019 at 08:18:36AM +0000, Ser, Simon wrote:
>> On Thu, 2019-06-27 at 08:36 +0100, Chris Wilson wrote:
>>> The "basic" subtests perform no verification that the read/write work,
>>> only function as mere API exercisers and loose benchmarks. Rename them
>>> to reflect that they are poor benchmarks instead.
>>>
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>
>> Reviewed-by: Simon Ser <simon.ser@intel.com>
>
> you forgot to add r-b while pushing
>
> Tests are now renamed in the cibuglog, so all the existing filters (1)
> will apply. It's nice to CC someone handling cibuglog when renaming,
> otherwise we will end up with more noise and spend time on creating and
> deduplicating bugs later on.
My fault. I gave the ACK but had not done the rename yet. Sorry about that!
Martin
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-06-27 13:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 7:36 [igt-dev] [PATCH i-g-t] i915/gem_pread/pwrite: Rename "basic" Chris Wilson
2019-06-27 8:18 ` [Intel-gfx] " Ser, Simon
2019-06-27 13:26 ` [igt-dev] [Intel-gfx] " Arkadiusz Hiler
2019-06-27 13:29 ` Martin Peres [this message]
2019-06-27 10:08 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-06-28 9:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67c02a5c-6c0d-d6c1-ec67-80f9443f4079@linux.intel.com \
--to=martin.peres@linux.intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=simon.ser@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox