Re: [igt-dev] [PATCH i-g-t v6 1/6] tests/i915_pm_lpsp: Nuke the panel-fitter test

["Manna, Animesh" <animesh.manna@intel.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1334 bytes --]


On 05-05-2020 18:50, Anshuman Gupta wrote:
> panel-fitter subtest is only applicable to HASWELL/BROADWELL.
> It just tests non-lpsp(lpsp disabled) when panel fitter is
> enforced by std 1024x768 mode.
> There is no ROI to test non-lpsp kind of thing,
> If HSW_GLOBAL power well is not enabled we would see
> other display issues in other display tests.
>
> Gen9+ platform has display scaling feature in built per
> pipe, as lpsp is all about low power single pipe (PIPE A)
> usage, gen9+ platforms also don't require panel-fitter subtest.
> This should save some CI cycles.
>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>

Changes looks good to me.
Reviewed-by: Animesh Manna <animesh.manna@intel.com>

> ---
>   tests/i915/i915_pm_lpsp.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/tests/i915/i915_pm_lpsp.c b/tests/i915/i915_pm_lpsp.c
> index 42938e10..08f82e7c 100644
> --- a/tests/i915/i915_pm_lpsp.c
> +++ b/tests/i915/i915_pm_lpsp.c
> @@ -219,8 +219,6 @@ igt_main
>   		screens_disabled_subtest(drm_fd, drm_res);
>   	igt_subtest("edp-native")
>   		edp_subtest(drm_fd, drm_res, drm_connectors, devid, false);
> -	igt_subtest("edp-panel-fitter")
> -		edp_subtest(drm_fd, drm_res, drm_connectors, devid, true);
>   	igt_subtest("non-edp")
>   		non_edp_subtest(drm_fd, drm_res, drm_connectors);
>   

[-- Attachment #1.2: Type: text/html, Size: 1961 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev