Re: [igt-dev] [PATCH v2 1/2] lib/amdgpu: Add check for ODM combine segments debugfs endpoint

[Alex Hung <alex.hung@amd.com>]

On 2023-08-18 11:56, Aurabindo Pillai wrote:
> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
> ---
>   lib/igt_amd.c | 10 ++++++++++
>   lib/igt_amd.h |  4 ++++
>   2 files changed, 14 insertions(+)
> 
> diff --git a/lib/igt_amd.c b/lib/igt_amd.c
> index 83011e8ca..1a720ff56 100644
> --- a/lib/igt_amd.c
> +++ b/lib/igt_amd.c
> @@ -325,6 +325,16 @@ static bool igt_amd_output_has_dsc(int drm_fd, char *connector_name)
>   	return igt_amd_output_has_debugfs(drm_fd, connector_name, DEBUGFS_DSC_CLOCK_EN);
>   }
>   
> +/**
> + * igt_amd_output_has_odm_combine_segments: check if connector has dsc debugfs entry
> + * @drm_fd: DRM file descriptor
> + * @connector_name: The connector's name, on which we're reading the status
> + */
> +bool igt_amd_output_has_odm_combine_segments(int drm_fd, char *connector_name)
> +{
> +	return igt_amd_output_has_debugfs(drm_fd, connector_name, DEBUGFS_ODM_COMBINE_SEG);
> +}

This helper function is the same as one line igt_amd_output_has_debugfs 
and it is only used once in patch 2. The log in patch 2 seems to explain 
its purpose quite well too.

Is there a special reason to have a new helper function? Do you expect 
the check for ODM combine SEG will change or expand?

Alex

> +
>   /**
>    * is_dp_dsc_supported: Checks if connector is DSC capable
>    * @display: A pointer to an #igt_display_t structure
> diff --git a/lib/igt_amd.h b/lib/igt_amd.h
> index 6f538a195..c05b4b730 100644
> --- a/lib/igt_amd.h
> +++ b/lib/igt_amd.h
> @@ -54,6 +54,9 @@
>   #define DEBUGFS_DM_VISUAL_CONFIRM "amdgpu_dm_visual_confirm"
>   #define DEBUGFS_DM_CAPABILITIES "amdgpu_dm_capabilities"
>   
> +/* ODM Combine */
> +#define DEBUGFS_ODM_COMBINE_SEG "odm_combine_segments"
> +
>   enum amd_dsc_clock_force {
>   	DSC_AUTOMATIC = 0,
>   	DSC_FORCE_ON,
> @@ -197,4 +200,5 @@ int  igt_amd_get_visual_confirm(int drm_fd);
>   bool igt_amd_set_visual_confirm(int drm_fd, enum amdgpu_debug_visual_confirm option);
>   
>   bool igt_amd_is_mall_capable(int drm_fd);
> +bool igt_amd_output_has_odm_combine_segments(int drm_fd, char *connector_name);
>   #endif /* IGT_AMD_H */