Re: [igt-dev] [PATCH v2 1/2] lib/amdgpu: Add check for ODM combine segments debugfs endpoint

[Aurabindo Pillai <aurabindo.pillai@amd.com>]

On 2023-08-18 17:02, Alex Hung wrote:
> 
> 
> On 2023-08-18 11:56, Aurabindo Pillai wrote:
>> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
>> ---
>>   lib/igt_amd.c | 10 ++++++++++
>>   lib/igt_amd.h |  4 ++++
>>   2 files changed, 14 insertions(+)
>>
>> diff --git a/lib/igt_amd.c b/lib/igt_amd.c
>> index 83011e8ca..1a720ff56 100644
>> --- a/lib/igt_amd.c
>> +++ b/lib/igt_amd.c
>> @@ -325,6 +325,16 @@ static bool igt_amd_output_has_dsc(int drm_fd, 
>> char *connector_name)
>>       return igt_amd_output_has_debugfs(drm_fd, connector_name, 
>> DEBUGFS_DSC_CLOCK_EN);
>>   }
>> +/**
>> + * igt_amd_output_has_odm_combine_segments: check if connector has 
>> dsc debugfs entry
>> + * @drm_fd: DRM file descriptor
>> + * @connector_name: The connector's name, on which we're reading the 
>> status
>> + */
>> +bool igt_amd_output_has_odm_combine_segments(int drm_fd, char 
>> *connector_name)
>> +{
>> +    return igt_amd_output_has_debugfs(drm_fd, connector_name, 
>> DEBUGFS_ODM_COMBINE_SEG);
>> +}
> 
> This helper function is the same as one line igt_amd_output_has_debugfs 
> and it is only used once in patch 2. The log in patch 2 seems to explain 
> its purpose quite well too.
> 
> Is there a special reason to have a new helper function? Do you expect 
> the check for ODM combine SEG will change or expand?

No special reason, can be dropped. I can use 
igt_amd_output_has_debugfs() in the code, and drop this patch before I 
apply.

--

Thanks & Regards,
Jay