* [igt-dev] [PATCH 0/2] tests/i915/kms_draw_crc: Test Cleanup
@ 2022-08-04 3:40 Nidhi Gupta
2022-08-04 3:40 ` [igt-dev] [PATCH 1/2] tests/i915/kms_draw_crc: Convert tests to dynamic Nidhi Gupta
` (7 more replies)
0 siblings, 8 replies; 27+ messages in thread
From: Nidhi Gupta @ 2022-08-04 3:40 UTC (permalink / raw)
To: igt-dev; +Cc: Nidhi Gupta
Convert all possible subtests to dynamic and replace drm function
call with existing library functions.
Nidhi Gupta (2):
tests/i915/kms_draw_crc: Convert tests to dynamic
tests/i915/kms_draw_crc: Test Cleanup
tests/i915/kms_draw_crc.c | 127 ++++++++++++++++++--------------------
1 file changed, 61 insertions(+), 66 deletions(-)
--
2.36.0
^ permalink raw reply [flat|nested] 27+ messages in thread* [igt-dev] [PATCH 1/2] tests/i915/kms_draw_crc: Convert tests to dynamic 2022-08-04 3:40 [igt-dev] [PATCH 0/2] tests/i915/kms_draw_crc: Test Cleanup Nidhi Gupta @ 2022-08-04 3:40 ` Nidhi Gupta 2022-08-18 14:55 ` Juha-Pekka Heikkila 2022-08-04 3:40 ` [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup Nidhi Gupta ` (6 subsequent siblings) 7 siblings, 1 reply; 27+ messages in thread From: Nidhi Gupta @ 2022-08-04 3:40 UTC (permalink / raw) To: igt-dev; +Cc: Nidhi Gupta Convert the existing subtests to dynamic subtests. v2: check all per-requisites before starting dynamic tests, since to avoid skip in igt_dynamic(). (Bhanu) Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com> Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com> --- tests/i915/kms_draw_crc.c | 54 ++++++++++++++++++++++++--------------- 1 file changed, 33 insertions(+), 21 deletions(-) diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c index 33fefed4..48c7d931 100644 --- a/tests/i915/kms_draw_crc.c +++ b/tests/i915/kms_draw_crc.c @@ -177,15 +177,6 @@ static void draw_method_subtest(enum igt_draw_method method, { igt_crc_t crc; - igt_skip_on(modifier == I915_FORMAT_MOD_4_TILED && - !HAS_4TILE(intel_get_drm_devid(drm_fd))); - - igt_skip_on(method == IGT_DRAW_MMAP_WC && !gem_mmap__has_wc(drm_fd)); - igt_skip_on(method == IGT_DRAW_MMAP_GTT && - !gem_has_mappable_ggtt(drm_fd)); - - igt_require(format_is_supported(formats[format_index], modifier)); - /* Use IGT_DRAW_MMAP_GTT/WC on an untiled buffer as the parameter for * comparison. Cache the value so we don't recompute it for every single * subtest. */ @@ -331,22 +322,43 @@ igt_main { enum igt_draw_method method; int format_idx, modifier_idx; + uint64_t modifier; igt_fixture setup_environment(); - for (format_idx = 0; format_idx < ARRAY_SIZE(formats); format_idx++) { - for (method = 0; method < IGT_DRAW_METHOD_COUNT; method++) { - for (modifier_idx = 0; modifier_idx < ARRAY_SIZE(modifiers); modifier_idx++) { - igt_describe("This subtest verfies igt_draw library works " - "with different modifiers, DRM_FORMATS, DRAW_METHODS."); - igt_subtest_f("draw-method-%s-%s-%s", - format_str(format_idx), - igt_draw_get_method_name(method), - modifier_str(modifier_idx)) - draw_method_subtest(method, format_idx, - modifiers[modifier_idx]); - } } } + igt_describe("This subtest verfies igt_draw library works " + "with different modifiers, DRM_FORMATS, DRAW_METHODS."); + igt_subtest_with_dynamic("draw-method") { + for (format_idx = 0; format_idx < ARRAY_SIZE(formats); format_idx++) { + for (method = 0; method < IGT_DRAW_METHOD_COUNT; method++) { + for (modifier_idx = 0; modifier_idx < ARRAY_SIZE(modifiers); modifier_idx++) { + modifier = modifiers[modifier_idx]; + + if (modifier == I915_FORMAT_MOD_4_TILED && + !HAS_4TILE(intel_get_drm_devid(drm_fd))) + continue; + + if (method == IGT_DRAW_MMAP_WC && !gem_mmap__has_wc(drm_fd)) + continue; + + if (method == IGT_DRAW_MMAP_GTT && + !gem_has_mappable_ggtt(drm_fd)) + continue; + + if (!format_is_supported(formats[format_idx], modifier)) + continue; + + igt_dynamic_f("%s-%s-%s", + format_str(format_idx), + igt_draw_get_method_name(method), + modifier_str(modifier_idx)) + draw_method_subtest(method, format_idx, + modifier); + } + } + } + } igt_describe("This subtest verifies CRC after filling fb with x-tiling " "or none."); -- 2.36.0 ^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [igt-dev] [PATCH 1/2] tests/i915/kms_draw_crc: Convert tests to dynamic 2022-08-04 3:40 ` [igt-dev] [PATCH 1/2] tests/i915/kms_draw_crc: Convert tests to dynamic Nidhi Gupta @ 2022-08-18 14:55 ` Juha-Pekka Heikkila 0 siblings, 0 replies; 27+ messages in thread From: Juha-Pekka Heikkila @ 2022-08-18 14:55 UTC (permalink / raw) To: Nidhi Gupta, igt-dev Hi Nidhi, I noticed this was not yet merged, there's one comment below. On 4.8.2022 6.40, Nidhi Gupta wrote: > Convert the existing subtests to dynamic subtests. > > v2: check all per-requisites before starting dynamic > tests, since to avoid skip in igt_dynamic(). > (Bhanu) > > Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com> > Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com> > --- > tests/i915/kms_draw_crc.c | 54 ++++++++++++++++++++++++--------------- > 1 file changed, 33 insertions(+), 21 deletions(-) > > diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c > index 33fefed4..48c7d931 100644 > --- a/tests/i915/kms_draw_crc.c > +++ b/tests/i915/kms_draw_crc.c > @@ -177,15 +177,6 @@ static void draw_method_subtest(enum igt_draw_method method, > { > igt_crc_t crc; > > - igt_skip_on(modifier == I915_FORMAT_MOD_4_TILED && > - !HAS_4TILE(intel_get_drm_devid(drm_fd))); > - > - igt_skip_on(method == IGT_DRAW_MMAP_WC && !gem_mmap__has_wc(drm_fd)); > - igt_skip_on(method == IGT_DRAW_MMAP_GTT && > - !gem_has_mappable_ggtt(drm_fd)); > - > - igt_require(format_is_supported(formats[format_index], modifier)); > - > /* Use IGT_DRAW_MMAP_GTT/WC on an untiled buffer as the parameter for > * comparison. Cache the value so we don't recompute it for every single > * subtest. */ > @@ -331,22 +322,43 @@ igt_main > { > enum igt_draw_method method; > int format_idx, modifier_idx; > + uint64_t modifier; > > igt_fixture > setup_environment(); > > - for (format_idx = 0; format_idx < ARRAY_SIZE(formats); format_idx++) { > - for (method = 0; method < IGT_DRAW_METHOD_COUNT; method++) { > - for (modifier_idx = 0; modifier_idx < ARRAY_SIZE(modifiers); modifier_idx++) { > - igt_describe("This subtest verfies igt_draw library works " > - "with different modifiers, DRM_FORMATS, DRAW_METHODS."); > - igt_subtest_f("draw-method-%s-%s-%s", > - format_str(format_idx), > - igt_draw_get_method_name(method), > - modifier_str(modifier_idx)) > - draw_method_subtest(method, format_idx, > - modifiers[modifier_idx]); > - } } } > + igt_describe("This subtest verfies igt_draw library works " > + "with different modifiers, DRM_FORMATS, DRAW_METHODS."); > + igt_subtest_with_dynamic("draw-method") { > + for (format_idx = 0; format_idx < ARRAY_SIZE(formats); format_idx++) { > + for (method = 0; method < IGT_DRAW_METHOD_COUNT; method++) { > + for (modifier_idx = 0; modifier_idx < ARRAY_SIZE(modifiers); modifier_idx++) { > + modifier = modifiers[modifier_idx]; > + > + if (modifier == I915_FORMAT_MOD_4_TILED && > + !HAS_4TILE(intel_get_drm_devid(drm_fd))) > + continue; I think above check for I915_FORMAT_MOD_4_TILED can be removed since just below there's check for format_is_supported(..) which you change in later patch for igt_display_has_format_mod(..) > + > + if (method == IGT_DRAW_MMAP_WC && !gem_mmap__has_wc(drm_fd)) > + continue; > + > + if (method == IGT_DRAW_MMAP_GTT && > + !gem_has_mappable_ggtt(drm_fd)) > + continue; > + > + if (!format_is_supported(formats[format_idx], modifier)) > + continue; > + > + igt_dynamic_f("%s-%s-%s", > + format_str(format_idx), > + igt_draw_get_method_name(method), > + modifier_str(modifier_idx)) > + draw_method_subtest(method, format_idx, > + modifier); > + } > + } > + } > + } > > igt_describe("This subtest verifies CRC after filling fb with x-tiling " > "or none."); ^ permalink raw reply [flat|nested] 27+ messages in thread
* [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup 2022-08-04 3:40 [igt-dev] [PATCH 0/2] tests/i915/kms_draw_crc: Test Cleanup Nidhi Gupta 2022-08-04 3:40 ` [igt-dev] [PATCH 1/2] tests/i915/kms_draw_crc: Convert tests to dynamic Nidhi Gupta @ 2022-08-04 3:40 ` Nidhi Gupta 2022-08-08 11:16 ` Gupta, Nidhi1 ` (4 more replies) 2022-08-04 4:23 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/i915/kms_draw_crc: Test Cleanup (rev4) Patchwork ` (5 subsequent siblings) 7 siblings, 5 replies; 27+ messages in thread From: Nidhi Gupta @ 2022-08-04 3:40 UTC (permalink / raw) To: igt-dev; +Cc: Nidhi Gupta v2: -Replace drm function call with existing library functions (Bhanu) v3: -Replace PIPE_A with compatible pipe/output combo. (Bhanu) v4: -use for_each_pipe_with_single_output() for finding compatible pipe/ouput combo. -remove crtc_id as not used anywhere. -set fb to primary plane before commiting. (Bhanu) Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com> --- tests/i915/kms_draw_crc.c | 73 +++++++++++++++------------------------ 1 file changed, 28 insertions(+), 45 deletions(-) diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c index 48c7d931..c7354df9 100644 --- a/tests/i915/kms_draw_crc.c +++ b/tests/i915/kms_draw_crc.c @@ -31,12 +31,12 @@ struct modeset_params { uint32_t crtc_id; - uint32_t connector_id; drmModeModeInfoPtr mode; }; int drm_fd; -drmModeResPtr drm_res; +igt_display_t display; +igt_output_t *output; drmModeConnectorPtr drm_connectors[MAX_CONNECTORS]; struct buf_ops *bops; igt_pipe_crc_t *pipe_crc; @@ -64,30 +64,25 @@ struct modeset_params ms; static void find_modeset_params(void) { - int i; - uint32_t crtc_id; - drmModeConnectorPtr connector = NULL; - drmModeModeInfoPtr mode = NULL; - - for (i = 0; i < drm_res->count_connectors; i++) { - drmModeConnectorPtr c = drm_connectors[i]; + enum pipe pipe1; + drmModeModeInfo *mode; - if (c->count_modes) { - connector = c; - mode = &c->modes[0]; - break; - } - } - igt_require(connector); + igt_display_reset(&display); + igt_display_commit(&display); - crtc_id = kmstest_find_crtc_for_connector(drm_fd, drm_res, connector, - 0); - igt_assert(mode); + for_each_pipe_with_single_output(&display, pipe1, output) { + output = igt_get_single_output_for_pipe(&display, pipe1); + igt_require(output); + igt_output_set_pipe(output, pipe1); - ms.connector_id = connector->connector_id; - ms.crtc_id = crtc_id; - ms.mode = mode; + mode = igt_output_get_mode(output); + igt_assert(mode); + ms.mode = mode; + pipe_crc = igt_pipe_crc_new(drm_fd, pipe1, INTEL_PIPE_CRC_SOURCE_AUTO); + /*Only one pipe/output is enough*/ + break; + } } static uint32_t get_color(uint32_t drm_format, bool r, bool g, bool b) @@ -122,9 +117,14 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, { struct igt_fb fb; int rc; + igt_plane_t *primary; + + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, drm_format, modifier, &fb); + igt_plane_set_fb(primary, &fb); + igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 0, 0, fb.width, fb.height, get_color(drm_format, 0, 0, 1)); @@ -144,8 +144,7 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 1, 1, 15, 15, get_color(drm_format, 0, 1, 1)); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, crc); @@ -203,8 +202,7 @@ static void get_fill_crc(uint64_t modifier, igt_crc_t *crc) igt_draw_fill_fb(drm_fd, &fb, 0xFF); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, crc); @@ -227,8 +225,7 @@ static void fill_fb_subtest(void) IGT_DRAW_MMAP_WC, 0, 0, fb.width, fb.height, 0xFF); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, &base_crc); @@ -251,40 +248,26 @@ static void fill_fb_subtest(void) static void setup_environment(void) { - int i; - drm_fd = drm_open_driver_master(DRIVER_INTEL); igt_require(drm_fd >= 0); - - drm_res = drmModeGetResources(drm_fd); - igt_require(drm_res); - igt_assert(drm_res->count_connectors <= MAX_CONNECTORS); - - for (i = 0; i < drm_res->count_connectors; i++) - drm_connectors[i] = drmModeGetConnectorCurrent(drm_fd, - drm_res->connectors[i]); + igt_display_require(&display, drm_fd); + igt_display_require_output(&display); kmstest_set_vt_graphics_mode(); bops = buf_ops_create(drm_fd); find_modeset_params(); - pipe_crc = igt_pipe_crc_new(drm_fd, kmstest_get_crtc_idx(drm_res, ms.crtc_id), - INTEL_PIPE_CRC_SOURCE_AUTO); } static void teardown_environment(void) { - int i; - igt_pipe_crc_free(pipe_crc); buf_ops_destroy(bops); - for (i = 0; i < drm_res->count_connectors; i++) - drmModeFreeConnector(drm_connectors[i]); + igt_display_reset(&display); - drmModeFreeResources(drm_res); close(drm_fd); } -- 2.36.0 ^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup 2022-08-04 3:40 ` [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup Nidhi Gupta @ 2022-08-08 11:16 ` Gupta, Nidhi1 2022-08-08 14:02 ` Modem, Bhanuprakash 2022-08-09 8:00 ` Modem, Bhanuprakash ` (3 subsequent siblings) 4 siblings, 1 reply; 27+ messages in thread From: Gupta, Nidhi1 @ 2022-08-08 11:16 UTC (permalink / raw) To: igt-dev@lists.freedesktop.org Hi Bhanu, If you could review the below patch it would be helpful. Thanks Nidhi. -----Original Message----- From: Gupta, Nidhi1 <nidhi1.gupta@intel.com> Sent: Thursday, August 4, 2022 9:10 AM To: igt-dev@lists.freedesktop.org Cc: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; Gupta, Nidhi1 <nidhi1.gupta@intel.com> Subject: [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup v2: -Replace drm function call with existing library functions (Bhanu) v3: -Replace PIPE_A with compatible pipe/output combo. (Bhanu) v4: -use for_each_pipe_with_single_output() for finding compatible pipe/ouput combo. -remove crtc_id as not used anywhere. -set fb to primary plane before commiting. (Bhanu) Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com> --- tests/i915/kms_draw_crc.c | 73 +++++++++++++++------------------------ 1 file changed, 28 insertions(+), 45 deletions(-) diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c index 48c7d931..c7354df9 100644 --- a/tests/i915/kms_draw_crc.c +++ b/tests/i915/kms_draw_crc.c @@ -31,12 +31,12 @@ struct modeset_params { uint32_t crtc_id; - uint32_t connector_id; drmModeModeInfoPtr mode; }; int drm_fd; -drmModeResPtr drm_res; +igt_display_t display; +igt_output_t *output; drmModeConnectorPtr drm_connectors[MAX_CONNECTORS]; struct buf_ops *bops; igt_pipe_crc_t *pipe_crc; @@ -64,30 +64,25 @@ struct modeset_params ms; static void find_modeset_params(void) { - int i; - uint32_t crtc_id; - drmModeConnectorPtr connector = NULL; - drmModeModeInfoPtr mode = NULL; - - for (i = 0; i < drm_res->count_connectors; i++) { - drmModeConnectorPtr c = drm_connectors[i]; + enum pipe pipe1; + drmModeModeInfo *mode; - if (c->count_modes) { - connector = c; - mode = &c->modes[0]; - break; - } - } - igt_require(connector); + igt_display_reset(&display); + igt_display_commit(&display); - crtc_id = kmstest_find_crtc_for_connector(drm_fd, drm_res, connector, - 0); - igt_assert(mode); + for_each_pipe_with_single_output(&display, pipe1, output) { + output = igt_get_single_output_for_pipe(&display, pipe1); + igt_require(output); + igt_output_set_pipe(output, pipe1); - ms.connector_id = connector->connector_id; - ms.crtc_id = crtc_id; - ms.mode = mode; + mode = igt_output_get_mode(output); + igt_assert(mode); + ms.mode = mode; + pipe_crc = igt_pipe_crc_new(drm_fd, pipe1, INTEL_PIPE_CRC_SOURCE_AUTO); + /*Only one pipe/output is enough*/ + break; + } } static uint32_t get_color(uint32_t drm_format, bool r, bool g, bool b) @@ -122,9 +117,14 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, { struct igt_fb fb; int rc; + igt_plane_t *primary; + + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, drm_format, modifier, &fb); + igt_plane_set_fb(primary, &fb); + igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 0, 0, fb.width, fb.height, get_color(drm_format, 0, 0, 1)); @@ -144,8 +144,7 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 1, 1, 15, 15, get_color(drm_format, 0, 1, 1)); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : +COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, crc); @@ -203,8 +202,7 @@ static void get_fill_crc(uint64_t modifier, igt_crc_t *crc) igt_draw_fill_fb(drm_fd, &fb, 0xFF); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : +COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, crc); @@ -227,8 +225,7 @@ static void fill_fb_subtest(void) IGT_DRAW_MMAP_WC, 0, 0, fb.width, fb.height, 0xFF); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : +COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, &base_crc); @@ -251,40 +248,26 @@ static void fill_fb_subtest(void) static void setup_environment(void) { - int i; - drm_fd = drm_open_driver_master(DRIVER_INTEL); igt_require(drm_fd >= 0); - - drm_res = drmModeGetResources(drm_fd); - igt_require(drm_res); - igt_assert(drm_res->count_connectors <= MAX_CONNECTORS); - - for (i = 0; i < drm_res->count_connectors; i++) - drm_connectors[i] = drmModeGetConnectorCurrent(drm_fd, - drm_res->connectors[i]); + igt_display_require(&display, drm_fd); + igt_display_require_output(&display); kmstest_set_vt_graphics_mode(); bops = buf_ops_create(drm_fd); find_modeset_params(); - pipe_crc = igt_pipe_crc_new(drm_fd, kmstest_get_crtc_idx(drm_res, ms.crtc_id), - INTEL_PIPE_CRC_SOURCE_AUTO); } static void teardown_environment(void) { - int i; - igt_pipe_crc_free(pipe_crc); buf_ops_destroy(bops); - for (i = 0; i < drm_res->count_connectors; i++) - drmModeFreeConnector(drm_connectors[i]); + igt_display_reset(&display); - drmModeFreeResources(drm_res); close(drm_fd); } -- 2.36.0 ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup 2022-08-08 11:16 ` Gupta, Nidhi1 @ 2022-08-08 14:02 ` Modem, Bhanuprakash 0 siblings, 0 replies; 27+ messages in thread From: Modem, Bhanuprakash @ 2022-08-08 14:02 UTC (permalink / raw) To: Gupta, Nidhi1, igt-dev@lists.freedesktop.org Hi Nidhi, Sure, I'll try to do it by tomorrow. BTW, did you visually verified this patch locally? Thanks, Bhanu > -----Original Message----- > From: Gupta, Nidhi1 <nidhi1.gupta@intel.com> > Sent: Monday, August 8, 2022 4:46 PM > To: igt-dev@lists.freedesktop.org > Cc: Modem, Bhanuprakash <bhanuprakash.modem@intel.com> > Subject: RE: [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup > > Hi Bhanu, > > If you could review the below patch it would be helpful. > > Thanks > Nidhi. > > -----Original Message----- > From: Gupta, Nidhi1 <nidhi1.gupta@intel.com> > Sent: Thursday, August 4, 2022 9:10 AM > To: igt-dev@lists.freedesktop.org > Cc: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; Gupta, Nidhi1 > <nidhi1.gupta@intel.com> > Subject: [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup > > v2: -Replace drm function call with existing library functions > (Bhanu) > > v3: -Replace PIPE_A with compatible pipe/output combo. > (Bhanu) > > v4: -use for_each_pipe_with_single_output() for finding > compatible pipe/ouput combo. > -remove crtc_id as not used anywhere. > -set fb to primary plane before commiting. > (Bhanu) > > Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com> > --- > tests/i915/kms_draw_crc.c | 73 +++++++++++++++------------------------ > 1 file changed, 28 insertions(+), 45 deletions(-) > > diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c index > 48c7d931..c7354df9 100644 > --- a/tests/i915/kms_draw_crc.c > +++ b/tests/i915/kms_draw_crc.c > @@ -31,12 +31,12 @@ > > struct modeset_params { > uint32_t crtc_id; > - uint32_t connector_id; > drmModeModeInfoPtr mode; > }; > > int drm_fd; > -drmModeResPtr drm_res; > +igt_display_t display; > +igt_output_t *output; > drmModeConnectorPtr drm_connectors[MAX_CONNECTORS]; struct buf_ops *bops; > igt_pipe_crc_t *pipe_crc; @@ -64,30 +64,25 @@ struct modeset_params ms; > > static void find_modeset_params(void) > { > - int i; > - uint32_t crtc_id; > - drmModeConnectorPtr connector = NULL; > - drmModeModeInfoPtr mode = NULL; > - > - for (i = 0; i < drm_res->count_connectors; i++) { > - drmModeConnectorPtr c = drm_connectors[i]; > + enum pipe pipe1; > + drmModeModeInfo *mode; > > - if (c->count_modes) { > - connector = c; > - mode = &c->modes[0]; > - break; > - } > - } > - igt_require(connector); > + igt_display_reset(&display); > + igt_display_commit(&display); > > - crtc_id = kmstest_find_crtc_for_connector(drm_fd, drm_res, connector, > - 0); > - igt_assert(mode); > + for_each_pipe_with_single_output(&display, pipe1, output) { > + output = igt_get_single_output_for_pipe(&display, pipe1); > + igt_require(output); > + igt_output_set_pipe(output, pipe1); > > - ms.connector_id = connector->connector_id; > - ms.crtc_id = crtc_id; > - ms.mode = mode; > + mode = igt_output_get_mode(output); > + igt_assert(mode); > > + ms.mode = mode; > + pipe_crc = igt_pipe_crc_new(drm_fd, pipe1, > INTEL_PIPE_CRC_SOURCE_AUTO); > + /*Only one pipe/output is enough*/ > + break; > + } > } > > static uint32_t get_color(uint32_t drm_format, bool r, bool g, bool b) @@ - > 122,9 +117,14 @@ static void get_method_crc(enum igt_draw_method method, > uint32_t drm_format, { > struct igt_fb fb; > int rc; > + igt_plane_t *primary; > + > + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); > > igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, > drm_format, modifier, &fb); > + igt_plane_set_fb(primary, &fb); > + > igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, > 0, 0, fb.width, fb.height, > get_color(drm_format, 0, 0, 1)); > @@ -144,8 +144,7 @@ static void get_method_crc(enum igt_draw_method method, > uint32_t drm_format, > igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 1, 1, 15, 15, > get_color(drm_format, 0, 1, 1)); > > - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, > - &ms.connector_id, 1, ms.mode); > + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : > +COMMIT_LEGACY); > igt_assert_eq(rc, 0); > > igt_pipe_crc_collect_crc(pipe_crc, crc); @@ -203,8 +202,7 @@ static void > get_fill_crc(uint64_t modifier, igt_crc_t *crc) > > igt_draw_fill_fb(drm_fd, &fb, 0xFF); > > - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, > - &ms.connector_id, 1, ms.mode); > + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : > +COMMIT_LEGACY); > igt_assert_eq(rc, 0); > > igt_pipe_crc_collect_crc(pipe_crc, crc); @@ -227,8 +225,7 @@ static void > fill_fb_subtest(void) > IGT_DRAW_MMAP_WC, > 0, 0, fb.width, fb.height, 0xFF); > > - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, > - &ms.connector_id, 1, ms.mode); > + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : > +COMMIT_LEGACY); > igt_assert_eq(rc, 0); > > igt_pipe_crc_collect_crc(pipe_crc, &base_crc); @@ -251,40 +248,26 @@ > static void fill_fb_subtest(void) > > static void setup_environment(void) > { > - int i; > - > drm_fd = drm_open_driver_master(DRIVER_INTEL); > igt_require(drm_fd >= 0); > - > - drm_res = drmModeGetResources(drm_fd); > - igt_require(drm_res); > - igt_assert(drm_res->count_connectors <= MAX_CONNECTORS); > - > - for (i = 0; i < drm_res->count_connectors; i++) > - drm_connectors[i] = drmModeGetConnectorCurrent(drm_fd, > - drm_res->connectors[i]); > + igt_display_require(&display, drm_fd); > + igt_display_require_output(&display); > > kmstest_set_vt_graphics_mode(); > > bops = buf_ops_create(drm_fd); > > find_modeset_params(); > - pipe_crc = igt_pipe_crc_new(drm_fd, kmstest_get_crtc_idx(drm_res, > ms.crtc_id), > - INTEL_PIPE_CRC_SOURCE_AUTO); > } > > static void teardown_environment(void) > { > - int i; > - > igt_pipe_crc_free(pipe_crc); > > buf_ops_destroy(bops); > > - for (i = 0; i < drm_res->count_connectors; i++) > - drmModeFreeConnector(drm_connectors[i]); > + igt_display_reset(&display); > > - drmModeFreeResources(drm_res); > close(drm_fd); > } > > -- > 2.36.0 ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup 2022-08-04 3:40 ` [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup Nidhi Gupta 2022-08-08 11:16 ` Gupta, Nidhi1 @ 2022-08-09 8:00 ` Modem, Bhanuprakash 2022-08-09 9:08 ` Modem, Bhanuprakash ` (2 subsequent siblings) 4 siblings, 0 replies; 27+ messages in thread From: Modem, Bhanuprakash @ 2022-08-09 8:00 UTC (permalink / raw) To: Nidhi Gupta, igt-dev On Thu-04-08-2022 09:10 am, Nidhi Gupta wrote: > v2: -Replace drm function call with existing library functions > (Bhanu) > > v3: -Replace PIPE_A with compatible pipe/output combo. > (Bhanu) > > v4: -use for_each_pipe_with_single_output() for finding > compatible pipe/ouput combo. > -remove crtc_id as not used anywhere. > -set fb to primary plane before commiting. > (Bhanu) > > Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com> > --- > tests/i915/kms_draw_crc.c | 73 +++++++++++++++------------------------ > 1 file changed, 28 insertions(+), 45 deletions(-) > > diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c > index 48c7d931..c7354df9 100644 > --- a/tests/i915/kms_draw_crc.c > +++ b/tests/i915/kms_draw_crc.c > @@ -31,12 +31,12 @@ > > struct modeset_params { > uint32_t crtc_id; > - uint32_t connector_id; > drmModeModeInfoPtr mode; > }; This entire structure is not required, only mode is enough. > > int drm_fd; > -drmModeResPtr drm_res; > +igt_display_t display; > +igt_output_t *output; > drmModeConnectorPtr drm_connectors[MAX_CONNECTORS]; Unused variable, please drop it. > struct buf_ops *bops; > igt_pipe_crc_t *pipe_crc; > @@ -64,30 +64,25 @@ struct modeset_params ms; > > static void find_modeset_params(void) > { > - int i; > - uint32_t crtc_id; > - drmModeConnectorPtr connector = NULL; > - drmModeModeInfoPtr mode = NULL; > - > - for (i = 0; i < drm_res->count_connectors; i++) { > - drmModeConnectorPtr c = drm_connectors[i]; > + enum pipe pipe1; s/pipe1/pipe/ > + drmModeModeInfo *mode; > > - if (c->count_modes) { > - connector = c; > - mode = &c->modes[0]; > - break; > - } > - } > - igt_require(connector); > + igt_display_reset(&display); > + igt_display_commit(&display); > > - crtc_id = kmstest_find_crtc_for_connector(drm_fd, drm_res, connector, > - 0); > - igt_assert(mode); > + for_each_pipe_with_single_output(&display, pipe1, output) { > + output = igt_get_single_output_for_pipe(&display, pipe1); > + igt_require(output); These 2 lines are redundant, please drop those. You can directly use output. > + igt_output_set_pipe(output, pipe1); > > - ms.connector_id = connector->connector_id; > - ms.crtc_id = crtc_id; > - ms.mode = mode; > + mode = igt_output_get_mode(output); > + igt_assert(mode); hmm, Instead of asserting, how about trying with another output? for_each_pipe_with_valid_output() { if (!mode) continue; } igt_require(mode); > > + ms.mode = mode; Please update this as per the first comment in this patch. > + pipe_crc = igt_pipe_crc_new(drm_fd, pipe1, INTEL_PIPE_CRC_SOURCE_AUTO); > + /*Only one pipe/output is enough*/ > + break; > + } > } > > static uint32_t get_color(uint32_t drm_format, bool r, bool g, bool b) > @@ -122,9 +117,14 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, > { > struct igt_fb fb; > int rc; > + igt_plane_t *primary; > + > + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); We need similar logic to "fill_fb_subtest()" too. - Bhanu > > igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, > drm_format, modifier, &fb); > + igt_plane_set_fb(primary, &fb); > + > igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, > 0, 0, fb.width, fb.height, > get_color(drm_format, 0, 0, 1)); > @@ -144,8 +144,7 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, > igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 1, 1, 15, 15, > get_color(drm_format, 0, 1, 1)); > > - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, > - &ms.connector_id, 1, ms.mode); > + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); > igt_assert_eq(rc, 0); > > igt_pipe_crc_collect_crc(pipe_crc, crc); > @@ -203,8 +202,7 @@ static void get_fill_crc(uint64_t modifier, igt_crc_t *crc) > > igt_draw_fill_fb(drm_fd, &fb, 0xFF); > > - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, > - &ms.connector_id, 1, ms.mode); > + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); > igt_assert_eq(rc, 0); > > igt_pipe_crc_collect_crc(pipe_crc, crc); > @@ -227,8 +225,7 @@ static void fill_fb_subtest(void) > IGT_DRAW_MMAP_WC, > 0, 0, fb.width, fb.height, 0xFF); > > - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, > - &ms.connector_id, 1, ms.mode); > + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); > igt_assert_eq(rc, 0); > > igt_pipe_crc_collect_crc(pipe_crc, &base_crc); > @@ -251,40 +248,26 @@ static void fill_fb_subtest(void) > > static void setup_environment(void) > { > - int i; > - > drm_fd = drm_open_driver_master(DRIVER_INTEL); > igt_require(drm_fd >= 0); > - > - drm_res = drmModeGetResources(drm_fd); > - igt_require(drm_res); > - igt_assert(drm_res->count_connectors <= MAX_CONNECTORS); > - > - for (i = 0; i < drm_res->count_connectors; i++) > - drm_connectors[i] = drmModeGetConnectorCurrent(drm_fd, > - drm_res->connectors[i]); > + igt_display_require(&display, drm_fd); > + igt_display_require_output(&display); > > kmstest_set_vt_graphics_mode(); > > bops = buf_ops_create(drm_fd); > > find_modeset_params(); > - pipe_crc = igt_pipe_crc_new(drm_fd, kmstest_get_crtc_idx(drm_res, ms.crtc_id), > - INTEL_PIPE_CRC_SOURCE_AUTO); > } > > static void teardown_environment(void) > { > - int i; > - > igt_pipe_crc_free(pipe_crc); > > buf_ops_destroy(bops); > > - for (i = 0; i < drm_res->count_connectors; i++) > - drmModeFreeConnector(drm_connectors[i]); > + igt_display_reset(&display); > > - drmModeFreeResources(drm_res); > close(drm_fd); > } > ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup 2022-08-04 3:40 ` [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup Nidhi Gupta 2022-08-08 11:16 ` Gupta, Nidhi1 2022-08-09 8:00 ` Modem, Bhanuprakash @ 2022-08-09 9:08 ` Modem, Bhanuprakash 2022-08-09 12:53 ` Juha-Pekka Heikkila 2022-08-10 10:11 ` Nidhi Gupta 4 siblings, 0 replies; 27+ messages in thread From: Modem, Bhanuprakash @ 2022-08-09 9:08 UTC (permalink / raw) To: Nidhi Gupta, igt-dev On Thu-04-08-2022 09:10 am, Nidhi Gupta wrote: > v2: -Replace drm function call with existing library functions > (Bhanu) > > v3: -Replace PIPE_A with compatible pipe/output combo. > (Bhanu) > > v4: -use for_each_pipe_with_single_output() for finding > compatible pipe/ouput combo. > -remove crtc_id as not used anywhere. > -set fb to primary plane before commiting. > (Bhanu) > Also, is it possible to use existing IGT lib helper "igt_display_has_format_mod()" instead of "format_is_supported()"? - Bhanu > Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com> > --- > tests/i915/kms_draw_crc.c | 73 +++++++++++++++------------------------ > 1 file changed, 28 insertions(+), 45 deletions(-) > > diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c > index 48c7d931..c7354df9 100644 > --- a/tests/i915/kms_draw_crc.c > +++ b/tests/i915/kms_draw_crc.c > @@ -31,12 +31,12 @@ > > struct modeset_params { > uint32_t crtc_id; > - uint32_t connector_id; > drmModeModeInfoPtr mode; > }; > > int drm_fd; > -drmModeResPtr drm_res; > +igt_display_t display; > +igt_output_t *output; > drmModeConnectorPtr drm_connectors[MAX_CONNECTORS]; > struct buf_ops *bops; > igt_pipe_crc_t *pipe_crc; > @@ -64,30 +64,25 @@ struct modeset_params ms; > > static void find_modeset_params(void) > { > - int i; > - uint32_t crtc_id; > - drmModeConnectorPtr connector = NULL; > - drmModeModeInfoPtr mode = NULL; > - > - for (i = 0; i < drm_res->count_connectors; i++) { > - drmModeConnectorPtr c = drm_connectors[i]; > + enum pipe pipe1; > + drmModeModeInfo *mode; > > - if (c->count_modes) { > - connector = c; > - mode = &c->modes[0]; > - break; > - } > - } > - igt_require(connector); > + igt_display_reset(&display); > + igt_display_commit(&display); > > - crtc_id = kmstest_find_crtc_for_connector(drm_fd, drm_res, connector, > - 0); > - igt_assert(mode); > + for_each_pipe_with_single_output(&display, pipe1, output) { > + output = igt_get_single_output_for_pipe(&display, pipe1); > + igt_require(output); > + igt_output_set_pipe(output, pipe1); > > - ms.connector_id = connector->connector_id; > - ms.crtc_id = crtc_id; > - ms.mode = mode; > + mode = igt_output_get_mode(output); > + igt_assert(mode); > > + ms.mode = mode; > + pipe_crc = igt_pipe_crc_new(drm_fd, pipe1, INTEL_PIPE_CRC_SOURCE_AUTO); > + /*Only one pipe/output is enough*/ > + break; > + } > } > > static uint32_t get_color(uint32_t drm_format, bool r, bool g, bool b) > @@ -122,9 +117,14 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, > { > struct igt_fb fb; > int rc; > + igt_plane_t *primary; > + > + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); > > igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, > drm_format, modifier, &fb); > + igt_plane_set_fb(primary, &fb); > + > igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, > 0, 0, fb.width, fb.height, > get_color(drm_format, 0, 0, 1)); > @@ -144,8 +144,7 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, > igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 1, 1, 15, 15, > get_color(drm_format, 0, 1, 1)); > > - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, > - &ms.connector_id, 1, ms.mode); > + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); > igt_assert_eq(rc, 0); > > igt_pipe_crc_collect_crc(pipe_crc, crc); > @@ -203,8 +202,7 @@ static void get_fill_crc(uint64_t modifier, igt_crc_t *crc) > > igt_draw_fill_fb(drm_fd, &fb, 0xFF); > > - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, > - &ms.connector_id, 1, ms.mode); > + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); > igt_assert_eq(rc, 0); > > igt_pipe_crc_collect_crc(pipe_crc, crc); > @@ -227,8 +225,7 @@ static void fill_fb_subtest(void) > IGT_DRAW_MMAP_WC, > 0, 0, fb.width, fb.height, 0xFF); > > - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, > - &ms.connector_id, 1, ms.mode); > + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); > igt_assert_eq(rc, 0); > > igt_pipe_crc_collect_crc(pipe_crc, &base_crc); > @@ -251,40 +248,26 @@ static void fill_fb_subtest(void) > > static void setup_environment(void) > { > - int i; > - > drm_fd = drm_open_driver_master(DRIVER_INTEL); > igt_require(drm_fd >= 0); > - > - drm_res = drmModeGetResources(drm_fd); > - igt_require(drm_res); > - igt_assert(drm_res->count_connectors <= MAX_CONNECTORS); > - > - for (i = 0; i < drm_res->count_connectors; i++) > - drm_connectors[i] = drmModeGetConnectorCurrent(drm_fd, > - drm_res->connectors[i]); > + igt_display_require(&display, drm_fd); > + igt_display_require_output(&display); > > kmstest_set_vt_graphics_mode(); > > bops = buf_ops_create(drm_fd); > > find_modeset_params(); > - pipe_crc = igt_pipe_crc_new(drm_fd, kmstest_get_crtc_idx(drm_res, ms.crtc_id), > - INTEL_PIPE_CRC_SOURCE_AUTO); > } > > static void teardown_environment(void) > { > - int i; > - > igt_pipe_crc_free(pipe_crc); > > buf_ops_destroy(bops); > > - for (i = 0; i < drm_res->count_connectors; i++) > - drmModeFreeConnector(drm_connectors[i]); > + igt_display_reset(&display); > > - drmModeFreeResources(drm_res); > close(drm_fd); > } > ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup 2022-08-04 3:40 ` [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup Nidhi Gupta ` (2 preceding siblings ...) 2022-08-09 9:08 ` Modem, Bhanuprakash @ 2022-08-09 12:53 ` Juha-Pekka Heikkila 2022-08-10 10:11 ` Nidhi Gupta 4 siblings, 0 replies; 27+ messages in thread From: Juha-Pekka Heikkila @ 2022-08-09 12:53 UTC (permalink / raw) To: Nidhi Gupta, igt-dev Hi Nidhi, quickly looking I noticed few things which Bhanu didn't comment on On 4.8.2022 6.40, Nidhi Gupta wrote: > v2: -Replace drm function call with existing library functions > (Bhanu) > > v3: -Replace PIPE_A with compatible pipe/output combo. > (Bhanu) > > v4: -use for_each_pipe_with_single_output() for finding > compatible pipe/ouput combo. > -remove crtc_id as not used anywhere. > -set fb to primary plane before commiting. > (Bhanu) > > Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com> > --- > tests/i915/kms_draw_crc.c | 73 +++++++++++++++------------------------ > 1 file changed, 28 insertions(+), 45 deletions(-) > > diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c > index 48c7d931..c7354df9 100644 > --- a/tests/i915/kms_draw_crc.c > +++ b/tests/i915/kms_draw_crc.c > @@ -31,12 +31,12 @@ > > struct modeset_params { > uint32_t crtc_id; > - uint32_t connector_id; > drmModeModeInfoPtr mode; > }; > > int drm_fd; > -drmModeResPtr drm_res; > +igt_display_t display; > +igt_output_t *output; > drmModeConnectorPtr drm_connectors[MAX_CONNECTORS]; > struct buf_ops *bops; > igt_pipe_crc_t *pipe_crc; > @@ -64,30 +64,25 @@ struct modeset_params ms; > > static void find_modeset_params(void) > { > - int i; > - uint32_t crtc_id; > - drmModeConnectorPtr connector = NULL; > - drmModeModeInfoPtr mode = NULL; > - > - for (i = 0; i < drm_res->count_connectors; i++) { > - drmModeConnectorPtr c = drm_connectors[i]; > + enum pipe pipe1; > + drmModeModeInfo *mode; Here is being replaced drmModeModeInfoPtr (drmModeModeInfo pointer) called 'mode' with pointer to drmModeModeInfo which is called 'mode' > > - if (c->count_modes) { > - connector = c; > - mode = &c->modes[0]; > - break; > - } > - } > - igt_require(connector); > + igt_display_reset(&display); > + igt_display_commit(&display); > > - crtc_id = kmstest_find_crtc_for_connector(drm_fd, drm_res, connector, > - 0); > - igt_assert(mode); > + for_each_pipe_with_single_output(&display, pipe1, output) { > + output = igt_get_single_output_for_pipe(&display, pipe1); > + igt_require(output); > + igt_output_set_pipe(output, pipe1); > > - ms.connector_id = connector->connector_id; > - ms.crtc_id = crtc_id; > - ms.mode = mode; > + mode = igt_output_get_mode(output); > + igt_assert(mode); > > + ms.mode = mode; > + pipe_crc = igt_pipe_crc_new(drm_fd, pipe1, INTEL_PIPE_CRC_SOURCE_AUTO); > + /*Only one pipe/output is enough*/ > + break; > + } > } > > static uint32_t get_color(uint32_t drm_format, bool r, bool g, bool b) > @@ -122,9 +117,14 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, > { > struct igt_fb fb; > int rc; > + igt_plane_t *primary; > + > + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); > > igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, > drm_format, modifier, &fb); > + igt_plane_set_fb(primary, &fb); > + > igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, > 0, 0, fb.width, fb.height, > get_color(drm_format, 0, 0, 1)); > @@ -144,8 +144,7 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, > igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 1, 1, 15, 15, > get_color(drm_format, 0, 1, 1)); > > - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, > - &ms.connector_id, 1, ms.mode); > + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); > igt_assert_eq(rc, 0); > > igt_pipe_crc_collect_crc(pipe_crc, crc); > @@ -203,8 +202,7 @@ static void get_fill_crc(uint64_t modifier, igt_crc_t *crc) > > igt_draw_fill_fb(drm_fd, &fb, 0xFF); > > - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, > - &ms.connector_id, 1, ms.mode); > + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); > igt_assert_eq(rc, 0); > > igt_pipe_crc_collect_crc(pipe_crc, crc); > @@ -227,8 +225,7 @@ static void fill_fb_subtest(void) > IGT_DRAW_MMAP_WC, > 0, 0, fb.width, fb.height, 0xFF); > > - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, > - &ms.connector_id, 1, ms.mode); > + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); > igt_assert_eq(rc, 0); > > igt_pipe_crc_collect_crc(pipe_crc, &base_crc); > @@ -251,40 +248,26 @@ static void fill_fb_subtest(void) > > static void setup_environment(void) > { > - int i; > - > drm_fd = drm_open_driver_master(DRIVER_INTEL); > igt_require(drm_fd >= 0); > - > - drm_res = drmModeGetResources(drm_fd); > - igt_require(drm_res); > - igt_assert(drm_res->count_connectors <= MAX_CONNECTORS); > - > - for (i = 0; i < drm_res->count_connectors; i++) > - drm_connectors[i] = drmModeGetConnectorCurrent(drm_fd, > - drm_res->connectors[i]); > + igt_display_require(&display, drm_fd); you add igt_display_require(..) which you should clean up afterwards with igt_display_fini(..) > + igt_display_require_output(&display); > > kmstest_set_vt_graphics_mode(); > > bops = buf_ops_create(drm_fd); > > find_modeset_params(); > - pipe_crc = igt_pipe_crc_new(drm_fd, kmstest_get_crtc_idx(drm_res, ms.crtc_id), > - INTEL_PIPE_CRC_SOURCE_AUTO); > } > > static void teardown_environment(void) > { > - int i; > - > igt_pipe_crc_free(pipe_crc); > > buf_ops_destroy(bops); > > - for (i = 0; i < drm_res->count_connectors; i++) > - drmModeFreeConnector(drm_connectors[i]); > + igt_display_reset(&display); If you want this reset to go in you'll need to commit it before closing fd. > > - drmModeFreeResources(drm_res); > close(drm_fd); > } > ^ permalink raw reply [flat|nested] 27+ messages in thread
* [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup 2022-08-04 3:40 ` [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup Nidhi Gupta ` (3 preceding siblings ...) 2022-08-09 12:53 ` Juha-Pekka Heikkila @ 2022-08-10 10:11 ` Nidhi Gupta 2022-08-10 13:27 ` Nidhi Gupta 4 siblings, 1 reply; 27+ messages in thread From: Nidhi Gupta @ 2022-08-10 10:11 UTC (permalink / raw) To: igt-dev; +Cc: Nidhi Gupta v2: -Replace drm function call with existing library functions (Bhanu) v3: -Replace PIPE_A with compatible pipe/output combo. (Bhanu) v4: -use for_each_pipe_with_single_output() for finding compatible pipe/ouput combo. -remove crtc_id as not used anywhere. -set fb to primary plane before commiting. (Bhanu) v5: -set fb to primary plane before commiting for fill_fb_subtest() also. -use existing IGT lib helper igt_display_has_format_mod() instead of format_is_supported(). (Bhanu) -added igt_display_fini(..) for cleanup (Juha-Pekka Heikkila) Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com> --- tests/i915/kms_draw_crc.c | 96 +++++++++++++++------------------------ 1 file changed, 37 insertions(+), 59 deletions(-) diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c index 48c7d931..97cadb02 100644 --- a/tests/i915/kms_draw_crc.c +++ b/tests/i915/kms_draw_crc.c @@ -29,15 +29,10 @@ #define MAX_CONNECTORS 32 -struct modeset_params { - uint32_t crtc_id; - uint32_t connector_id; - drmModeModeInfoPtr mode; -}; - int drm_fd; -drmModeResPtr drm_res; -drmModeConnectorPtr drm_connectors[MAX_CONNECTORS]; +igt_display_t display; +igt_output_t *output; +drmModeModeInfoPtr mode; struct buf_ops *bops; igt_pipe_crc_t *pipe_crc; @@ -60,34 +55,24 @@ struct base_crc { }; struct base_crc base_crcs[ARRAY_SIZE(formats)]; -struct modeset_params ms; - static void find_modeset_params(void) { - int i; - uint32_t crtc_id; - drmModeConnectorPtr connector = NULL; - drmModeModeInfoPtr mode = NULL; - - for (i = 0; i < drm_res->count_connectors; i++) { - drmModeConnectorPtr c = drm_connectors[i]; - - if (c->count_modes) { - connector = c; - mode = &c->modes[0]; - break; - } - } - igt_require(connector); + enum pipe pipe; + + igt_display_reset(&display); + igt_display_commit(&display); - crtc_id = kmstest_find_crtc_for_connector(drm_fd, drm_res, connector, - 0); - igt_assert(mode); + for_each_pipe_with_single_output(&display, pipe, output) { + igt_output_set_pipe(output, pipe); - ms.connector_id = connector->connector_id; - ms.crtc_id = crtc_id; - ms.mode = mode; + mode = igt_output_get_mode(output); + if (!mode) + continue; + pipe_crc = igt_pipe_crc_new(drm_fd, pipe, INTEL_PIPE_CRC_SOURCE_AUTO); + /*Only one pipe/output is enough*/ + break; + } } static uint32_t get_color(uint32_t drm_format, bool r, bool g, bool b) @@ -122,9 +107,14 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, { struct igt_fb fb; int rc; + igt_plane_t *primary; - igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); + + igt_create_fb(drm_fd, mode->hdisplay, mode->vdisplay, drm_format, modifier, &fb); + igt_plane_set_fb(primary, &fb); + igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 0, 0, fb.width, fb.height, get_color(drm_format, 0, 0, 1)); @@ -144,8 +134,7 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 1, 1, 15, 15, get_color(drm_format, 0, 1, 1)); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, crc); @@ -198,13 +187,12 @@ static void get_fill_crc(uint64_t modifier, igt_crc_t *crc) struct igt_fb fb; int rc; - igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, + igt_create_fb(drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888, modifier, &fb); igt_draw_fill_fb(drm_fd, &fb, 0xFF); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, crc); @@ -217,18 +205,22 @@ static void fill_fb_subtest(void) int rc; struct igt_fb fb; igt_crc_t base_crc, crc; + igt_plane_t *primary; bool has_4tile = intel_get_device_info(intel_get_drm_devid(drm_fd))->has_4tile; - igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, - DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &fb); + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); + + igt_create_fb(drm_fd, mode->hdisplay, mode->vdisplay, + + igt_plane_set_fb(primary, &fb); + DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &fb); igt_draw_rect_fb(drm_fd, bops, 0, &fb, gem_has_mappable_ggtt(drm_fd) ? IGT_DRAW_MMAP_GTT : IGT_DRAW_MMAP_WC, 0, 0, fb.width, fb.height, 0xFF); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, &base_crc); @@ -251,40 +243,26 @@ static void fill_fb_subtest(void) static void setup_environment(void) { - int i; - drm_fd = drm_open_driver_master(DRIVER_INTEL); igt_require(drm_fd >= 0); - - drm_res = drmModeGetResources(drm_fd); - igt_require(drm_res); - igt_assert(drm_res->count_connectors <= MAX_CONNECTORS); - - for (i = 0; i < drm_res->count_connectors; i++) - drm_connectors[i] = drmModeGetConnectorCurrent(drm_fd, - drm_res->connectors[i]); + igt_display_require(&display, drm_fd); + igt_display_require_output(&display); kmstest_set_vt_graphics_mode(); bops = buf_ops_create(drm_fd); find_modeset_params(); - pipe_crc = igt_pipe_crc_new(drm_fd, kmstest_get_crtc_idx(drm_res, ms.crtc_id), - INTEL_PIPE_CRC_SOURCE_AUTO); } static void teardown_environment(void) { - int i; + igt_display_fini(&display); igt_pipe_crc_free(pipe_crc); buf_ops_destroy(bops); - for (i = 0; i < drm_res->count_connectors; i++) - drmModeFreeConnector(drm_connectors[i]); - - drmModeFreeResources(drm_res); close(drm_fd); } @@ -346,7 +324,7 @@ igt_main !gem_has_mappable_ggtt(drm_fd)) continue; - if (!format_is_supported(formats[format_idx], modifier)) + if (!igt_display_has_format_mod(display, formats[format_idx], modifier)) continue; igt_dynamic_f("%s-%s-%s", -- 2.36.0 ^ permalink raw reply related [flat|nested] 27+ messages in thread
* [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup 2022-08-10 10:11 ` Nidhi Gupta @ 2022-08-10 13:27 ` Nidhi Gupta 2022-08-12 10:37 ` Modem, Bhanuprakash 0 siblings, 1 reply; 27+ messages in thread From: Nidhi Gupta @ 2022-08-10 13:27 UTC (permalink / raw) To: igt-dev; +Cc: Nidhi Gupta v2: -Replace drm function call with existing library functions (Bhanu) v3: -Replace PIPE_A with compatible pipe/output combo. (Bhanu) v4: -use for_each_pipe_with_single_output() for finding compatible pipe/ouput combo. -remove crtc_id as not used anywhere. -set fb to primary plane before commiting. (Bhanu) v5: -set fb to primary plane before commiting for fill_fb_subtest() also. -use existing IGT lib helper igt_display_has_format_mod() instead of format_is_supported(). (Bhanu) -added igt_display_fini(..) for cleanup (Juha-Pekka Heikkila) Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com> --- tests/i915/kms_draw_crc.c | 113 ++++++++++++-------------------------- 1 file changed, 36 insertions(+), 77 deletions(-) diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c index 48c7d931..f1887470 100644 --- a/tests/i915/kms_draw_crc.c +++ b/tests/i915/kms_draw_crc.c @@ -29,15 +29,10 @@ #define MAX_CONNECTORS 32 -struct modeset_params { - uint32_t crtc_id; - uint32_t connector_id; - drmModeModeInfoPtr mode; -}; - int drm_fd; -drmModeResPtr drm_res; -drmModeConnectorPtr drm_connectors[MAX_CONNECTORS]; +igt_display_t display; +igt_output_t *output; +drmModeModeInfoPtr mode; struct buf_ops *bops; igt_pipe_crc_t *pipe_crc; @@ -60,34 +55,24 @@ struct base_crc { }; struct base_crc base_crcs[ARRAY_SIZE(formats)]; -struct modeset_params ms; - static void find_modeset_params(void) { - int i; - uint32_t crtc_id; - drmModeConnectorPtr connector = NULL; - drmModeModeInfoPtr mode = NULL; - - for (i = 0; i < drm_res->count_connectors; i++) { - drmModeConnectorPtr c = drm_connectors[i]; - - if (c->count_modes) { - connector = c; - mode = &c->modes[0]; - break; - } - } - igt_require(connector); + enum pipe pipe; - crtc_id = kmstest_find_crtc_for_connector(drm_fd, drm_res, connector, - 0); - igt_assert(mode); + igt_display_reset(&display); + igt_display_commit(&display); - ms.connector_id = connector->connector_id; - ms.crtc_id = crtc_id; - ms.mode = mode; + for_each_pipe_with_single_output(&display, pipe, output) { + igt_output_set_pipe(output, pipe); + mode = igt_output_get_mode(output); + if (!mode) + continue; + + pipe_crc = igt_pipe_crc_new(drm_fd, pipe, INTEL_PIPE_CRC_SOURCE_AUTO); + /*Only one pipe/output is enough*/ + break; + } } static uint32_t get_color(uint32_t drm_format, bool r, bool g, bool b) @@ -122,9 +107,14 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, { struct igt_fb fb; int rc; + igt_plane_t *primary; - igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); + + igt_create_fb(drm_fd, mode->hdisplay, mode->vdisplay, drm_format, modifier, &fb); + igt_plane_set_fb(primary, &fb); + igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 0, 0, fb.width, fb.height, get_color(drm_format, 0, 0, 1)); @@ -144,8 +134,7 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 1, 1, 15, 15, get_color(drm_format, 0, 1, 1)); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, crc); @@ -153,25 +142,6 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, igt_remove_fb(drm_fd, &fb); } -static bool format_is_supported(uint32_t format, uint64_t modifier) -{ - uint32_t gem_handle, fb_id; - unsigned int offsets[4] = {}; - unsigned int strides[4] = {}; - int ret; - - gem_handle = igt_create_bo_with_dimensions(drm_fd, 64, 64, - format, modifier, - 0, NULL, &strides[0], NULL); - ret = __kms_addfb(drm_fd, gem_handle, 64, 64, - format, modifier, strides, offsets, 1, - DRM_MODE_FB_MODIFIERS, &fb_id); - drmModeRmFB(drm_fd, fb_id); - gem_close(drm_fd, gem_handle); - - return ret == 0; -} - static void draw_method_subtest(enum igt_draw_method method, uint32_t format_index, uint64_t modifier) { @@ -198,13 +168,12 @@ static void get_fill_crc(uint64_t modifier, igt_crc_t *crc) struct igt_fb fb; int rc; - igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, + igt_create_fb(drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888, modifier, &fb); igt_draw_fill_fb(drm_fd, &fb, 0xFF); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, crc); @@ -217,18 +186,22 @@ static void fill_fb_subtest(void) int rc; struct igt_fb fb; igt_crc_t base_crc, crc; + igt_plane_t *primary; bool has_4tile = intel_get_device_info(intel_get_drm_devid(drm_fd))->has_4tile; - igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); + + igt_create_fb(drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &fb); + igt_plane_set_fb(primary, &fb); + igt_draw_rect_fb(drm_fd, bops, 0, &fb, gem_has_mappable_ggtt(drm_fd) ? IGT_DRAW_MMAP_GTT : IGT_DRAW_MMAP_WC, 0, 0, fb.width, fb.height, 0xFF); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, &base_crc); @@ -251,40 +224,26 @@ static void fill_fb_subtest(void) static void setup_environment(void) { - int i; - drm_fd = drm_open_driver_master(DRIVER_INTEL); igt_require(drm_fd >= 0); - - drm_res = drmModeGetResources(drm_fd); - igt_require(drm_res); - igt_assert(drm_res->count_connectors <= MAX_CONNECTORS); - - for (i = 0; i < drm_res->count_connectors; i++) - drm_connectors[i] = drmModeGetConnectorCurrent(drm_fd, - drm_res->connectors[i]); + igt_display_require(&display, drm_fd); + igt_display_require_output(&display); kmstest_set_vt_graphics_mode(); bops = buf_ops_create(drm_fd); find_modeset_params(); - pipe_crc = igt_pipe_crc_new(drm_fd, kmstest_get_crtc_idx(drm_res, ms.crtc_id), - INTEL_PIPE_CRC_SOURCE_AUTO); } static void teardown_environment(void) { - int i; + igt_display_fini(&display); igt_pipe_crc_free(pipe_crc); buf_ops_destroy(bops); - for (i = 0; i < drm_res->count_connectors; i++) - drmModeFreeConnector(drm_connectors[i]); - - drmModeFreeResources(drm_res); close(drm_fd); } @@ -346,7 +305,7 @@ igt_main !gem_has_mappable_ggtt(drm_fd)) continue; - if (!format_is_supported(formats[format_idx], modifier)) + if (!igt_display_has_format_mod(&display, formats[format_idx], modifier)) continue; igt_dynamic_f("%s-%s-%s", -- 2.36.0 ^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup 2022-08-10 13:27 ` Nidhi Gupta @ 2022-08-12 10:37 ` Modem, Bhanuprakash 0 siblings, 0 replies; 27+ messages in thread From: Modem, Bhanuprakash @ 2022-08-12 10:37 UTC (permalink / raw) To: Nidhi Gupta, igt-dev On Wed-10-08-2022 06:57 pm, Nidhi Gupta wrote: > v2: -Replace drm function call with existing library functions > (Bhanu) > > v3: -Replace PIPE_A with compatible pipe/output combo. > (Bhanu) > > v4: -use for_each_pipe_with_single_output() for finding > compatible pipe/ouput combo. > -remove crtc_id as not used anywhere. > -set fb to primary plane before commiting. > (Bhanu) > > v5: -set fb to primary plane before commiting > for fill_fb_subtest() also. > -use existing IGT lib helper igt_display_has_format_mod() > instead of format_is_supported(). > (Bhanu) > -added igt_display_fini(..) for cleanup > (Juha-Pekka Heikkila) > > Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com> > --- > tests/i915/kms_draw_crc.c | 113 ++++++++++++-------------------------- > 1 file changed, 36 insertions(+), 77 deletions(-) > > diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c > index 48c7d931..f1887470 100644 > --- a/tests/i915/kms_draw_crc.c > +++ b/tests/i915/kms_draw_crc.c > @@ -29,15 +29,10 @@ > > #define MAX_CONNECTORS 32 > > -struct modeset_params { > - uint32_t crtc_id; > - uint32_t connector_id; > - drmModeModeInfoPtr mode; > -}; > - > int drm_fd; > -drmModeResPtr drm_res; > -drmModeConnectorPtr drm_connectors[MAX_CONNECTORS]; > +igt_display_t display; > +igt_output_t *output; > +drmModeModeInfoPtr mode; > struct buf_ops *bops; > igt_pipe_crc_t *pipe_crc; > > @@ -60,34 +55,24 @@ struct base_crc { > }; > struct base_crc base_crcs[ARRAY_SIZE(formats)]; > > -struct modeset_params ms; > - > static void find_modeset_params(void) > { > - int i; > - uint32_t crtc_id; > - drmModeConnectorPtr connector = NULL; > - drmModeModeInfoPtr mode = NULL; > - > - for (i = 0; i < drm_res->count_connectors; i++) { > - drmModeConnectorPtr c = drm_connectors[i]; > - > - if (c->count_modes) { > - connector = c; > - mode = &c->modes[0]; > - break; > - } > - } > - igt_require(connector); > + enum pipe pipe; > > - crtc_id = kmstest_find_crtc_for_connector(drm_fd, drm_res, connector, > - 0); > - igt_assert(mode); > + igt_display_reset(&display); > + igt_display_commit(&display); > > - ms.connector_id = connector->connector_id; > - ms.crtc_id = crtc_id; > - ms.mode = mode; > + for_each_pipe_with_single_output(&display, pipe, output) { s/for_each_pipe_with_single_output/for_each_pipe_with_valid_output/ > + igt_output_set_pipe(output, pipe); > > + mode = igt_output_get_mode(output); > + if (!mode) > + continue; I guess, every connected output will have atleast one valid mode, so we can drop this check. Otherwise, we must unset output/pipe & continue, and we need a check to handle if there is no valid mode found with all connected outputs. By addressing above commets, this patch is Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com> - Bhanu > + > + pipe_crc = igt_pipe_crc_new(drm_fd, pipe, INTEL_PIPE_CRC_SOURCE_AUTO); > + /*Only one pipe/output is enough*/ > + break; > + } > } > > static uint32_t get_color(uint32_t drm_format, bool r, bool g, bool b) > @@ -122,9 +107,14 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, > { > struct igt_fb fb; > int rc; > + igt_plane_t *primary; > > - igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, > + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); > + > + igt_create_fb(drm_fd, mode->hdisplay, mode->vdisplay, > drm_format, modifier, &fb); > + igt_plane_set_fb(primary, &fb); > + > igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, > 0, 0, fb.width, fb.height, > get_color(drm_format, 0, 0, 1)); > @@ -144,8 +134,7 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, > igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 1, 1, 15, 15, > get_color(drm_format, 0, 1, 1)); > > - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, > - &ms.connector_id, 1, ms.mode); > + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); > igt_assert_eq(rc, 0); > > igt_pipe_crc_collect_crc(pipe_crc, crc); > @@ -153,25 +142,6 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, > igt_remove_fb(drm_fd, &fb); > } > > -static bool format_is_supported(uint32_t format, uint64_t modifier) > -{ > - uint32_t gem_handle, fb_id; > - unsigned int offsets[4] = {}; > - unsigned int strides[4] = {}; > - int ret; > - > - gem_handle = igt_create_bo_with_dimensions(drm_fd, 64, 64, > - format, modifier, > - 0, NULL, &strides[0], NULL); > - ret = __kms_addfb(drm_fd, gem_handle, 64, 64, > - format, modifier, strides, offsets, 1, > - DRM_MODE_FB_MODIFIERS, &fb_id); > - drmModeRmFB(drm_fd, fb_id); > - gem_close(drm_fd, gem_handle); > - > - return ret == 0; > -} > - > static void draw_method_subtest(enum igt_draw_method method, > uint32_t format_index, uint64_t modifier) > { > @@ -198,13 +168,12 @@ static void get_fill_crc(uint64_t modifier, igt_crc_t *crc) > struct igt_fb fb; > int rc; > > - igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, > + igt_create_fb(drm_fd, mode->hdisplay, mode->vdisplay, > DRM_FORMAT_XRGB8888, modifier, &fb); > > igt_draw_fill_fb(drm_fd, &fb, 0xFF); > > - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, > - &ms.connector_id, 1, ms.mode); > + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); > igt_assert_eq(rc, 0); > > igt_pipe_crc_collect_crc(pipe_crc, crc); > @@ -217,18 +186,22 @@ static void fill_fb_subtest(void) > int rc; > struct igt_fb fb; > igt_crc_t base_crc, crc; > + igt_plane_t *primary; > bool has_4tile = intel_get_device_info(intel_get_drm_devid(drm_fd))->has_4tile; > > - igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, > + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); > + > + igt_create_fb(drm_fd, mode->hdisplay, mode->vdisplay, > DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &fb); > > + igt_plane_set_fb(primary, &fb); > + > igt_draw_rect_fb(drm_fd, bops, 0, &fb, > gem_has_mappable_ggtt(drm_fd) ? IGT_DRAW_MMAP_GTT : > IGT_DRAW_MMAP_WC, > 0, 0, fb.width, fb.height, 0xFF); > > - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, > - &ms.connector_id, 1, ms.mode); > + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); > igt_assert_eq(rc, 0); > > igt_pipe_crc_collect_crc(pipe_crc, &base_crc); > @@ -251,40 +224,26 @@ static void fill_fb_subtest(void) > > static void setup_environment(void) > { > - int i; > - > drm_fd = drm_open_driver_master(DRIVER_INTEL); > igt_require(drm_fd >= 0); > - > - drm_res = drmModeGetResources(drm_fd); > - igt_require(drm_res); > - igt_assert(drm_res->count_connectors <= MAX_CONNECTORS); > - > - for (i = 0; i < drm_res->count_connectors; i++) > - drm_connectors[i] = drmModeGetConnectorCurrent(drm_fd, > - drm_res->connectors[i]); > + igt_display_require(&display, drm_fd); > + igt_display_require_output(&display); > > kmstest_set_vt_graphics_mode(); > > bops = buf_ops_create(drm_fd); > > find_modeset_params(); > - pipe_crc = igt_pipe_crc_new(drm_fd, kmstest_get_crtc_idx(drm_res, ms.crtc_id), > - INTEL_PIPE_CRC_SOURCE_AUTO); > } > > static void teardown_environment(void) > { > - int i; > + igt_display_fini(&display); > > igt_pipe_crc_free(pipe_crc); > > buf_ops_destroy(bops); > > - for (i = 0; i < drm_res->count_connectors; i++) > - drmModeFreeConnector(drm_connectors[i]); > - > - drmModeFreeResources(drm_res); > close(drm_fd); > } > > @@ -346,7 +305,7 @@ igt_main > !gem_has_mappable_ggtt(drm_fd)) > continue; > > - if (!format_is_supported(formats[format_idx], modifier)) > + if (!igt_display_has_format_mod(&display, formats[format_idx], modifier)) > continue; > > igt_dynamic_f("%s-%s-%s", ^ permalink raw reply [flat|nested] 27+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/i915/kms_draw_crc: Test Cleanup (rev4) 2022-08-04 3:40 [igt-dev] [PATCH 0/2] tests/i915/kms_draw_crc: Test Cleanup Nidhi Gupta 2022-08-04 3:40 ` [igt-dev] [PATCH 1/2] tests/i915/kms_draw_crc: Convert tests to dynamic Nidhi Gupta 2022-08-04 3:40 ` [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup Nidhi Gupta @ 2022-08-04 4:23 ` Patchwork 2022-08-04 7:49 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork ` (4 subsequent siblings) 7 siblings, 0 replies; 27+ messages in thread From: Patchwork @ 2022-08-04 4:23 UTC (permalink / raw) To: Nidhi Gupta; +Cc: igt-dev [-- Attachment #1: Type: text/plain, Size: 9918 bytes --] == Series Details == Series: tests/i915/kms_draw_crc: Test Cleanup (rev4) URL : https://patchwork.freedesktop.org/series/106898/ State : success == Summary == CI Bug Log - changes from CI_DRM_11966 -> IGTPW_7603 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/index.html Participating hosts (41 -> 38) ------------------------------ Additional (2): bat-rpls-1 bat-jsl-3 Missing (5): fi-kbl-soraka fi-rkl-11600 bat-dg1-5 bat-dg2-9 bat-rpls-2 Known issues ------------ Here are the changes found in IGTPW_7603 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_huc_copy@huc-copy: - fi-kbl-8809g: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/fi-kbl-8809g/igt@gem_huc_copy@huc-copy.html * igt@gem_lmem_swapping@basic: - fi-kbl-8809g: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/fi-kbl-8809g/igt@gem_lmem_swapping@basic.html * igt@i915_selftest@live@hangcheck: - fi-hsw-4770: [PASS][3] -> [INCOMPLETE][4] ([i915#4785]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html - fi-snb-2600: [PASS][5] -> [INCOMPLETE][6] ([i915#3921]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/fi-snb-2600/igt@i915_selftest@live@hangcheck.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/fi-snb-2600/igt@i915_selftest@live@hangcheck.html - bat-dg1-6: [PASS][7] -> [DMESG-FAIL][8] ([i915#4494] / [i915#4957]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/bat-dg1-6/igt@i915_selftest@live@hangcheck.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/bat-dg1-6/igt@i915_selftest@live@hangcheck.html * igt@kms_chamelium@vga-edid-read: - fi-kbl-8809g: NOTRUN -> [SKIP][9] ([fdo#109271] / [fdo#111827]) +7 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/fi-kbl-8809g/igt@kms_chamelium@vga-edid-read.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor: - fi-kbl-8809g: NOTRUN -> [SKIP][10] ([fdo#109271]) +25 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/fi-kbl-8809g/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html * igt@runner@aborted: - fi-kbl-8809g: NOTRUN -> [FAIL][11] ([i915#4312] / [i915#6219]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/fi-kbl-8809g/igt@runner@aborted.html - fi-bdw-5557u: NOTRUN -> [FAIL][12] ([i915#4312]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/fi-bdw-5557u/igt@runner@aborted.html #### Possible fixes #### * igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size: - fi-bsw-kefka: [FAIL][13] ([i915#6298]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155 [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582 [i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867 [i915#3003]: https://gitlab.freedesktop.org/drm/intel/issues/3003 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785 [i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957 [i915#6219]: https://gitlab.freedesktop.org/drm/intel/issues/6219 [i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298 [i915#6503]: https://gitlab.freedesktop.org/drm/intel/issues/6503 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_6613 -> IGTPW_7603 CI-20190529: 20190529 CI_DRM_11966: f3c1d1b53388aaa69e20a1b72f8307ad57116565 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_7603: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/index.html IGT_6613: 209230467200f2fa63a6f71fe6299996470dd813 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Testlist changes ---------------- +igt@kms_draw_crc@draw-method -igt@kms_draw_crc@draw-method-rgb565-blt-4tiled -igt@kms_draw_crc@draw-method-rgb565-blt-untiled -igt@kms_draw_crc@draw-method-rgb565-blt-xtiled -igt@kms_draw_crc@draw-method-rgb565-blt-ytiled -igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-4tiled -igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled -igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-xtiled -igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-ytiled -igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-4tiled -igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-untiled -igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled -igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled -igt@kms_draw_crc@draw-method-rgb565-mmap-wc-4tiled -igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled -igt@kms_draw_crc@draw-method-rgb565-mmap-wc-xtiled -igt@kms_draw_crc@draw-method-rgb565-mmap-wc-ytiled -igt@kms_draw_crc@draw-method-rgb565-pwrite-4tiled -igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled -igt@kms_draw_crc@draw-method-rgb565-pwrite-xtiled -igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled -igt@kms_draw_crc@draw-method-rgb565-render-4tiled -igt@kms_draw_crc@draw-method-rgb565-render-untiled -igt@kms_draw_crc@draw-method-rgb565-render-xtiled -igt@kms_draw_crc@draw-method-rgb565-render-ytiled -igt@kms_draw_crc@draw-method-xrgb8888-blt-4tiled -igt@kms_draw_crc@draw-method-xrgb8888-blt-untiled -igt@kms_draw_crc@draw-method-xrgb8888-blt-xtiled -igt@kms_draw_crc@draw-method-xrgb8888-blt-ytiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-4tiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-untiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-xtiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-ytiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-4tiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-untiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-xtiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-ytiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-4tiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-untiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-xtiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-ytiled -igt@kms_draw_crc@draw-method-xrgb8888-pwrite-4tiled -igt@kms_draw_crc@draw-method-xrgb8888-pwrite-untiled -igt@kms_draw_crc@draw-method-xrgb8888-pwrite-xtiled -igt@kms_draw_crc@draw-method-xrgb8888-pwrite-ytiled -igt@kms_draw_crc@draw-method-xrgb8888-render-4tiled -igt@kms_draw_crc@draw-method-xrgb8888-render-untiled -igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled -igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled -igt@kms_draw_crc@draw-method-xrgb2101010-blt-4tiled -igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled -igt@kms_draw_crc@draw-method-xrgb2101010-blt-xtiled -igt@kms_draw_crc@draw-method-xrgb2101010-blt-ytiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-4tiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-untiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-xtiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-ytiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-4tiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-4tiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-untiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-xtiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-ytiled -igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-4tiled -igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled -igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-xtiled -igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-ytiled -igt@kms_draw_crc@draw-method-xrgb2101010-render-4tiled -igt@kms_draw_crc@draw-method-xrgb2101010-render-untiled -igt@kms_draw_crc@draw-method-xrgb2101010-render-xtiled -igt@kms_draw_crc@draw-method-xrgb2101010-render-ytiled == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/index.html [-- Attachment #2: Type: text/html, Size: 10336 bytes --] ^ permalink raw reply [flat|nested] 27+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/i915/kms_draw_crc: Test Cleanup (rev4) 2022-08-04 3:40 [igt-dev] [PATCH 0/2] tests/i915/kms_draw_crc: Test Cleanup Nidhi Gupta ` (2 preceding siblings ...) 2022-08-04 4:23 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/i915/kms_draw_crc: Test Cleanup (rev4) Patchwork @ 2022-08-04 7:49 ` Patchwork 2022-08-08 11:28 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/i915/kms_draw_crc: Test Cleanup (rev5) Patchwork ` (3 subsequent siblings) 7 siblings, 0 replies; 27+ messages in thread From: Patchwork @ 2022-08-04 7:49 UTC (permalink / raw) To: Nidhi Gupta; +Cc: igt-dev [-- Attachment #1: Type: text/plain, Size: 58156 bytes --] == Series Details == Series: tests/i915/kms_draw_crc: Test Cleanup (rev4) URL : https://patchwork.freedesktop.org/series/106898/ State : success == Summary == CI Bug Log - changes from CI_DRM_11966_full -> IGTPW_7603_full ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/index.html Participating hosts (10 -> 10) ------------------------------ Additional (3): shard-rkl shard-dg1 shard-tglu Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005 Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_7603_full: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@gem_ppgtt@blt-vs-render-ctx0: - {shard-rkl}: NOTRUN -> [FAIL][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-rkl-5/igt@gem_ppgtt@blt-vs-render-ctx0.html New tests --------- New tests have been introduced between CI_DRM_11966_full and IGTPW_7603_full: ### New IGT tests (55) ### * igt@kms_draw_crc@draw-method: - Statuses : - Exec time: [None] s * igt@kms_draw_crc@draw-method@rgb565-blt-untiled: - Statuses : 6 pass(s) - Exec time: [0.10, 0.18] s * igt@kms_draw_crc@draw-method@rgb565-blt-xtiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.18] s * igt@kms_draw_crc@draw-method@rgb565-blt-ytiled: - Statuses : 5 pass(s) - Exec time: [0.10, 0.18] s * igt@kms_draw_crc@draw-method@rgb565-mmap-cpu-untiled: - Statuses : 6 pass(s) - Exec time: [0.15, 0.27] s * igt@kms_draw_crc@draw-method@rgb565-mmap-cpu-xtiled: - Statuses : 6 pass(s) - Exec time: [0.10, 0.18] s * igt@kms_draw_crc@draw-method@rgb565-mmap-cpu-ytiled: - Statuses : 5 pass(s) - Exec time: [0.10, 0.18] s * igt@kms_draw_crc@draw-method@rgb565-mmap-gtt-untiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.13] s * igt@kms_draw_crc@draw-method@rgb565-mmap-gtt-xtiled: - Statuses : 6 pass(s) - Exec time: [0.08, 0.14] s * igt@kms_draw_crc@draw-method@rgb565-mmap-gtt-ytiled: - Statuses : 5 pass(s) - Exec time: [0.09, 0.15] s * igt@kms_draw_crc@draw-method@rgb565-mmap-wc-untiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.15] s * igt@kms_draw_crc@draw-method@rgb565-mmap-wc-xtiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.18] s * igt@kms_draw_crc@draw-method@rgb565-mmap-wc-ytiled: - Statuses : 5 pass(s) - Exec time: [0.10, 0.20] s * igt@kms_draw_crc@draw-method@rgb565-pwrite-untiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.15] s * igt@kms_draw_crc@draw-method@rgb565-pwrite-xtiled: - Statuses : 6 pass(s) - Exec time: [0.15, 0.32] s * igt@kms_draw_crc@draw-method@rgb565-pwrite-ytiled: - Statuses : 5 pass(s) - Exec time: [0.14, 0.29] s * igt@kms_draw_crc@draw-method@rgb565-render-untiled: - Statuses : 6 pass(s) - Exec time: [0.10, 0.21] s * igt@kms_draw_crc@draw-method@rgb565-render-xtiled: - Statuses : 6 pass(s) - Exec time: [0.10, 0.21] s * igt@kms_draw_crc@draw-method@rgb565-render-ytiled: - Statuses : 5 pass(s) - Exec time: [0.10, 0.21] s * igt@kms_draw_crc@draw-method@xrgb2101010-blt-untiled: - Statuses : 6 pass(s) - Exec time: [0.10, 0.18] s * igt@kms_draw_crc@draw-method@xrgb2101010-blt-xtiled: - Statuses : 6 pass(s) - Exec time: [0.10, 0.18] s * igt@kms_draw_crc@draw-method@xrgb2101010-blt-ytiled: - Statuses : 5 pass(s) - Exec time: [0.10, 0.17] s * igt@kms_draw_crc@draw-method@xrgb2101010-mmap-cpu-untiled: - Statuses : 6 pass(s) - Exec time: [0.18, 0.28] s * igt@kms_draw_crc@draw-method@xrgb2101010-mmap-cpu-xtiled: - Statuses : 6 pass(s) - Exec time: [0.10, 0.18] s * igt@kms_draw_crc@draw-method@xrgb2101010-mmap-cpu-ytiled: - Statuses : 5 pass(s) - Exec time: [0.10, 0.18] s * igt@kms_draw_crc@draw-method@xrgb2101010-mmap-gtt-untiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.14] s * igt@kms_draw_crc@draw-method@xrgb2101010-mmap-gtt-xtiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.14] s * igt@kms_draw_crc@draw-method@xrgb2101010-mmap-gtt-ytiled: - Statuses : 5 pass(s) - Exec time: [0.09, 0.13] s * igt@kms_draw_crc@draw-method@xrgb2101010-mmap-wc-untiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.16] s * igt@kms_draw_crc@draw-method@xrgb2101010-mmap-wc-xtiled: - Statuses : 6 pass(s) - Exec time: [0.10, 0.20] s * igt@kms_draw_crc@draw-method@xrgb2101010-mmap-wc-ytiled: - Statuses : 5 pass(s) - Exec time: [0.10, 0.20] s * igt@kms_draw_crc@draw-method@xrgb2101010-pwrite-untiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.17] s * igt@kms_draw_crc@draw-method@xrgb2101010-pwrite-xtiled: - Statuses : 6 pass(s) - Exec time: [0.15, 0.32] s * igt@kms_draw_crc@draw-method@xrgb2101010-pwrite-ytiled: - Statuses : 5 pass(s) - Exec time: [0.15, 0.33] s * igt@kms_draw_crc@draw-method@xrgb2101010-render-untiled: - Statuses : 6 pass(s) - Exec time: [0.10, 0.23] s * igt@kms_draw_crc@draw-method@xrgb2101010-render-xtiled: - Statuses : 6 pass(s) - Exec time: [0.11, 0.21] s * igt@kms_draw_crc@draw-method@xrgb2101010-render-ytiled: - Statuses : 5 pass(s) - Exec time: [0.10, 0.21] s * igt@kms_draw_crc@draw-method@xrgb8888-blt-untiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.19] s * igt@kms_draw_crc@draw-method@xrgb8888-blt-xtiled: - Statuses : 6 pass(s) - Exec time: [0.10, 0.18] s * igt@kms_draw_crc@draw-method@xrgb8888-blt-ytiled: - Statuses : 5 pass(s) - Exec time: [0.10, 0.20] s * igt@kms_draw_crc@draw-method@xrgb8888-mmap-cpu-untiled: - Statuses : 6 pass(s) - Exec time: [0.31, 1.06] s * igt@kms_draw_crc@draw-method@xrgb8888-mmap-cpu-xtiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.19] s * igt@kms_draw_crc@draw-method@xrgb8888-mmap-cpu-ytiled: - Statuses : 5 pass(s) - Exec time: [0.10, 0.20] s * igt@kms_draw_crc@draw-method@xrgb8888-mmap-gtt-untiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.15] s * igt@kms_draw_crc@draw-method@xrgb8888-mmap-gtt-xtiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.17] s * igt@kms_draw_crc@draw-method@xrgb8888-mmap-gtt-ytiled: - Statuses : 5 pass(s) - Exec time: [0.09, 0.16] s * igt@kms_draw_crc@draw-method@xrgb8888-mmap-wc-untiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.17] s * igt@kms_draw_crc@draw-method@xrgb8888-mmap-wc-xtiled: - Statuses : 6 pass(s) - Exec time: [0.10, 0.20] s * igt@kms_draw_crc@draw-method@xrgb8888-mmap-wc-ytiled: - Statuses : 5 pass(s) - Exec time: [0.10, 0.20] s * igt@kms_draw_crc@draw-method@xrgb8888-pwrite-untiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.17] s * igt@kms_draw_crc@draw-method@xrgb8888-pwrite-xtiled: - Statuses : 6 pass(s) - Exec time: [0.14, 0.33] s * igt@kms_draw_crc@draw-method@xrgb8888-pwrite-ytiled: - Statuses : 5 pass(s) - Exec time: [0.15, 0.33] s * igt@kms_draw_crc@draw-method@xrgb8888-render-untiled: - Statuses : 6 pass(s) - Exec time: [0.10, 0.25] s * igt@kms_draw_crc@draw-method@xrgb8888-render-xtiled: - Statuses : 6 pass(s) - Exec time: [0.11, 0.23] s * igt@kms_draw_crc@draw-method@xrgb8888-render-ytiled: - Statuses : 5 pass(s) - Exec time: [0.10, 0.23] s Known issues ------------ Here are the changes found in IGTPW_7603_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@feature_discovery@display-4x: - shard-tglb: NOTRUN -> [SKIP][2] ([i915#1839]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb7/igt@feature_discovery@display-4x.html - shard-iclb: NOTRUN -> [SKIP][3] ([i915#1839]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb1/igt@feature_discovery@display-4x.html * igt@gem_eio@in-flight-contexts-1us: - shard-iclb: [PASS][4] -> [TIMEOUT][5] ([i915#3070]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb5/igt@gem_eio@in-flight-contexts-1us.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb8/igt@gem_eio@in-flight-contexts-1us.html * igt@gem_exec_balancer@parallel-contexts: - shard-iclb: [PASS][6] -> [SKIP][7] ([i915#4525]) +1 similar issue [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb2/igt@gem_exec_balancer@parallel-contexts.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb7/igt@gem_exec_balancer@parallel-contexts.html * igt@gem_exec_fair@basic-deadline: - shard-kbl: [PASS][8] -> [FAIL][9] ([i915#2846]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-kbl7/igt@gem_exec_fair@basic-deadline.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl1/igt@gem_exec_fair@basic-deadline.html - shard-glk: NOTRUN -> [FAIL][10] ([i915#2846]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-glk7/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-none@vecs0: - shard-glk: [PASS][11] -> [FAIL][12] ([i915#2842]) +1 similar issue [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-glk2/igt@gem_exec_fair@basic-none@vecs0.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-glk8/igt@gem_exec_fair@basic-none@vecs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-tglb: [PASS][13] -> [FAIL][14] ([i915#2842]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-tglb5/igt@gem_exec_fair@basic-pace-share@rcs0.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb7/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-apl: [PASS][15] -> [FAIL][16] ([i915#2842]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-apl8/igt@gem_exec_fair@basic-pace-solo@rcs0.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl7/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_exec_fence@syncobj-backward-timeline-chain-engines: - shard-snb: NOTRUN -> [SKIP][17] ([fdo#109271]) +90 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-snb7/igt@gem_exec_fence@syncobj-backward-timeline-chain-engines.html * igt@gem_lmem_swapping@basic: - shard-apl: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#4613]) +1 similar issue [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl7/igt@gem_lmem_swapping@basic.html - shard-tglb: NOTRUN -> [SKIP][19] ([i915#4613]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb5/igt@gem_lmem_swapping@basic.html - shard-iclb: NOTRUN -> [SKIP][20] ([i915#4613]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb2/igt@gem_lmem_swapping@basic.html * igt@gem_lmem_swapping@heavy-verify-multi-ccs: - shard-glk: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#4613]) +1 similar issue [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-glk3/igt@gem_lmem_swapping@heavy-verify-multi-ccs.html * igt@gem_lmem_swapping@verify-ccs: - shard-kbl: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#4613]) +1 similar issue [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl7/igt@gem_lmem_swapping@verify-ccs.html * igt@gem_pxp@fail-invalid-protected-context: - shard-tglb: NOTRUN -> [SKIP][23] ([i915#4270]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb7/igt@gem_pxp@fail-invalid-protected-context.html - shard-iclb: NOTRUN -> [SKIP][24] ([i915#4270]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb6/igt@gem_pxp@fail-invalid-protected-context.html * igt@gem_render_copy@y-tiled-to-vebox-x-tiled: - shard-iclb: NOTRUN -> [SKIP][25] ([i915#768]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb8/igt@gem_render_copy@y-tiled-to-vebox-x-tiled.html * igt@gem_userptr_blits@dmabuf-sync: - shard-apl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#3323]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl7/igt@gem_userptr_blits@dmabuf-sync.html - shard-kbl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#3323]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl4/igt@gem_userptr_blits@dmabuf-sync.html * igt@gem_userptr_blits@unsync-unmap: - shard-tglb: NOTRUN -> [SKIP][28] ([i915#3297]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb2/igt@gem_userptr_blits@unsync-unmap.html - shard-iclb: NOTRUN -> [SKIP][29] ([i915#3297]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb7/igt@gem_userptr_blits@unsync-unmap.html * igt@gem_workarounds@suspend-resume: - shard-apl: [PASS][30] -> [DMESG-WARN][31] ([i915#180]) +2 similar issues [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-apl6/igt@gem_workarounds@suspend-resume.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl3/igt@gem_workarounds@suspend-resume.html * igt@gen9_exec_parse@allowed-all: - shard-iclb: NOTRUN -> [SKIP][32] ([i915#2856]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb7/igt@gen9_exec_parse@allowed-all.html - shard-tglb: NOTRUN -> [SKIP][33] ([i915#2527] / [i915#2856]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb7/igt@gen9_exec_parse@allowed-all.html * igt@i915_pm_dc@dc6-dpms: - shard-iclb: [PASS][34] -> [FAIL][35] ([i915#454]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb1/igt@i915_pm_dc@dc6-dpms.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html * igt@i915_pm_dc@dc9-dpms: - shard-iclb: [PASS][36] -> [SKIP][37] ([i915#4281]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb5/igt@i915_pm_dc@dc9-dpms.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp: - shard-apl: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#1937]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl3/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html * igt@i915_pm_rc6_residency@rc6-idle@rcs0: - shard-tglb: NOTRUN -> [WARN][39] ([i915#2681]) +3 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb3/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html - shard-iclb: NOTRUN -> [WARN][40] ([i915#2684]) +3 similar issues [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb4/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html * igt@i915_suspend@forcewake: - shard-kbl: [PASS][41] -> [DMESG-WARN][42] ([i915#180]) +5 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-kbl1/igt@i915_suspend@forcewake.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl7/igt@i915_suspend@forcewake.html * igt@kms_atomic@plane-primary-overlay-mutable-zpos: - shard-tglb: NOTRUN -> [SKIP][43] ([i915#404]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb5/igt@kms_atomic@plane-primary-overlay-mutable-zpos.html - shard-iclb: NOTRUN -> [SKIP][44] ([i915#404]) [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb8/igt@kms_atomic@plane-primary-overlay-mutable-zpos.html * igt@kms_big_fb@4-tiled-8bpp-rotate-270: - shard-tglb: NOTRUN -> [SKIP][45] ([i915#5286]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb2/igt@kms_big_fb@4-tiled-8bpp-rotate-270.html - shard-iclb: NOTRUN -> [SKIP][46] ([i915#5286]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb1/igt@kms_big_fb@4-tiled-8bpp-rotate-270.html * igt@kms_big_fb@yf-tiled-32bpp-rotate-90: - shard-tglb: NOTRUN -> [SKIP][47] ([fdo#111615]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb3/igt@kms_big_fb@yf-tiled-32bpp-rotate-90.html * igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs: - shard-tglb: NOTRUN -> [SKIP][48] ([i915#3689] / [i915#3886]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb2/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html - shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109278] / [i915#3886]) +1 similar issue [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb1/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html - shard-kbl: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#3886]) +1 similar issue [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl7/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc: - shard-apl: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#3886]) +5 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl2/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-b-bad-pixel-format-4_tiled_dg2_rc_ccs: - shard-kbl: NOTRUN -> [SKIP][52] ([fdo#109271]) +107 similar issues [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl7/igt@kms_ccs@pipe-b-bad-pixel-format-4_tiled_dg2_rc_ccs.html * igt@kms_ccs@pipe-b-crc-primary-rotation-180-yf_tiled_ccs: - shard-apl: NOTRUN -> [DMESG-WARN][53] ([i915#62]) +6 similar issues [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl2/igt@kms_ccs@pipe-b-crc-primary-rotation-180-yf_tiled_ccs.html * igt@kms_ccs@pipe-b-random-ccs-data-4_tiled_dg2_rc_ccs_cc: - shard-tglb: NOTRUN -> [SKIP][54] ([i915#3689] / [i915#6095]) +2 similar issues [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb5/igt@kms_ccs@pipe-b-random-ccs-data-4_tiled_dg2_rc_ccs_cc.html * igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc: - shard-glk: NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#3886]) +6 similar issues [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-glk2/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs: - shard-tglb: NOTRUN -> [SKIP][56] ([i915#3689]) +5 similar issues [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb1/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs.html * igt@kms_chamelium@dp-crc-single: - shard-apl: NOTRUN -> [SKIP][57] ([fdo#109271] / [fdo#111827]) +15 similar issues [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl2/igt@kms_chamelium@dp-crc-single.html * igt@kms_chamelium@dp-hpd: - shard-glk: NOTRUN -> [SKIP][58] ([fdo#109271] / [fdo#111827]) +6 similar issues [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-glk6/igt@kms_chamelium@dp-hpd.html - shard-snb: NOTRUN -> [SKIP][59] ([fdo#109271] / [fdo#111827]) +4 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-snb5/igt@kms_chamelium@dp-hpd.html * igt@kms_chamelium@hdmi-hpd-with-enabled-mode: - shard-iclb: NOTRUN -> [SKIP][60] ([fdo#109284] / [fdo#111827]) +4 similar issues [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb7/igt@kms_chamelium@hdmi-hpd-with-enabled-mode.html * igt@kms_color_chamelium@pipe-a-gamma: - shard-kbl: NOTRUN -> [SKIP][61] ([fdo#109271] / [fdo#111827]) +9 similar issues [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl7/igt@kms_color_chamelium@pipe-a-gamma.html * igt@kms_color_chamelium@pipe-b-ctm-negative: - shard-tglb: NOTRUN -> [SKIP][62] ([fdo#109284] / [fdo#111827]) +4 similar issues [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb2/igt@kms_color_chamelium@pipe-b-ctm-negative.html * igt@kms_content_protection@atomic: - shard-apl: NOTRUN -> [TIMEOUT][63] ([i915#1319]) +1 similar issue [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl7/igt@kms_content_protection@atomic.html * igt@kms_content_protection@lic: - shard-tglb: NOTRUN -> [SKIP][64] ([i915#1063]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb2/igt@kms_content_protection@lic.html - shard-iclb: NOTRUN -> [SKIP][65] ([fdo#109300] / [fdo#111066]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb4/igt@kms_content_protection@lic.html - shard-kbl: NOTRUN -> [TIMEOUT][66] ([i915#1319]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl7/igt@kms_content_protection@lic.html * igt@kms_content_protection@uevent: - shard-kbl: NOTRUN -> [FAIL][67] ([i915#2105]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl1/igt@kms_content_protection@uevent.html * igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic: - shard-tglb: NOTRUN -> [SKIP][68] ([fdo#109274] / [fdo#111825]) [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb2/igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic.html * igt@kms_display_modes@extended-mode-basic: - shard-tglb: NOTRUN -> [SKIP][69] ([fdo#109274]) [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb7/igt@kms_display_modes@extended-mode-basic.html * igt@kms_flip@2x-nonexisting-fb-interruptible: - shard-tglb: NOTRUN -> [SKIP][70] ([fdo#109274] / [fdo#111825] / [i915#3637]) +1 similar issue [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb1/igt@kms_flip@2x-nonexisting-fb-interruptible.html * igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset-interruptible: - shard-iclb: NOTRUN -> [SKIP][71] ([fdo#109274]) +3 similar issues [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb5/igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset-interruptible.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1: - shard-glk: [PASS][72] -> [FAIL][73] ([i915#79]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1.html [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-glk9/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1.html * igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-valid-mode: - shard-iclb: NOTRUN -> [SKIP][74] ([i915#2672]) +8 similar issues [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb7/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-valid-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-valid-mode: - shard-tglb: NOTRUN -> [SKIP][75] ([i915#2672]) [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb7/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-valid-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][76] ([i915#3555]) [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-default-mode.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc: - shard-iclb: NOTRUN -> [SKIP][77] ([fdo#109280]) +5 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-plflip-blt: - shard-tglb: NOTRUN -> [SKIP][78] ([fdo#109280] / [fdo#111825]) +5 similar issues [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-plflip-blt.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite: - shard-glk: NOTRUN -> [SKIP][79] ([fdo#109271]) +78 similar issues [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-glk6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-mmap-cpu: - shard-tglb: NOTRUN -> [SKIP][80] ([i915#6497]) +3 similar issues [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-mmap-cpu.html * igt@kms_pipe_b_c_ivb@disable-pipe-b-enable-pipe-c: - shard-tglb: NOTRUN -> [SKIP][81] ([fdo#109289]) [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb5/igt@kms_pipe_b_c_ivb@disable-pipe-b-enable-pipe-c.html - shard-iclb: NOTRUN -> [SKIP][82] ([fdo#109289]) [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb2/igt@kms_pipe_b_c_ivb@disable-pipe-b-enable-pipe-c.html * igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb: - shard-apl: NOTRUN -> [FAIL][83] ([fdo#108145] / [i915#265]) +1 similar issue [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl1/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html - shard-glk: NOTRUN -> [FAIL][84] ([fdo#108145] / [i915#265]) [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-glk3/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html - shard-kbl: NOTRUN -> [FAIL][85] ([fdo#108145] / [i915#265]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl4/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html * igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb: - shard-glk: NOTRUN -> [FAIL][86] ([i915#265]) [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-glk8/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-d-alpha-transparent-fb: - shard-apl: NOTRUN -> [SKIP][87] ([fdo#109271]) +186 similar issues [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl2/igt@kms_plane_alpha_blend@pipe-d-alpha-transparent-fb.html * igt@kms_plane_lowres@tiling-none@pipe-b-dp-1: - shard-apl: [PASS][88] -> [DMESG-WARN][89] ([i915#62]) +25 similar issues [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-apl7/igt@kms_plane_lowres@tiling-none@pipe-b-dp-1.html [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl2/igt@kms_plane_lowres@tiling-none@pipe-b-dp-1.html * igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1: - shard-iclb: [PASS][90] -> [SKIP][91] ([i915#5235]) +5 similar issues [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb7/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1.html [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb2/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1.html * igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf: - shard-apl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#658]) +1 similar issue [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl8/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area: - shard-tglb: NOTRUN -> [SKIP][93] ([i915#2920]) [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html - shard-glk: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#658]) [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-glk6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html - shard-iclb: NOTRUN -> [SKIP][95] ([fdo#111068] / [i915#658]) [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb4/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb: - shard-kbl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#658]) +1 similar issue [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb.html * igt@kms_psr@psr2_cursor_render: - shard-iclb: [PASS][97] -> [SKIP][98] ([fdo#109441]) [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb2/igt@kms_psr@psr2_cursor_render.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb8/igt@kms_psr@psr2_cursor_render.html * igt@kms_psr@psr2_sprite_plane_onoff: - shard-tglb: NOTRUN -> [FAIL][99] ([i915#132] / [i915#3467]) [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb7/igt@kms_psr@psr2_sprite_plane_onoff.html - shard-iclb: NOTRUN -> [SKIP][100] ([fdo#109441]) [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb3/igt@kms_psr@psr2_sprite_plane_onoff.html * igt@kms_rotation_crc@primary-rotation-90: - shard-glk: [PASS][101] -> [FAIL][102] ([i915#1888] / [i915#5852]) [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-glk8/igt@kms_rotation_crc@primary-rotation-90.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-glk7/igt@kms_rotation_crc@primary-rotation-90.html * igt@kms_selftest@all: - shard-tglb: NOTRUN -> [SKIP][103] ([i915#6433]) [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb3/igt@kms_selftest@all.html - shard-iclb: NOTRUN -> [SKIP][104] ([i915#6433]) [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb3/igt@kms_selftest@all.html * igt@kms_vblank@pipe-d-ts-continuation-idle: - shard-iclb: NOTRUN -> [SKIP][105] ([fdo#109278]) +8 similar issues [105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb6/igt@kms_vblank@pipe-d-ts-continuation-idle.html * igt@kms_vblank@pipe-d-wait-idle: - shard-kbl: NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#533]) [106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl1/igt@kms_vblank@pipe-d-wait-idle.html * igt@kms_writeback@writeback-check-output: - shard-apl: NOTRUN -> [SKIP][107] ([fdo#109271] / [i915#2437]) [107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl2/igt@kms_writeback@writeback-check-output.html - shard-kbl: NOTRUN -> [SKIP][108] ([fdo#109271] / [i915#2437]) [108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl1/igt@kms_writeback@writeback-check-output.html * igt@nouveau_crc@pipe-c-source-outp-complete: - shard-tglb: NOTRUN -> [SKIP][109] ([i915#2530]) +2 similar issues [109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb1/igt@nouveau_crc@pipe-c-source-outp-complete.html * igt@nouveau_crc@pipe-c-source-rg: - shard-iclb: NOTRUN -> [SKIP][110] ([i915#2530]) +2 similar issues [110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb1/igt@nouveau_crc@pipe-c-source-rg.html * igt@prime_nv_pcopy@test3_4: - shard-tglb: NOTRUN -> [SKIP][111] ([fdo#109291]) +2 similar issues [111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb7/igt@prime_nv_pcopy@test3_4.html * igt@prime_nv_test@nv_write_i915_gtt_mmap_read: - shard-iclb: NOTRUN -> [SKIP][112] ([fdo#109291]) +2 similar issues [112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb2/igt@prime_nv_test@nv_write_i915_gtt_mmap_read.html * igt@sysfs_clients@recycle: - shard-apl: NOTRUN -> [SKIP][113] ([fdo#109271] / [i915#2994]) +2 similar issues [113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl4/igt@sysfs_clients@recycle.html - shard-tglb: NOTRUN -> [SKIP][114] ([i915#2994]) +1 similar issue [114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb7/igt@sysfs_clients@recycle.html - shard-iclb: NOTRUN -> [SKIP][115] ([i915#2994]) +1 similar issue [115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb7/igt@sysfs_clients@recycle.html - shard-kbl: NOTRUN -> [SKIP][116] ([fdo#109271] / [i915#2994]) +1 similar issue [116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl4/igt@sysfs_clients@recycle.html * igt@sysfs_clients@sema-10: - shard-glk: NOTRUN -> [SKIP][117] ([fdo#109271] / [i915#2994]) +2 similar issues [117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-glk3/igt@sysfs_clients@sema-10.html * igt@tools_test@sysfs_l3_parity: - shard-tglb: NOTRUN -> [SKIP][118] ([fdo#109307]) [118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb5/igt@tools_test@sysfs_l3_parity.html - shard-iclb: NOTRUN -> [SKIP][119] ([fdo#109307]) [119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb6/igt@tools_test@sysfs_l3_parity.html #### Possible fixes #### * igt@gem_eio@kms: - shard-tglb: [TIMEOUT][120] ([i915#3063]) -> [PASS][121] +2 similar issues [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-tglb5/igt@gem_eio@kms.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb7/igt@gem_eio@kms.html * igt@gem_exec_balancer@parallel-keep-submit-fence: - shard-iclb: [SKIP][122] ([i915#4525]) -> [PASS][123] [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb5/igt@gem_exec_balancer@parallel-keep-submit-fence.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb2/igt@gem_exec_balancer@parallel-keep-submit-fence.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-glk: [FAIL][124] ([i915#2842]) -> [PASS][125] +2 similar issues [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-glk1/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-kbl: [FAIL][126] ([i915#2842]) -> [PASS][127] [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-kbl4/igt@gem_exec_fair@basic-pace-solo@rcs0.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl4/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_softpin@noreloc-s3: - shard-kbl: [DMESG-WARN][128] ([i915#180]) -> [PASS][129] +1 similar issue [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-kbl7/igt@gem_softpin@noreloc-s3.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl1/igt@gem_softpin@noreloc-s3.html * igt@i915_pm_dc@dc9-dpms: - shard-apl: [SKIP][130] ([fdo#109271]) -> [PASS][131] [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-apl8/igt@i915_pm_dc@dc9-dpms.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl8/igt@i915_pm_dc@dc9-dpms.html * igt@i915_pm_rpm@modeset-lpsp-stress: - shard-iclb: [DMESG-WARN][132] ([i915#6316]) -> [PASS][133] [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb2/igt@i915_pm_rpm@modeset-lpsp-stress.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb7/igt@i915_pm_rpm@modeset-lpsp-stress.html * igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size: - shard-glk: [FAIL][134] ([i915#2346]) -> [PASS][135] [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-glk2/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-glk5/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-kbl: [INCOMPLETE][136] ([i915#180] / [i915#4939]) -> [PASS][137] [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@flip-vs-suspend@c-dp1: - shard-apl: [DMESG-WARN][138] ([i915#180]) -> [PASS][139] +2 similar issues [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-apl8/igt@kms_flip@flip-vs-suspend@c-dp1.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl4/igt@kms_flip@flip-vs-suspend@c-dp1.html * igt@kms_invalid_mode@int-max-clock@dp-1-pipe-c: - shard-apl: [DMESG-WARN][140] ([i915#62]) -> [PASS][141] +12 similar issues [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-apl7/igt@kms_invalid_mode@int-max-clock@dp-1-pipe-c.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl6/igt@kms_invalid_mode@int-max-clock@dp-1-pipe-c.html * igt@kms_psr@psr2_sprite_render: - shard-iclb: [SKIP][142] ([fdo#109441]) -> [PASS][143] [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb1/igt@kms_psr@psr2_sprite_render.html [143]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb2/igt@kms_psr@psr2_sprite_render.html * igt@kms_psr_stress_test@flip-primary-invalidate-overlay: - shard-iclb: [SKIP][144] ([i915#5519]) -> [PASS][145] [144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb3/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html [145]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb2/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html #### Warnings #### * igt@gem_exec_balancer@parallel-ordering: - shard-iclb: [FAIL][146] ([i915#6117]) -> [SKIP][147] ([i915#4525]) [146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb4/igt@gem_exec_balancer@parallel-ordering.html [147]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb6/igt@gem_exec_balancer@parallel-ordering.html * igt@kms_content_protection@mei_interface: - shard-tglb: [SKIP][148] ([fdo#109300]) -> [SKIP][149] ([i915#1063]) [148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-tglb7/igt@kms_content_protection@mei_interface.html [149]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-tglb7/igt@kms_content_protection@mei_interface.html - shard-iclb: [SKIP][150] ([fdo#109300]) -> [SKIP][151] ([fdo#109300] / [fdo#111066]) [150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb5/igt@kms_content_protection@mei_interface.html [151]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb7/igt@kms_content_protection@mei_interface.html * igt@kms_psr2_sf@cursor-plane-update-sf: - shard-iclb: [SKIP][152] ([fdo#111068] / [i915#658]) -> [SKIP][153] ([i915#2920]) [152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb8/igt@kms_psr2_sf@cursor-plane-update-sf.html [153]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb2/igt@kms_psr2_sf@cursor-plane-update-sf.html * igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf: - shard-iclb: [SKIP][154] ([i915#658]) -> [SKIP][155] ([i915#2920]) [154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-iclb8/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html [155]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html * igt@runner@aborted: - shard-apl: ([FAIL][156], [FAIL][157], [FAIL][158], [FAIL][159], [FAIL][160], [FAIL][161], [FAIL][162]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][163], [FAIL][164], [FAIL][165], [FAIL][166], [FAIL][167]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) [156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-apl8/igt@runner@aborted.html [157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-apl4/igt@runner@aborted.html [158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-apl4/igt@runner@aborted.html [159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-apl4/igt@runner@aborted.html [160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-apl4/igt@runner@aborted.html [161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-apl8/igt@runner@aborted.html [162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-apl1/igt@runner@aborted.html [163]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl7/igt@runner@aborted.html [164]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl6/igt@runner@aborted.html [165]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl8/igt@runner@aborted.html [166]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl2/igt@runner@aborted.html [167]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-apl3/igt@runner@aborted.html - shard-kbl: ([FAIL][168], [FAIL][169], [FAIL][170], [FAIL][171], [FAIL][172]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#92]) -> ([FAIL][173], [FAIL][174], [FAIL][175], [FAIL][176], [FAIL][177], [FAIL][178]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) [168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-kbl1/igt@runner@aborted.html [169]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-kbl1/igt@runner@aborted.html [170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-kbl7/igt@runner@aborted.html [171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-kbl7/igt@runner@aborted.html [172]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11966/shard-kbl7/igt@runner@aborted.html [173]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl7/igt@runner@aborted.html [174]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl7/igt@runner@aborted.html [175]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl7/igt@runner@aborted.html [176]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl7/igt@runner@aborted.html [177]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl7/igt@runner@aborted.html [178]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/shard-kbl7/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300 [fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302 [fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303 [fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307 [fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308 [fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312 [fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313 [fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#110254]: https://bugs.freedesktop.org/show_bug.cgi?id=110254 [fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542 [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 [fdo#111066]: https://bugs.freedesktop.org/show_bug.cgi?id=111066 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644 [fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054 [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283 [i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155 [i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257 [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319 [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722 [i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755 [i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839 [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849 [i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911 [i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937 [i915#2105]: https://gitlab.freedesktop.org/drm/intel/issues/2105 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410 [i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433 [i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434 [i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435 [i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436 [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530 [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681 [i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684 [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705 [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280 [i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994 [i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002 [i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012 [i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063 [i915#3070]: https://gitlab.freedesktop.org/drm/intel/issues/3070 [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291 [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297 [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299 [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301 [i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318 [i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323 [i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361 [i915#3376]: https://gitlab.freedesktop.org/drm/intel/issues/3376 [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 [i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467 [i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469 [i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528 [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539 [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734 [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742 [i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826 [i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936 [i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938 [i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952 [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955 [i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966 [i915#3987]: https://gitlab.freedesktop.org/drm/intel/issues/3987 [i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989 [i915#4016]: https://gitlab.freedesktop.org/drm/intel/issues/4016 [i915#4032]: https://gitlab.freedesktop.org/drm/intel/issues/4032 [i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212 [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215 [i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433 [i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387 [i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494 [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525 [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771 [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812 [i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818 [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833 [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852 [i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854 [i915#4855]: https://gitlab.freedesktop.org/drm/intel/issues/4855 [i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859 [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860 [i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873 [i915#4874]: https://gitlab.freedesktop.org/drm/intel/issues/4874 [i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877 [i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879 [i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880 [i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881 [i915#4883]: https://gitlab.freedesktop.org/drm/intel/issues/4883 [i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885 [i915#4893]: https://gitlab.freedesktop.org/drm/intel/issues/4893 [i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939 [i915#4941]: https://gitlab.freedesktop.org/drm/intel/issues/4941 [i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957 [i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991 [i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5182]: https://gitlab.freedesktop.org/drm/intel/issues/5182 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288 [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289 [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325 [i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439 [i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461 [i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519 [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563 [i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723 [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784 [i915#5852]: https://gitlab.freedesktop.org/drm/intel/issues/5852 [i915#6011]: https://gitlab.freedesktop.org/drm/intel/issues/6011 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227 [i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230 [i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245 [i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248 [i915#6251]: https://gitlab.freedesktop.org/drm/intel/issues/6251 [i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258 [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268 [i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301 [i915#6316]: https://gitlab.freedesktop.org/drm/intel/issues/6316 [i915#6331]: https://gitlab.freedesktop.org/drm/intel/issues/6331 [i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334 [i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335 [i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344 [i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412 [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433 [i915#6458]: https://gitlab.freedesktop.org/drm/intel/issues/6458 [i915#6463]: https://gitlab.freedesktop.org/drm/intel/issues/6463 [i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493 [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497 [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524 [i915#6527]: https://gitlab.freedesktop.org/drm/intel/issues/6527 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_6613 -> IGTPW_7603 * Piglit: piglit_4509 -> None CI-20190529: 20190529 CI_DRM_11966: f3c1d1b53388aaa69e20a1b72f8307ad57116565 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_7603: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/index.html IGT_6613: 209230467200f2fa63a6f71fe6299996470dd813 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7603/index.html [-- Attachment #2: Type: text/html, Size: 62480 bytes --] ^ permalink raw reply [flat|nested] 27+ messages in thread
* [igt-dev] ✗ Fi.CI.BUILD: failure for tests/i915/kms_draw_crc: Test Cleanup (rev5) 2022-08-04 3:40 [igt-dev] [PATCH 0/2] tests/i915/kms_draw_crc: Test Cleanup Nidhi Gupta ` (3 preceding siblings ...) 2022-08-04 7:49 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork @ 2022-08-08 11:28 ` Patchwork 2022-08-10 12:53 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/i915/kms_draw_crc: Test Cleanup (rev6) Patchwork ` (2 subsequent siblings) 7 siblings, 0 replies; 27+ messages in thread From: Patchwork @ 2022-08-08 11:28 UTC (permalink / raw) To: Gupta, Nidhi1; +Cc: igt-dev == Series Details == Series: tests/i915/kms_draw_crc: Test Cleanup (rev5) URL : https://patchwork.freedesktop.org/series/106898/ State : failure == Summary == Applying: tests/i915/kms_draw_crc: Convert tests to dynamic Applying: tests/i915/kms_draw_crc: Test Cleanup Patch failed at 0002 tests/i915/kms_draw_crc: Test Cleanup When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". ^ permalink raw reply [flat|nested] 27+ messages in thread
* [igt-dev] ✗ Fi.CI.BUILD: failure for tests/i915/kms_draw_crc: Test Cleanup (rev6) 2022-08-04 3:40 [igt-dev] [PATCH 0/2] tests/i915/kms_draw_crc: Test Cleanup Nidhi Gupta ` (4 preceding siblings ...) 2022-08-08 11:28 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/i915/kms_draw_crc: Test Cleanup (rev5) Patchwork @ 2022-08-10 12:53 ` Patchwork 2022-08-10 14:54 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/i915/kms_draw_crc: Test Cleanup (rev7) Patchwork 2022-08-11 0:45 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 7 siblings, 0 replies; 27+ messages in thread From: Patchwork @ 2022-08-10 12:53 UTC (permalink / raw) To: Nidhi Gupta; +Cc: igt-dev == Series Details == Series: tests/i915/kms_draw_crc: Test Cleanup (rev6) URL : https://patchwork.freedesktop.org/series/106898/ State : failure == Summary == IGT patchset build failed on latest successful build ec2ab8e3a151ce05bd2726319c528c2ab99e8a96 tests/i915/perf_pmu: Use correct context id in "enable-race" [502/662] Linking target tests/i915_fb_tiling [503/662] Linking target tests/i915_getparams_basic [504/662] Linking target tests/i915_hangman [505/662] Linking target tests/i915_module_load [506/662] Linking target tests/i915_pciid [507/662] Linking target tests/i915_pm_lpsp [508/662] Linking target tests/i915_pm_rpm [509/662] Linking target tests/i915_pm_dc [510/662] Linking target tests/i915_pm_rps [511/662] Linking target tests/i915_pm_sseu [512/662] Linking target tests/i915_query [513/662] Linking target tests/i915_selftest [514/662] Linking target tests/kms_big_fb [515/662] Linking target tests/i915_suspend [516/662] Linking target tests/kms_ccs [517/662] Linking target tests/kms_big_joiner [518/662] Compiling C object tests/kms_draw_crc.p/i915_kms_draw_crc.c.o FAILED: tests/kms_draw_crc.p/i915_kms_draw_crc.c.o ccache cc -Itests/kms_draw_crc.p -Itests -I../tests -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I.. -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libpng12 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/x86_64-linux-gnu -I/usr/include/alsa -I/usr/include -I/home/cidrm/kernel_headers/include -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -pthread -MD -MQ tests/kms_draw_crc.p/i915_kms_draw_crc.c.o -MF tests/kms_draw_crc.p/i915_kms_draw_crc.c.o.d -o tests/kms_draw_crc.p/i915_kms_draw_crc.c.o -c ../tests/i915/kms_draw_crc.c ../tests/i915/kms_draw_crc.c: In function ‘fill_fb_subtest’: ../tests/i915/kms_draw_crc.c:215:32: error: expected ‘)’ before ‘;’ token igt_plane_set_fb(primary, &fb); ^ ) ../tests/i915/kms_draw_crc.c:215:2: error: invalid use of void expression igt_plane_set_fb(primary, &fb); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../tests/i915/kms_draw_crc.c:213:2: error: too few arguments to function ‘igt_create_fb’ igt_create_fb(drm_fd, mode->hdisplay, mode->vdisplay, ^~~~~~~~~~~~~ In file included from ../lib/igt_draw.h:29, from ../lib/igt.h:33, from ../tests/i915/kms_draw_crc.c:28: ../lib/igt_fb.h:141:14: note: declared here unsigned int igt_create_fb(int fd, int width, int height, uint32_t format, ^~~~~~~~~~~~~ ../tests/i915/kms_draw_crc.c: In function ‘__igt_unique____real_main299’: ../tests/i915/kms_draw_crc.c:327:38: error: incompatible type for argument 1 of ‘igt_display_has_format_mod’ if (!igt_display_has_format_mod(display, formats[format_idx], modifier)) ^~~~~~~ In file included from ../lib/igt.h:38, from ../tests/i915/kms_draw_crc.c:28: ../lib/igt_kms.h:863:48: note: expected ‘igt_display_t *’ {aka ‘struct igt_display *’} but argument is of type ‘igt_display_t’ {aka ‘struct igt_display’} bool igt_display_has_format_mod(igt_display_t *display, uint32_t format, uint64_t modifier); ~~~~~~~~~~~~~~~^~~~~~~ At top level: ../tests/i915/kms_draw_crc.c:145:13: warning: ‘format_is_supported’ defined but not used [-Wunused-function] static bool format_is_supported(uint32_t format, uint64_t modifier) ^~~~~~~~~~~~~~~~~~~ ninja: build stopped: subcommand failed. ^ permalink raw reply [flat|nested] 27+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/i915/kms_draw_crc: Test Cleanup (rev7) 2022-08-04 3:40 [igt-dev] [PATCH 0/2] tests/i915/kms_draw_crc: Test Cleanup Nidhi Gupta ` (5 preceding siblings ...) 2022-08-10 12:53 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/i915/kms_draw_crc: Test Cleanup (rev6) Patchwork @ 2022-08-10 14:54 ` Patchwork 2022-08-11 0:45 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 7 siblings, 0 replies; 27+ messages in thread From: Patchwork @ 2022-08-10 14:54 UTC (permalink / raw) To: Nidhi Gupta; +Cc: igt-dev [-- Attachment #1: Type: text/plain, Size: 8385 bytes --] == Series Details == Series: tests/i915/kms_draw_crc: Test Cleanup (rev7) URL : https://patchwork.freedesktop.org/series/106898/ State : success == Summary == CI Bug Log - changes from IGT_6620 -> IGTPW_7632 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/index.html Participating hosts (30 -> 29) ------------------------------ Additional (1): fi-cfl-8109u Missing (2): fi-ctg-p8600 fi-hsw-4200u Known issues ------------ Here are the changes found in IGTPW_7632 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_huc_copy@huc-copy: - fi-cfl-8109u: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/fi-cfl-8109u/igt@gem_huc_copy@huc-copy.html * igt@gem_lmem_swapping@basic: - fi-apl-guc: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/fi-apl-guc/igt@gem_lmem_swapping@basic.html * igt@gem_lmem_swapping@verify-random: - fi-cfl-8109u: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613]) +3 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/fi-cfl-8109u/igt@gem_lmem_swapping@verify-random.html * igt@kms_chamelium@dp-crc-fast: - fi-cfl-8109u: NOTRUN -> [SKIP][4] ([fdo#109271] / [fdo#111827]) +8 similar issues [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/fi-cfl-8109u/igt@kms_chamelium@dp-crc-fast.html * igt@kms_chamelium@hdmi-crc-fast: - fi-apl-guc: NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827]) +8 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/fi-apl-guc/igt@kms_chamelium@hdmi-crc-fast.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size: - fi-bsw-kefka: [PASS][6] -> [FAIL][7] ([i915#6298]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html * igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1: - fi-kbl-soraka: [PASS][8] -> [FAIL][9] ([i915#2122]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/fi-kbl-soraka/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/fi-kbl-soraka/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html * igt@kms_force_connector_basic@force-connector-state: - fi-apl-guc: NOTRUN -> [SKIP][10] ([fdo#109271]) +11 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/fi-apl-guc/igt@kms_force_connector_basic@force-connector-state.html * igt@prime_vgem@basic-userptr: - fi-cfl-8109u: NOTRUN -> [SKIP][11] ([fdo#109271]) +10 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/fi-cfl-8109u/igt@prime_vgem@basic-userptr.html #### Possible fixes #### * igt@gem_render_tiled_blits@basic: - fi-apl-guc: [INCOMPLETE][12] -> [PASS][13] [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/fi-apl-guc/igt@gem_render_tiled_blits@basic.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/fi-apl-guc/igt@gem_render_tiled_blits@basic.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_6620 -> IGTPW_7632 CI-20190529: 20190529 CI_DRM_11981: 6f207fdd93a13166b4adfe2f3a2972a9c632e757 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_7632: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/index.html IGT_6620: 90549cfba1606b695fe60f78ef87b7d54586eab7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Testlist changes ---------------- +igt@kms_draw_crc@draw-method -igt@kms_draw_crc@draw-method-rgb565-blt-4tiled -igt@kms_draw_crc@draw-method-rgb565-blt-untiled -igt@kms_draw_crc@draw-method-rgb565-blt-xtiled -igt@kms_draw_crc@draw-method-rgb565-blt-ytiled -igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-4tiled -igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled -igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-xtiled -igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-ytiled -igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-4tiled -igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-untiled -igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled -igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled -igt@kms_draw_crc@draw-method-rgb565-mmap-wc-4tiled -igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled -igt@kms_draw_crc@draw-method-rgb565-mmap-wc-xtiled -igt@kms_draw_crc@draw-method-rgb565-mmap-wc-ytiled -igt@kms_draw_crc@draw-method-rgb565-pwrite-4tiled -igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled -igt@kms_draw_crc@draw-method-rgb565-pwrite-xtiled -igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled -igt@kms_draw_crc@draw-method-rgb565-render-4tiled -igt@kms_draw_crc@draw-method-rgb565-render-untiled -igt@kms_draw_crc@draw-method-rgb565-render-xtiled -igt@kms_draw_crc@draw-method-rgb565-render-ytiled -igt@kms_draw_crc@draw-method-xrgb8888-blt-4tiled -igt@kms_draw_crc@draw-method-xrgb8888-blt-untiled -igt@kms_draw_crc@draw-method-xrgb8888-blt-xtiled -igt@kms_draw_crc@draw-method-xrgb8888-blt-ytiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-4tiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-untiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-xtiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-ytiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-4tiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-untiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-xtiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-ytiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-4tiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-untiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-xtiled -igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-ytiled -igt@kms_draw_crc@draw-method-xrgb8888-pwrite-4tiled -igt@kms_draw_crc@draw-method-xrgb8888-pwrite-untiled -igt@kms_draw_crc@draw-method-xrgb8888-pwrite-xtiled -igt@kms_draw_crc@draw-method-xrgb8888-pwrite-ytiled -igt@kms_draw_crc@draw-method-xrgb8888-render-4tiled -igt@kms_draw_crc@draw-method-xrgb8888-render-untiled -igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled -igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled -igt@kms_draw_crc@draw-method-xrgb2101010-blt-4tiled -igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled -igt@kms_draw_crc@draw-method-xrgb2101010-blt-xtiled -igt@kms_draw_crc@draw-method-xrgb2101010-blt-ytiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-4tiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-untiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-xtiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-ytiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-4tiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-4tiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-untiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-xtiled -igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-ytiled -igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-4tiled -igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled -igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-xtiled -igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-ytiled -igt@kms_draw_crc@draw-method-xrgb2101010-render-4tiled -igt@kms_draw_crc@draw-method-xrgb2101010-render-untiled -igt@kms_draw_crc@draw-method-xrgb2101010-render-xtiled -igt@kms_draw_crc@draw-method-xrgb2101010-render-ytiled == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/index.html [-- Attachment #2: Type: text/html, Size: 10180 bytes --] ^ permalink raw reply [flat|nested] 27+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/i915/kms_draw_crc: Test Cleanup (rev7) 2022-08-04 3:40 [igt-dev] [PATCH 0/2] tests/i915/kms_draw_crc: Test Cleanup Nidhi Gupta ` (6 preceding siblings ...) 2022-08-10 14:54 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/i915/kms_draw_crc: Test Cleanup (rev7) Patchwork @ 2022-08-11 0:45 ` Patchwork 7 siblings, 0 replies; 27+ messages in thread From: Patchwork @ 2022-08-11 0:45 UTC (permalink / raw) To: Nidhi Gupta; +Cc: igt-dev [-- Attachment #1: Type: text/plain, Size: 41609 bytes --] == Series Details == Series: tests/i915/kms_draw_crc: Test Cleanup (rev7) URL : https://patchwork.freedesktop.org/series/106898/ State : success == Summary == CI Bug Log - changes from IGT_6620_full -> IGTPW_7632_full ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/index.html Participating hosts (7 -> 7) ------------------------------ No changes in participating hosts New tests --------- New tests have been introduced between IGT_6620_full and IGTPW_7632_full: ### New IGT tests (55) ### * igt@kms_draw_crc@draw-method: - Statuses : - Exec time: [None] s * igt@kms_draw_crc@draw-method@rgb565-blt-untiled: - Statuses : 6 pass(s) - Exec time: [0.08, 0.17] s * igt@kms_draw_crc@draw-method@rgb565-blt-xtiled: - Statuses : 6 pass(s) - Exec time: [0.08, 0.18] s * igt@kms_draw_crc@draw-method@rgb565-blt-ytiled: - Statuses : 5 pass(s) - Exec time: [0.09, 0.18] s * igt@kms_draw_crc@draw-method@rgb565-mmap-cpu-untiled: - Statuses : 6 pass(s) - Exec time: [0.15, 0.27] s * igt@kms_draw_crc@draw-method@rgb565-mmap-cpu-xtiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.18] s * igt@kms_draw_crc@draw-method@rgb565-mmap-cpu-ytiled: - Statuses : 5 pass(s) - Exec time: [0.09, 0.18] s * igt@kms_draw_crc@draw-method@rgb565-mmap-gtt-untiled: - Statuses : 6 pass(s) - Exec time: [0.08, 0.13] s * igt@kms_draw_crc@draw-method@rgb565-mmap-gtt-xtiled: - Statuses : 6 pass(s) - Exec time: [0.08, 0.15] s * igt@kms_draw_crc@draw-method@rgb565-mmap-gtt-ytiled: - Statuses : 5 pass(s) - Exec time: [0.08, 0.15] s * igt@kms_draw_crc@draw-method@rgb565-mmap-wc-untiled: - Statuses : 6 pass(s) - Exec time: [0.08, 0.15] s * igt@kms_draw_crc@draw-method@rgb565-mmap-wc-xtiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.18] s * igt@kms_draw_crc@draw-method@rgb565-mmap-wc-ytiled: - Statuses : 5 pass(s) - Exec time: [0.09, 0.20] s * igt@kms_draw_crc@draw-method@rgb565-pwrite-untiled: - Statuses : 6 pass(s) - Exec time: [0.08, 0.15] s * igt@kms_draw_crc@draw-method@rgb565-pwrite-xtiled: - Statuses : 6 pass(s) - Exec time: [0.12, 0.32] s * igt@kms_draw_crc@draw-method@rgb565-pwrite-ytiled: - Statuses : 5 pass(s) - Exec time: [0.11, 0.28] s * igt@kms_draw_crc@draw-method@rgb565-render-untiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.22] s * igt@kms_draw_crc@draw-method@rgb565-render-xtiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.20] s * igt@kms_draw_crc@draw-method@rgb565-render-ytiled: - Statuses : 5 pass(s) - Exec time: [0.09, 0.22] s * igt@kms_draw_crc@draw-method@xrgb2101010-blt-untiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.18] s * igt@kms_draw_crc@draw-method@xrgb2101010-blt-xtiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.18] s * igt@kms_draw_crc@draw-method@xrgb2101010-blt-ytiled: - Statuses : 5 pass(s) - Exec time: [0.10, 0.18] s * igt@kms_draw_crc@draw-method@xrgb2101010-mmap-cpu-untiled: - Statuses : 6 pass(s) - Exec time: [0.15, 0.28] s * igt@kms_draw_crc@draw-method@xrgb2101010-mmap-cpu-xtiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.18] s * igt@kms_draw_crc@draw-method@xrgb2101010-mmap-cpu-ytiled: - Statuses : 5 pass(s) - Exec time: [0.09, 0.18] s * igt@kms_draw_crc@draw-method@xrgb2101010-mmap-gtt-untiled: - Statuses : 6 pass(s) - Exec time: [0.08, 0.15] s * igt@kms_draw_crc@draw-method@xrgb2101010-mmap-gtt-xtiled: - Statuses : 6 pass(s) - Exec time: [0.08, 0.15] s * igt@kms_draw_crc@draw-method@xrgb2101010-mmap-gtt-ytiled: - Statuses : 5 pass(s) - Exec time: [0.08, 0.15] s * igt@kms_draw_crc@draw-method@xrgb2101010-mmap-wc-untiled: - Statuses : 6 pass(s) - Exec time: [0.08, 0.20] s * igt@kms_draw_crc@draw-method@xrgb2101010-mmap-wc-xtiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.20] s * igt@kms_draw_crc@draw-method@xrgb2101010-mmap-wc-ytiled: - Statuses : 5 pass(s) - Exec time: [0.09, 0.20] s * igt@kms_draw_crc@draw-method@xrgb2101010-pwrite-untiled: - Statuses : 6 pass(s) - Exec time: [0.08, 0.18] s * igt@kms_draw_crc@draw-method@xrgb2101010-pwrite-xtiled: - Statuses : 6 pass(s) - Exec time: [0.12, 0.33] s * igt@kms_draw_crc@draw-method@xrgb2101010-pwrite-ytiled: - Statuses : 5 pass(s) - Exec time: [0.12, 0.33] s * igt@kms_draw_crc@draw-method@xrgb2101010-render-untiled: - Statuses : 6 pass(s) - Exec time: [0.10, 0.23] s * igt@kms_draw_crc@draw-method@xrgb2101010-render-xtiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.21] s * igt@kms_draw_crc@draw-method@xrgb2101010-render-ytiled: - Statuses : 5 pass(s) - Exec time: [0.09, 0.21] s * igt@kms_draw_crc@draw-method@xrgb8888-blt-untiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.20] s * igt@kms_draw_crc@draw-method@xrgb8888-blt-xtiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.20] s * igt@kms_draw_crc@draw-method@xrgb8888-blt-ytiled: - Statuses : 5 pass(s) - Exec time: [0.10, 0.20] s * igt@kms_draw_crc@draw-method@xrgb8888-mmap-cpu-untiled: - Statuses : 6 pass(s) - Exec time: [0.30, 1.12] s * igt@kms_draw_crc@draw-method@xrgb8888-mmap-cpu-xtiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.20] s * igt@kms_draw_crc@draw-method@xrgb8888-mmap-cpu-ytiled: - Statuses : 5 pass(s) - Exec time: [0.09, 0.20] s * igt@kms_draw_crc@draw-method@xrgb8888-mmap-gtt-untiled: - Statuses : 6 pass(s) - Exec time: [0.08, 0.15] s * igt@kms_draw_crc@draw-method@xrgb8888-mmap-gtt-xtiled: - Statuses : 6 pass(s) - Exec time: [0.08, 0.15] s * igt@kms_draw_crc@draw-method@xrgb8888-mmap-gtt-ytiled: - Statuses : 5 pass(s) - Exec time: [0.08, 0.16] s * igt@kms_draw_crc@draw-method@xrgb8888-mmap-wc-untiled: - Statuses : 6 pass(s) - Exec time: [0.08, 0.17] s * igt@kms_draw_crc@draw-method@xrgb8888-mmap-wc-xtiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.20] s * igt@kms_draw_crc@draw-method@xrgb8888-mmap-wc-ytiled: - Statuses : 5 pass(s) - Exec time: [0.09, 0.21] s * igt@kms_draw_crc@draw-method@xrgb8888-pwrite-untiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.18] s * igt@kms_draw_crc@draw-method@xrgb8888-pwrite-xtiled: - Statuses : 6 pass(s) - Exec time: [0.12, 0.32] s * igt@kms_draw_crc@draw-method@xrgb8888-pwrite-ytiled: - Statuses : 5 pass(s) - Exec time: [0.12, 0.33] s * igt@kms_draw_crc@draw-method@xrgb8888-render-untiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.25] s * igt@kms_draw_crc@draw-method@xrgb8888-render-xtiled: - Statuses : 6 pass(s) - Exec time: [0.09, 0.23] s * igt@kms_draw_crc@draw-method@xrgb8888-render-ytiled: - Statuses : 5 pass(s) - Exec time: [0.09, 0.23] s Known issues ------------ Here are the changes found in IGTPW_7632_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_create@create-massive: - shard-kbl: NOTRUN -> [DMESG-WARN][1] ([i915#4991]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl1/igt@gem_create@create-massive.html * igt@gem_exec_balancer@parallel-out-fence: - shard-iclb: [PASS][2] -> [SKIP][3] ([i915#4525]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-iclb2/igt@gem_exec_balancer@parallel-out-fence.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb6/igt@gem_exec_balancer@parallel-out-fence.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-glk: [PASS][4] -> [FAIL][5] ([i915#2842]) +2 similar issues [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-glk6/igt@gem_exec_fair@basic-none-share@rcs0.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-glk3/igt@gem_exec_fair@basic-none-share@rcs0.html - shard-iclb: [PASS][6] -> [FAIL][7] ([i915#2842]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-iclb4/igt@gem_exec_fair@basic-none-share@rcs0.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-apl: [PASS][8] -> [FAIL][9] ([i915#2842]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-apl7/igt@gem_exec_fair@basic-pace-solo@rcs0.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-apl8/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-iclb: [PASS][10] -> [FAIL][11] ([i915#2849]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-iclb5/igt@gem_exec_fair@basic-throttle@rcs0.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_huc_copy@huc-copy: - shard-apl: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#2190]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-apl7/igt@gem_huc_copy@huc-copy.html * igt@gem_lmem_swapping@parallel-random: - shard-kbl: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#4613]) +3 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl1/igt@gem_lmem_swapping@parallel-random.html - shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#4613]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-apl2/igt@gem_lmem_swapping@parallel-random.html * igt@gem_pxp@create-protected-buffer: - shard-tglb: NOTRUN -> [SKIP][15] ([i915#4270]) +2 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-tglb5/igt@gem_pxp@create-protected-buffer.html * igt@gem_pxp@create-valid-protected-context: - shard-iclb: NOTRUN -> [SKIP][16] ([i915#4270]) +2 similar issues [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb4/igt@gem_pxp@create-valid-protected-context.html * igt@gem_softpin@32b-excludes-last-page: - shard-snb: NOTRUN -> [SKIP][17] ([fdo#109271]) +47 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-snb5/igt@gem_softpin@32b-excludes-last-page.html * igt@gem_userptr_blits@dmabuf-sync: - shard-kbl: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#3323]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl4/igt@gem_userptr_blits@dmabuf-sync.html * igt@gem_userptr_blits@vma-merge: - shard-kbl: NOTRUN -> [FAIL][19] ([i915#3318]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl4/igt@gem_userptr_blits@vma-merge.html * igt@gen7_exec_parse@basic-offset: - shard-iclb: NOTRUN -> [SKIP][20] ([fdo#109289]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb6/igt@gen7_exec_parse@basic-offset.html - shard-tglb: NOTRUN -> [SKIP][21] ([fdo#109289]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-tglb7/igt@gen7_exec_parse@basic-offset.html * igt@gen9_exec_parse@unaligned-jump: - shard-iclb: NOTRUN -> [SKIP][22] ([i915#2856]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb7/igt@gen9_exec_parse@unaligned-jump.html - shard-tglb: NOTRUN -> [SKIP][23] ([i915#2527] / [i915#2856]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-tglb2/igt@gen9_exec_parse@unaligned-jump.html * igt@i915_pm_dc@dc6-psr: - shard-iclb: [PASS][24] -> [FAIL][25] ([i915#454]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-iclb6/igt@i915_pm_dc@dc6-psr.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb3/igt@i915_pm_dc@dc6-psr.html * igt@i915_pm_dc@dc9-dpms: - shard-iclb: [PASS][26] -> [SKIP][27] ([i915#4281]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-iclb4/igt@i915_pm_dc@dc9-dpms.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html - shard-apl: [PASS][28] -> [SKIP][29] ([fdo#109271]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-apl6/igt@i915_pm_dc@dc9-dpms.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-apl4/igt@i915_pm_dc@dc9-dpms.html * igt@i915_query@hwconfig_table: - shard-tglb: NOTRUN -> [SKIP][30] ([i915#6245]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-tglb5/igt@i915_query@hwconfig_table.html * igt@i915_selftest@mock@sanitycheck: - shard-snb: [PASS][31] -> [SKIP][32] ([fdo#109271]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-snb6/igt@i915_selftest@mock@sanitycheck.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-snb7/igt@i915_selftest@mock@sanitycheck.html * igt@i915_suspend@debugfs-reader: - shard-kbl: [PASS][33] -> [DMESG-WARN][34] ([i915#180]) +2 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-kbl7/igt@i915_suspend@debugfs-reader.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl1/igt@i915_suspend@debugfs-reader.html * igt@kms_big_fb@y-tiled-8bpp-rotate-270: - shard-tglb: NOTRUN -> [SKIP][35] ([fdo#111614]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-tglb5/igt@kms_big_fb@y-tiled-8bpp-rotate-270.html - shard-iclb: NOTRUN -> [SKIP][36] ([fdo#110725] / [fdo#111614]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb8/igt@kms_big_fb@y-tiled-8bpp-rotate-270.html * igt@kms_big_fb@yf-tiled-8bpp-rotate-0: - shard-iclb: NOTRUN -> [SKIP][37] ([fdo#110723]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb5/igt@kms_big_fb@yf-tiled-8bpp-rotate-0.html - shard-tglb: NOTRUN -> [SKIP][38] ([fdo#111615]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-tglb3/igt@kms_big_fb@yf-tiled-8bpp-rotate-0.html * igt@kms_ccs@pipe-b-crc-primary-basic-4_tiled_dg2_mc_ccs: - shard-tglb: NOTRUN -> [SKIP][39] ([i915#6095]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-tglb3/igt@kms_ccs@pipe-b-crc-primary-basic-4_tiled_dg2_mc_ccs.html * igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs_cc: - shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#3886]) +7 similar issues [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl1/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs: - shard-apl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#3886]) +6 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-apl3/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc: - shard-iclb: NOTRUN -> [SKIP][42] ([fdo#109278] / [i915#3886]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb8/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html - shard-glk: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#3886]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-glk3/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-c-crc-primary-rotation-180-yf_tiled_ccs: - shard-tglb: NOTRUN -> [SKIP][44] ([fdo#111615] / [i915#3689]) [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-tglb2/igt@kms_ccs@pipe-c-crc-primary-rotation-180-yf_tiled_ccs.html * igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_ccs: - shard-iclb: NOTRUN -> [SKIP][45] ([fdo#109278]) +3 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb1/igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_ccs.html - shard-tglb: NOTRUN -> [SKIP][46] ([i915#3689]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-tglb7/igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_ccs.html * igt@kms_chamelium@hdmi-hpd-enable-disable-mode: - shard-kbl: NOTRUN -> [SKIP][47] ([fdo#109271] / [fdo#111827]) +10 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl7/igt@kms_chamelium@hdmi-hpd-enable-disable-mode.html * igt@kms_chamelium@hdmi-hpd-storm: - shard-apl: NOTRUN -> [SKIP][48] ([fdo#109271] / [fdo#111827]) +5 similar issues [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-apl4/igt@kms_chamelium@hdmi-hpd-storm.html * igt@kms_chamelium@vga-hpd-enable-disable-mode: - shard-tglb: NOTRUN -> [SKIP][49] ([fdo#109284] / [fdo#111827]) +1 similar issue [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-tglb5/igt@kms_chamelium@vga-hpd-enable-disable-mode.html * igt@kms_color_chamelium@ctm-limited-range: - shard-glk: NOTRUN -> [SKIP][50] ([fdo#109271] / [fdo#111827]) +1 similar issue [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-glk5/igt@kms_color_chamelium@ctm-limited-range.html - shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109284] / [fdo#111827]) +1 similar issue [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb4/igt@kms_color_chamelium@ctm-limited-range.html - shard-snb: NOTRUN -> [SKIP][52] ([fdo#109271] / [fdo#111827]) +1 similar issue [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-snb7/igt@kms_color_chamelium@ctm-limited-range.html * igt@kms_content_protection@lic: - shard-kbl: NOTRUN -> [TIMEOUT][53] ([i915#1319]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl7/igt@kms_content_protection@lic.html * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy: - shard-tglb: NOTRUN -> [SKIP][54] ([fdo#109274] / [fdo#111825]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-tglb5/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html * igt@kms_cursor_legacy@cursorb-vs-flipb@varying-size: - shard-kbl: NOTRUN -> [SKIP][55] ([fdo#109271]) +244 similar issues [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl4/igt@kms_cursor_legacy@cursorb-vs-flipb@varying-size.html * igt@kms_cursor_legacy@short-busy-flip-before-cursor: - shard-tglb: NOTRUN -> [SKIP][56] ([i915#4103]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-tglb3/igt@kms_cursor_legacy@short-busy-flip-before-cursor.html - shard-iclb: NOTRUN -> [SKIP][57] ([i915#4103]) [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb8/igt@kms_cursor_legacy@short-busy-flip-before-cursor.html * igt@kms_dsc@dsc-with-formats: - shard-iclb: NOTRUN -> [SKIP][58] ([i915#3555] / [i915#3828]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb2/igt@kms_dsc@dsc-with-formats.html * igt@kms_flip@2x-modeset-vs-vblank-race-interruptible: - shard-iclb: NOTRUN -> [SKIP][59] ([fdo#109274]) +2 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb5/igt@kms_flip@2x-modeset-vs-vblank-race-interruptible.html * igt@kms_flip@2x-plain-flip-ts-check: - shard-tglb: NOTRUN -> [SKIP][60] ([fdo#109274] / [fdo#111825] / [i915#3637]) +1 similar issue [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-tglb7/igt@kms_flip@2x-plain-flip-ts-check.html * igt@kms_flip@flip-vs-expired-vblank@c-dp1: - shard-kbl: NOTRUN -> [FAIL][61] ([i915#79]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl1/igt@kms_flip@flip-vs-expired-vblank@c-dp1.html * igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode: - shard-iclb: NOTRUN -> [SKIP][62] ([i915#2672]) +6 similar issues [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb8/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][63] ([i915#3555]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-default-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][64] ([i915#2672] / [i915#3555]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-move: - shard-tglb: NOTRUN -> [SKIP][65] ([fdo#109280] / [fdo#111825]) +8 similar issues [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-move.html * igt@kms_frontbuffer_tracking@fbcpsr-stridechange: - shard-tglb: NOTRUN -> [SKIP][66] ([i915#6497]) +4 similar issues [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-stridechange.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-blt: - shard-iclb: NOTRUN -> [SKIP][67] ([fdo#109280]) +8 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb6/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-blt.html * igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb: - shard-apl: NOTRUN -> [FAIL][68] ([i915#265]) [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-apl3/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-b-alpha-basic: - shard-kbl: NOTRUN -> [FAIL][69] ([fdo#108145] / [i915#265]) [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl4/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html * igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb: - shard-apl: NOTRUN -> [FAIL][70] ([fdo#108145] / [i915#265]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-apl8/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html * igt@kms_plane_alpha_blend@pipe-d-alpha-transparent-fb: - shard-apl: NOTRUN -> [SKIP][71] ([fdo#109271]) +123 similar issues [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-apl2/igt@kms_plane_alpha_blend@pipe-d-alpha-transparent-fb.html * igt@kms_plane_multiple@atomic-pipe-b-tiling-4: - shard-glk: NOTRUN -> [SKIP][72] ([fdo#109271]) +27 similar issues [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-glk3/igt@kms_plane_multiple@atomic-pipe-b-tiling-4.html - shard-tglb: NOTRUN -> [SKIP][73] ([i915#5288]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-tglb3/igt@kms_plane_multiple@atomic-pipe-b-tiling-4.html * igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1: - shard-iclb: [PASS][74] -> [SKIP][75] ([i915#5176]) +1 similar issue [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-iclb7/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb3/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html * igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1: - shard-iclb: [PASS][76] -> [SKIP][77] ([i915#5235]) +2 similar issues [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-iclb1/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html * igt@kms_psr2_sf@overlay-plane-move-continuous-sf: - shard-apl: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#658]) +1 similar issue [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-apl2/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html * igt@kms_psr2_su@frontbuffer-xrgb8888: - shard-kbl: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#658]) +3 similar issues [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl1/igt@kms_psr2_su@frontbuffer-xrgb8888.html * igt@kms_psr2_su@page_flip-xrgb8888: - shard-iclb: [PASS][80] -> [SKIP][81] ([fdo#109642] / [fdo#111068] / [i915#658]) [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-iclb2/igt@kms_psr2_su@page_flip-xrgb8888.html [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb5/igt@kms_psr2_su@page_flip-xrgb8888.html * igt@kms_vblank@pipe-d-wait-idle: - shard-kbl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#533]) [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl1/igt@kms_vblank@pipe-d-wait-idle.html * igt@kms_writeback@writeback-fb-id: - shard-kbl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#2437]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl1/igt@kms_writeback@writeback-fb-id.html * igt@prime_nv_api@i915_self_import_to_different_fd: - shard-tglb: NOTRUN -> [SKIP][84] ([fdo#109291]) [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-tglb2/igt@prime_nv_api@i915_self_import_to_different_fd.html - shard-iclb: NOTRUN -> [SKIP][85] ([fdo#109291]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb7/igt@prime_nv_api@i915_self_import_to_different_fd.html * igt@sysfs_clients@fair-7: - shard-apl: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#2994]) [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-apl2/igt@sysfs_clients@fair-7.html * igt@sysfs_clients@recycle-many: - shard-kbl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#2994]) +1 similar issue [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl1/igt@sysfs_clients@recycle-many.html #### Possible fixes #### * igt@feature_discovery@psr2: - shard-iclb: [SKIP][88] ([i915#658]) -> [PASS][89] [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-iclb5/igt@feature_discovery@psr2.html [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb2/igt@feature_discovery@psr2.html * igt@gem_ctx_persistence@smoketest: - shard-iclb: [FAIL][90] ([i915#5099]) -> [PASS][91] [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-iclb2/igt@gem_ctx_persistence@smoketest.html [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb7/igt@gem_ctx_persistence@smoketest.html * igt@gem_eio@kms: - shard-tglb: [FAIL][92] ([i915#5784]) -> [PASS][93] [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-tglb3/igt@gem_eio@kms.html [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-tglb7/igt@gem_eio@kms.html * igt@gem_eio@unwedge-stress: - shard-iclb: [TIMEOUT][94] ([i915#3070]) -> [PASS][95] [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-iclb7/igt@gem_eio@unwedge-stress.html [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb8/igt@gem_eio@unwedge-stress.html * igt@gem_exec_balancer@parallel: - shard-iclb: [SKIP][96] ([i915#4525]) -> [PASS][97] [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-iclb8/igt@gem_exec_balancer@parallel.html [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb2/igt@gem_exec_balancer@parallel.html * igt@gem_exec_fair@basic-deadline: - shard-glk: [FAIL][98] ([i915#2846]) -> [PASS][99] [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-glk5/igt@gem_exec_fair@basic-deadline.html [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-glk5/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-glk: [FAIL][100] ([i915#2842]) -> [PASS][101] +1 similar issue [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html [101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-glk1/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_fair@basic-pace@vcs1: - shard-kbl: [SKIP][102] ([fdo#109271]) -> [PASS][103] [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs1.html [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl7/igt@gem_exec_fair@basic-pace@vcs1.html * igt@gem_exec_fair@basic-pace@vecs0: - shard-kbl: [FAIL][104] ([i915#2842]) -> [PASS][105] [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-kbl1/igt@gem_exec_fair@basic-pace@vecs0.html [105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl7/igt@gem_exec_fair@basic-pace@vecs0.html * igt@i915_suspend@forcewake: - shard-kbl: [DMESG-WARN][106] ([i915#180]) -> [PASS][107] +4 similar issues [106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-kbl1/igt@i915_suspend@forcewake.html [107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl4/igt@i915_suspend@forcewake.html * igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1: - shard-iclb: [SKIP][108] ([i915#5235]) -> [PASS][109] +2 similar issues [108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-iclb2/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1.html [109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb1/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1.html * igt@kms_psr@psr2_cursor_mmap_gtt: - shard-iclb: [SKIP][110] ([fdo#109441]) -> [PASS][111] +1 similar issue [110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-iclb7/igt@kms_psr@psr2_cursor_mmap_gtt.html [111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html * igt@kms_vblank@pipe-b-ts-continuation-suspend: - shard-apl: [DMESG-WARN][112] ([i915#180]) -> [PASS][113] +2 similar issues [112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-apl2/igt@kms_vblank@pipe-b-ts-continuation-suspend.html [113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-apl8/igt@kms_vblank@pipe-b-ts-continuation-suspend.html #### Warnings #### * igt@i915_suspend@sysfs-reader: - shard-kbl: [DMESG-WARN][114] ([i915#180]) -> [INCOMPLETE][115] ([i915#3614] / [i915#4817] / [i915#4939]) [114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-kbl7/igt@i915_suspend@sysfs-reader.html [115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl4/igt@i915_suspend@sysfs-reader.html * igt@kms_content_protection@mei_interface: - shard-tglb: [SKIP][116] ([fdo#109300]) -> [SKIP][117] ([i915#1063]) [116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-tglb3/igt@kms_content_protection@mei_interface.html [117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-tglb5/igt@kms_content_protection@mei_interface.html - shard-iclb: [SKIP][118] ([fdo#109300]) -> [SKIP][119] ([fdo#109300] / [fdo#111066]) [118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-iclb7/igt@kms_content_protection@mei_interface.html [119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb4/igt@kms_content_protection@mei_interface.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-kbl: [FAIL][120] ([i915#4767]) -> [INCOMPLETE][121] ([i915#180] / [i915#4939]) [120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-kbl4/igt@kms_fbcon_fbt@fbc-suspend.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1: - shard-kbl: [DMESG-WARN][122] ([i915#180]) -> [DMESG-FAIL][123] ([i915#180]) [122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-kbl7/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl1/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html * igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf: - shard-iclb: [SKIP][124] ([i915#658]) -> [SKIP][125] ([i915#2920]) [124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-iclb8/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf.html * igt@kms_psr2_sf@overlay-plane-update-continuous-sf: - shard-iclb: [SKIP][126] ([i915#2920]) -> [SKIP][127] ([fdo#111068] / [i915#658]) [126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-iclb5/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html * igt@runner@aborted: - shard-apl: ([FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][133], [FAIL][134]) ([i915#3002] / [i915#4312] / [i915#5257]) [128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-apl3/igt@runner@aborted.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-apl2/igt@runner@aborted.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-apl2/igt@runner@aborted.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-apl2/igt@runner@aborted.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-apl8/igt@runner@aborted.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-apl8/igt@runner@aborted.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-apl4/igt@runner@aborted.html - shard-kbl: ([FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150], [FAIL][151]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#92]) [135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-kbl7/igt@runner@aborted.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-kbl7/igt@runner@aborted.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-kbl4/igt@runner@aborted.html [138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-kbl7/igt@runner@aborted.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-kbl7/igt@runner@aborted.html [140]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-kbl7/igt@runner@aborted.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-kbl1/igt@runner@aborted.html [142]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-kbl1/igt@runner@aborted.html [143]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6620/shard-kbl1/igt@runner@aborted.html [144]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl1/igt@runner@aborted.html [145]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl1/igt@runner@aborted.html [146]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl1/igt@runner@aborted.html [147]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl4/igt@runner@aborted.html [148]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl7/igt@runner@aborted.html [149]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl7/igt@runner@aborted.html [150]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl7/igt@runner@aborted.html [151]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/shard-kbl7/igt@runner@aborted.html [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 [fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725 [fdo#111066]: https://bugs.freedesktop.org/show_bug.cgi?id=111066 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063 [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846 [i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994 [i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002 [i915#3070]: https://gitlab.freedesktop.org/drm/intel/issues/3070 [i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318 [i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3614]: https://gitlab.freedesktop.org/drm/intel/issues/3614 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767 [i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817 [i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939 [i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991 [i915#5099]: https://gitlab.freedesktop.org/drm/intel/issues/5099 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257 [i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245 [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_6620 -> IGTPW_7632 CI-20190529: 20190529 CI_DRM_11981: 6f207fdd93a13166b4adfe2f3a2972a9c632e757 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_7632: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/index.html IGT_6620: 90549cfba1606b695fe60f78ef87b7d54586eab7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7632/index.html [-- Attachment #2: Type: text/html, Size: 52837 bytes --] ^ permalink raw reply [flat|nested] 27+ messages in thread
* [igt-dev] [PATCH 0/2] tests/i915/kms_draw_crc: Test Cleanup @ 2022-09-05 11:24 Nidhi Gupta 2022-09-05 11:24 ` [igt-dev] [PATCH 2/2] " Nidhi Gupta 0 siblings, 1 reply; 27+ messages in thread From: Nidhi Gupta @ 2022-09-05 11:24 UTC (permalink / raw) To: igt-dev; +Cc: Nidhi Gupta Convert all possible subtests to dynamic and replace drm function call with existing library functions. Nidhi Gupta (2): tests/i915/kms_draw_crc: Convert tests to dynamic tests/i915/kms_draw_crc: Test Cleanup tests/i915/kms_draw_crc.c | 161 +++++++++++++++----------------------- 1 file changed, 64 insertions(+), 97 deletions(-) -- 2.36.0 ^ permalink raw reply [flat|nested] 27+ messages in thread
* [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup 2022-09-05 11:24 [igt-dev] [PATCH 0/2] tests/i915/kms_draw_crc: Test Cleanup Nidhi Gupta @ 2022-09-05 11:24 ` Nidhi Gupta 0 siblings, 0 replies; 27+ messages in thread From: Nidhi Gupta @ 2022-09-05 11:24 UTC (permalink / raw) To: igt-dev; +Cc: Nidhi Gupta v2: -Replace drm function call with existing library functions (Bhanu) v3: -Replace PIPE_A with compatible pipe/output combo. (Bhanu) v4: -use for_each_pipe_with_single_output() for finding compatible pipe/ouput combo. -remove crtc_id as not used anywhere. -set fb to primary plane before commiting. (Bhanu) v5: -set fb to primary plane before commiting for fill_fb_subtest() also. -use existing IGT lib helper igt_display_has_format_mod() instead of format_is_supported(). (Bhanu) -added igt_display_fini(..) for cleanup (Juha-Pekka Heikkila) v6: -replace each_pipe_with_single_output() with each_pipe_with_valid_output (Bhanu) Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com> Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com> --- tests/i915/kms_draw_crc.c | 113 ++++++++++++-------------------------- 1 file changed, 36 insertions(+), 77 deletions(-) diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c index 380be11b..b99f348d 100644 --- a/tests/i915/kms_draw_crc.c +++ b/tests/i915/kms_draw_crc.c @@ -29,15 +29,10 @@ #define MAX_CONNECTORS 32 -struct modeset_params { - uint32_t crtc_id; - uint32_t connector_id; - drmModeModeInfoPtr mode; -}; - int drm_fd; -drmModeResPtr drm_res; -drmModeConnectorPtr drm_connectors[MAX_CONNECTORS]; +igt_display_t display; +igt_output_t *output; +drmModeModeInfoPtr mode; struct buf_ops *bops; igt_pipe_crc_t *pipe_crc; @@ -60,34 +55,24 @@ struct base_crc { }; struct base_crc base_crcs[ARRAY_SIZE(formats)]; -struct modeset_params ms; - static void find_modeset_params(void) { - int i; - uint32_t crtc_id; - drmModeConnectorPtr connector = NULL; - drmModeModeInfoPtr mode = NULL; - - for (i = 0; i < drm_res->count_connectors; i++) { - drmModeConnectorPtr c = drm_connectors[i]; - - if (c->count_modes) { - connector = c; - mode = &c->modes[0]; - break; - } - } - igt_require(connector); + enum pipe pipe; - crtc_id = kmstest_find_crtc_for_connector(drm_fd, drm_res, connector, - 0); - igt_assert(mode); + igt_display_reset(&display); + igt_display_commit(&display); - ms.connector_id = connector->connector_id; - ms.crtc_id = crtc_id; - ms.mode = mode; + for_each_pipe_with_valid_output(&display, pipe, output) { + igt_output_set_pipe(output, pipe); + mode = igt_output_get_mode(output); + if (!mode) + continue; + + pipe_crc = igt_pipe_crc_new(drm_fd, pipe, INTEL_PIPE_CRC_SOURCE_AUTO); + /*Only one pipe/output is enough*/ + break; + } } static uint32_t get_color(uint32_t drm_format, bool r, bool g, bool b) @@ -122,9 +107,14 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, { struct igt_fb fb; int rc; + igt_plane_t *primary; - igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); + + igt_create_fb(drm_fd, mode->hdisplay, mode->vdisplay, drm_format, modifier, &fb); + igt_plane_set_fb(primary, &fb); + igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 0, 0, fb.width, fb.height, get_color(drm_format, 0, 0, 1)); @@ -144,8 +134,7 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 1, 1, 15, 15, get_color(drm_format, 0, 1, 1)); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, crc); @@ -153,25 +142,6 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, igt_remove_fb(drm_fd, &fb); } -static bool format_is_supported(uint32_t format, uint64_t modifier) -{ - uint32_t gem_handle, fb_id; - unsigned int offsets[4] = {}; - unsigned int strides[4] = {}; - int ret; - - gem_handle = igt_create_bo_with_dimensions(drm_fd, 64, 64, - format, modifier, - 0, NULL, &strides[0], NULL); - ret = __kms_addfb(drm_fd, gem_handle, 64, 64, - format, modifier, strides, offsets, 1, - DRM_MODE_FB_MODIFIERS, &fb_id); - drmModeRmFB(drm_fd, fb_id); - gem_close(drm_fd, gem_handle); - - return ret == 0; -} - static void draw_method_subtest(enum igt_draw_method method, uint32_t format_index, uint64_t modifier) { @@ -198,13 +168,12 @@ static void get_fill_crc(uint64_t modifier, igt_crc_t *crc) struct igt_fb fb; int rc; - igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, + igt_create_fb(drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888, modifier, &fb); igt_draw_fill_fb(drm_fd, &fb, 0xFF); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, crc); @@ -217,18 +186,22 @@ static void fill_fb_subtest(void) int rc; struct igt_fb fb; igt_crc_t base_crc, crc; + igt_plane_t *primary; bool has_4tile = intel_get_device_info(intel_get_drm_devid(drm_fd))->has_4tile; - igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); + + igt_create_fb(drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &fb); + igt_plane_set_fb(primary, &fb); + igt_draw_rect_fb(drm_fd, bops, 0, &fb, gem_has_mappable_ggtt(drm_fd) ? IGT_DRAW_MMAP_GTT : IGT_DRAW_MMAP_WC, 0, 0, fb.width, fb.height, 0xFF); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, &base_crc); @@ -251,40 +224,26 @@ static void fill_fb_subtest(void) static void setup_environment(void) { - int i; - drm_fd = drm_open_driver_master(DRIVER_INTEL); igt_require(drm_fd >= 0); - - drm_res = drmModeGetResources(drm_fd); - igt_require(drm_res); - igt_assert(drm_res->count_connectors <= MAX_CONNECTORS); - - for (i = 0; i < drm_res->count_connectors; i++) - drm_connectors[i] = drmModeGetConnectorCurrent(drm_fd, - drm_res->connectors[i]); + igt_display_require(&display, drm_fd); + igt_display_require_output(&display); kmstest_set_vt_graphics_mode(); bops = buf_ops_create(drm_fd); find_modeset_params(); - pipe_crc = igt_pipe_crc_new(drm_fd, kmstest_get_crtc_idx(drm_res, ms.crtc_id), - INTEL_PIPE_CRC_SOURCE_AUTO); } static void teardown_environment(void) { - int i; + igt_display_fini(&display); igt_pipe_crc_free(pipe_crc); buf_ops_destroy(bops); - for (i = 0; i < drm_res->count_connectors; i++) - drmModeFreeConnector(drm_connectors[i]); - - drmModeFreeResources(drm_res); close(drm_fd); } @@ -342,7 +301,7 @@ igt_main !gem_has_mappable_ggtt(drm_fd)) continue; - if (!format_is_supported(formats[format_idx], modifier)) + if (!igt_display_has_format_mod(&display, formats[format_idx], modifier)) continue; igt_dynamic_f("%s-%s-%s", -- 2.36.0 ^ permalink raw reply related [flat|nested] 27+ messages in thread
* [igt-dev] [PATCH 0/2] tests/i915/kms_draw_crc: Test Cleanup @ 2022-08-26 5:44 Nidhi Gupta 2022-08-26 5:44 ` [igt-dev] [PATCH 2/2] " Nidhi Gupta 0 siblings, 1 reply; 27+ messages in thread From: Nidhi Gupta @ 2022-08-26 5:44 UTC (permalink / raw) To: igt-dev; +Cc: Nidhi Gupta Convert all possible subtests to dynamic and replace drm function call with existing library functions. Nidhi Gupta (2): tests/i915/kms_draw_crc: Convert tests to dynamic tests/i915/kms_draw_crc: Test Cleanup tests/i915/kms_draw_crc.c | 161 +++++++++++++++----------------------- 1 file changed, 64 insertions(+), 97 deletions(-) -- 2.36.0 ^ permalink raw reply [flat|nested] 27+ messages in thread
* [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup 2022-08-26 5:44 [igt-dev] [PATCH 0/2] " Nidhi Gupta @ 2022-08-26 5:44 ` Nidhi Gupta 0 siblings, 0 replies; 27+ messages in thread From: Nidhi Gupta @ 2022-08-26 5:44 UTC (permalink / raw) To: igt-dev; +Cc: Nidhi Gupta v2: -Replace drm function call with existing library functions (Bhanu) v3: -Replace PIPE_A with compatible pipe/output combo. (Bhanu) v4: -use for_each_pipe_with_single_output() for finding compatible pipe/ouput combo. -remove crtc_id as not used anywhere. -set fb to primary plane before commiting. (Bhanu) v5: -set fb to primary plane before commiting for fill_fb_subtest() also. -use existing IGT lib helper igt_display_has_format_mod() instead of format_is_supported(). (Bhanu) -added igt_display_fini(..) for cleanup (Juha-Pekka Heikkila) v6: -replace each_pipe_with_single_output() with each_pipe_with_valid_output (Bhanu) Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com> Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com> --- tests/i915/kms_draw_crc.c | 117 ++++++++++++-------------------------- 1 file changed, 36 insertions(+), 81 deletions(-) diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c index 48c7d931..b99f348d 100644 --- a/tests/i915/kms_draw_crc.c +++ b/tests/i915/kms_draw_crc.c @@ -29,15 +29,10 @@ #define MAX_CONNECTORS 32 -struct modeset_params { - uint32_t crtc_id; - uint32_t connector_id; - drmModeModeInfoPtr mode; -}; - int drm_fd; -drmModeResPtr drm_res; -drmModeConnectorPtr drm_connectors[MAX_CONNECTORS]; +igt_display_t display; +igt_output_t *output; +drmModeModeInfoPtr mode; struct buf_ops *bops; igt_pipe_crc_t *pipe_crc; @@ -60,34 +55,24 @@ struct base_crc { }; struct base_crc base_crcs[ARRAY_SIZE(formats)]; -struct modeset_params ms; - static void find_modeset_params(void) { - int i; - uint32_t crtc_id; - drmModeConnectorPtr connector = NULL; - drmModeModeInfoPtr mode = NULL; - - for (i = 0; i < drm_res->count_connectors; i++) { - drmModeConnectorPtr c = drm_connectors[i]; - - if (c->count_modes) { - connector = c; - mode = &c->modes[0]; - break; - } - } - igt_require(connector); + enum pipe pipe; + + igt_display_reset(&display); + igt_display_commit(&display); - crtc_id = kmstest_find_crtc_for_connector(drm_fd, drm_res, connector, - 0); - igt_assert(mode); + for_each_pipe_with_valid_output(&display, pipe, output) { + igt_output_set_pipe(output, pipe); - ms.connector_id = connector->connector_id; - ms.crtc_id = crtc_id; - ms.mode = mode; + mode = igt_output_get_mode(output); + if (!mode) + continue; + pipe_crc = igt_pipe_crc_new(drm_fd, pipe, INTEL_PIPE_CRC_SOURCE_AUTO); + /*Only one pipe/output is enough*/ + break; + } } static uint32_t get_color(uint32_t drm_format, bool r, bool g, bool b) @@ -122,9 +107,14 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, { struct igt_fb fb; int rc; + igt_plane_t *primary; + + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); - igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, + igt_create_fb(drm_fd, mode->hdisplay, mode->vdisplay, drm_format, modifier, &fb); + igt_plane_set_fb(primary, &fb); + igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 0, 0, fb.width, fb.height, get_color(drm_format, 0, 0, 1)); @@ -144,8 +134,7 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 1, 1, 15, 15, get_color(drm_format, 0, 1, 1)); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, crc); @@ -153,25 +142,6 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, igt_remove_fb(drm_fd, &fb); } -static bool format_is_supported(uint32_t format, uint64_t modifier) -{ - uint32_t gem_handle, fb_id; - unsigned int offsets[4] = {}; - unsigned int strides[4] = {}; - int ret; - - gem_handle = igt_create_bo_with_dimensions(drm_fd, 64, 64, - format, modifier, - 0, NULL, &strides[0], NULL); - ret = __kms_addfb(drm_fd, gem_handle, 64, 64, - format, modifier, strides, offsets, 1, - DRM_MODE_FB_MODIFIERS, &fb_id); - drmModeRmFB(drm_fd, fb_id); - gem_close(drm_fd, gem_handle); - - return ret == 0; -} - static void draw_method_subtest(enum igt_draw_method method, uint32_t format_index, uint64_t modifier) { @@ -198,13 +168,12 @@ static void get_fill_crc(uint64_t modifier, igt_crc_t *crc) struct igt_fb fb; int rc; - igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, + igt_create_fb(drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888, modifier, &fb); igt_draw_fill_fb(drm_fd, &fb, 0xFF); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, crc); @@ -217,18 +186,22 @@ static void fill_fb_subtest(void) int rc; struct igt_fb fb; igt_crc_t base_crc, crc; + igt_plane_t *primary; bool has_4tile = intel_get_device_info(intel_get_drm_devid(drm_fd))->has_4tile; - igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); + + igt_create_fb(drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &fb); + igt_plane_set_fb(primary, &fb); + igt_draw_rect_fb(drm_fd, bops, 0, &fb, gem_has_mappable_ggtt(drm_fd) ? IGT_DRAW_MMAP_GTT : IGT_DRAW_MMAP_WC, 0, 0, fb.width, fb.height, 0xFF); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, &base_crc); @@ -251,40 +224,26 @@ static void fill_fb_subtest(void) static void setup_environment(void) { - int i; - drm_fd = drm_open_driver_master(DRIVER_INTEL); igt_require(drm_fd >= 0); - - drm_res = drmModeGetResources(drm_fd); - igt_require(drm_res); - igt_assert(drm_res->count_connectors <= MAX_CONNECTORS); - - for (i = 0; i < drm_res->count_connectors; i++) - drm_connectors[i] = drmModeGetConnectorCurrent(drm_fd, - drm_res->connectors[i]); + igt_display_require(&display, drm_fd); + igt_display_require_output(&display); kmstest_set_vt_graphics_mode(); bops = buf_ops_create(drm_fd); find_modeset_params(); - pipe_crc = igt_pipe_crc_new(drm_fd, kmstest_get_crtc_idx(drm_res, ms.crtc_id), - INTEL_PIPE_CRC_SOURCE_AUTO); } static void teardown_environment(void) { - int i; + igt_display_fini(&display); igt_pipe_crc_free(pipe_crc); buf_ops_destroy(bops); - for (i = 0; i < drm_res->count_connectors; i++) - drmModeFreeConnector(drm_connectors[i]); - - drmModeFreeResources(drm_res); close(drm_fd); } @@ -335,10 +294,6 @@ igt_main for (modifier_idx = 0; modifier_idx < ARRAY_SIZE(modifiers); modifier_idx++) { modifier = modifiers[modifier_idx]; - if (modifier == I915_FORMAT_MOD_4_TILED && - !HAS_4TILE(intel_get_drm_devid(drm_fd))) - continue; - if (method == IGT_DRAW_MMAP_WC && !gem_mmap__has_wc(drm_fd)) continue; @@ -346,7 +301,7 @@ igt_main !gem_has_mappable_ggtt(drm_fd)) continue; - if (!format_is_supported(formats[format_idx], modifier)) + if (!igt_display_has_format_mod(&display, formats[format_idx], modifier)) continue; igt_dynamic_f("%s-%s-%s", -- 2.36.0 ^ permalink raw reply related [flat|nested] 27+ messages in thread
* [igt-dev] [PATCH 0/2] tests/i915/kms_draw_crc: Test Cleanup @ 2022-08-22 9:20 Nidhi Gupta 2022-08-22 9:20 ` [igt-dev] [PATCH 2/2] " Nidhi Gupta 0 siblings, 1 reply; 27+ messages in thread From: Nidhi Gupta @ 2022-08-22 9:20 UTC (permalink / raw) To: igt-dev; +Cc: Nidhi Gupta, juha-pekka.heikkila Convert all possible subtests to dynamic and replace drm function call with existing library functions. Nidhi Gupta (2): tests/i915/kms_draw_crc: Convert tests to dynamic tests/i915/kms_draw_crc: Test Cleanup tests/i915/kms_draw_crc.c | 157 +++++++++++++++----------------------- 1 file changed, 60 insertions(+), 97 deletions(-) -- 2.36.0 ^ permalink raw reply [flat|nested] 27+ messages in thread
* [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup 2022-08-22 9:20 [igt-dev] [PATCH 0/2] " Nidhi Gupta @ 2022-08-22 9:20 ` Nidhi Gupta 0 siblings, 0 replies; 27+ messages in thread From: Nidhi Gupta @ 2022-08-22 9:20 UTC (permalink / raw) To: igt-dev; +Cc: Nidhi Gupta, juha-pekka.heikkila v2: -Replace drm function call with existing library functions (Bhanu) v3: -Replace PIPE_A with compatible pipe/output combo. (Bhanu) v4: -use for_each_pipe_with_single_output() for finding compatible pipe/ouput combo. -remove crtc_id as not used anywhere. -set fb to primary plane before commiting. (Bhanu) v5: -set fb to primary plane before commiting for fill_fb_subtest() also. -use existing IGT lib helper igt_display_has_format_mod() instead of format_is_supported(). (Bhanu) -added igt_display_fini(..) for cleanup (Juha-Pekka Heikkila) v6: -for_each_pipe_with_single_output() with for_each_pipe_with_valid_output(). (Bhanu) Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com> Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com> --- tests/i915/kms_draw_crc.c | 109 +++++++++++--------------------------- 1 file changed, 32 insertions(+), 77 deletions(-) diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c index 380be11b..d7107b7c 100644 --- a/tests/i915/kms_draw_crc.c +++ b/tests/i915/kms_draw_crc.c @@ -29,15 +29,10 @@ #define MAX_CONNECTORS 32 -struct modeset_params { - uint32_t crtc_id; - uint32_t connector_id; - drmModeModeInfoPtr mode; -}; - int drm_fd; -drmModeResPtr drm_res; -drmModeConnectorPtr drm_connectors[MAX_CONNECTORS]; +igt_display_t display; +igt_output_t *output; +drmModeModeInfoPtr mode; struct buf_ops *bops; igt_pipe_crc_t *pipe_crc; @@ -60,34 +55,20 @@ struct base_crc { }; struct base_crc base_crcs[ARRAY_SIZE(formats)]; -struct modeset_params ms; - static void find_modeset_params(void) { - int i; - uint32_t crtc_id; - drmModeConnectorPtr connector = NULL; - drmModeModeInfoPtr mode = NULL; - - for (i = 0; i < drm_res->count_connectors; i++) { - drmModeConnectorPtr c = drm_connectors[i]; - - if (c->count_modes) { - connector = c; - mode = &c->modes[0]; - break; - } - } - igt_require(connector); + enum pipe pipe; - crtc_id = kmstest_find_crtc_for_connector(drm_fd, drm_res, connector, - 0); - igt_assert(mode); + igt_display_reset(&display); + igt_display_commit(&display); - ms.connector_id = connector->connector_id; - ms.crtc_id = crtc_id; - ms.mode = mode; + for_each_pipe_with_valid_output(&display, pipe, output) { + igt_output_set_pipe(output, pipe); + pipe_crc = igt_pipe_crc_new(drm_fd, pipe, INTEL_PIPE_CRC_SOURCE_AUTO); + /*Only one pipe/output is enough*/ + break; + } } static uint32_t get_color(uint32_t drm_format, bool r, bool g, bool b) @@ -122,9 +103,14 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, { struct igt_fb fb; int rc; + igt_plane_t *primary; - igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); + + igt_create_fb(drm_fd, mode->hdisplay, mode->vdisplay, drm_format, modifier, &fb); + igt_plane_set_fb(primary, &fb); + igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 0, 0, fb.width, fb.height, get_color(drm_format, 0, 0, 1)); @@ -144,8 +130,7 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 1, 1, 15, 15, get_color(drm_format, 0, 1, 1)); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, crc); @@ -153,25 +138,6 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, igt_remove_fb(drm_fd, &fb); } -static bool format_is_supported(uint32_t format, uint64_t modifier) -{ - uint32_t gem_handle, fb_id; - unsigned int offsets[4] = {}; - unsigned int strides[4] = {}; - int ret; - - gem_handle = igt_create_bo_with_dimensions(drm_fd, 64, 64, - format, modifier, - 0, NULL, &strides[0], NULL); - ret = __kms_addfb(drm_fd, gem_handle, 64, 64, - format, modifier, strides, offsets, 1, - DRM_MODE_FB_MODIFIERS, &fb_id); - drmModeRmFB(drm_fd, fb_id); - gem_close(drm_fd, gem_handle); - - return ret == 0; -} - static void draw_method_subtest(enum igt_draw_method method, uint32_t format_index, uint64_t modifier) { @@ -198,13 +164,12 @@ static void get_fill_crc(uint64_t modifier, igt_crc_t *crc) struct igt_fb fb; int rc; - igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, + igt_create_fb(drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888, modifier, &fb); igt_draw_fill_fb(drm_fd, &fb, 0xFF); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, crc); @@ -217,18 +182,22 @@ static void fill_fb_subtest(void) int rc; struct igt_fb fb; igt_crc_t base_crc, crc; + igt_plane_t *primary; bool has_4tile = intel_get_device_info(intel_get_drm_devid(drm_fd))->has_4tile; - igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); + + igt_create_fb(drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &fb); + igt_plane_set_fb(primary, &fb); + igt_draw_rect_fb(drm_fd, bops, 0, &fb, gem_has_mappable_ggtt(drm_fd) ? IGT_DRAW_MMAP_GTT : IGT_DRAW_MMAP_WC, 0, 0, fb.width, fb.height, 0xFF); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, &base_crc); @@ -251,40 +220,26 @@ static void fill_fb_subtest(void) static void setup_environment(void) { - int i; - drm_fd = drm_open_driver_master(DRIVER_INTEL); igt_require(drm_fd >= 0); - - drm_res = drmModeGetResources(drm_fd); - igt_require(drm_res); - igt_assert(drm_res->count_connectors <= MAX_CONNECTORS); - - for (i = 0; i < drm_res->count_connectors; i++) - drm_connectors[i] = drmModeGetConnectorCurrent(drm_fd, - drm_res->connectors[i]); + igt_display_require(&display, drm_fd); + igt_display_require_output(&display); kmstest_set_vt_graphics_mode(); bops = buf_ops_create(drm_fd); find_modeset_params(); - pipe_crc = igt_pipe_crc_new(drm_fd, kmstest_get_crtc_idx(drm_res, ms.crtc_id), - INTEL_PIPE_CRC_SOURCE_AUTO); } static void teardown_environment(void) { - int i; + igt_display_fini(&display); igt_pipe_crc_free(pipe_crc); buf_ops_destroy(bops); - for (i = 0; i < drm_res->count_connectors; i++) - drmModeFreeConnector(drm_connectors[i]); - - drmModeFreeResources(drm_res); close(drm_fd); } @@ -342,7 +297,7 @@ igt_main !gem_has_mappable_ggtt(drm_fd)) continue; - if (!format_is_supported(formats[format_idx], modifier)) + if (!igt_display_has_format_mod(&display, formats[format_idx], modifier)) continue; igt_dynamic_f("%s-%s-%s", -- 2.36.0 ^ permalink raw reply related [flat|nested] 27+ messages in thread
* [igt-dev] [PATCH 0/2] tests/i915/kms_draw_crc: Test Cleanup @ 2022-08-03 4:20 Nidhi Gupta 2022-08-03 4:20 ` [igt-dev] [PATCH 2/2] " Nidhi Gupta 0 siblings, 1 reply; 27+ messages in thread From: Nidhi Gupta @ 2022-08-03 4:20 UTC (permalink / raw) To: igt-dev; +Cc: Nidhi Gupta Convert all possible subtests to dynamic and replace drm function call with existing library functions. Nidhi Gupta (2): tests/i915/kms_draw_crc: Convert tests to dynamic tests/i915/kms_draw_crc: Test Cleanup tests/i915/kms_draw_crc.c | 121 +++++++++++++++++++------------------- 1 file changed, 61 insertions(+), 60 deletions(-) -- 2.26.2 ^ permalink raw reply [flat|nested] 27+ messages in thread
* [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup 2022-08-03 4:20 [igt-dev] [PATCH 0/2] " Nidhi Gupta @ 2022-08-03 4:20 ` Nidhi Gupta 2022-08-03 7:40 ` Modem, Bhanuprakash 0 siblings, 1 reply; 27+ messages in thread From: Nidhi Gupta @ 2022-08-03 4:20 UTC (permalink / raw) To: igt-dev; +Cc: Nidhi Gupta v2: -Replace drm function call with existing library functions (Bhanu) v3: -Replace PIPE_A with compatible pipe/output combo. (Bhanu) Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com> --- tests/i915/kms_draw_crc.c | 67 ++++++++++++++++----------------------- 1 file changed, 28 insertions(+), 39 deletions(-) diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c index edab2f3b..c1e395d6 100644 --- a/tests/i915/kms_draw_crc.c +++ b/tests/i915/kms_draw_crc.c @@ -31,12 +31,13 @@ struct modeset_params { uint32_t crtc_id; - uint32_t connector_id; drmModeModeInfoPtr mode; }; int drm_fd; -drmModeResPtr drm_res; +igt_display_t display; +enum pipe pipe1; +igt_output_t *output; drmModeConnectorPtr drm_connectors[MAX_CONNECTORS]; struct buf_ops *bops; igt_pipe_crc_t *pipe_crc; @@ -64,27 +65,33 @@ struct modeset_params ms; static void find_modeset_params(void) { - int i; uint32_t crtc_id; - drmModeConnectorPtr connector = NULL; - drmModeModeInfoPtr mode = NULL; + drmModeModeInfo *mode; - for (i = 0; i < drm_res->count_connectors; i++) { - drmModeConnectorPtr c = drm_connectors[i]; + igt_display_reset(&display); + igt_display_commit(&display); - if (c->count_modes) { - connector = c; - mode = &c->modes[0]; - break; + for_each_connected_output(&display, output) { + for_each_pipe(&display, pipe1) { + if (igt_pipe_connector_valid(pipe1, output)) + /*One pipe is enough*/ + break; } + /*One output is enough*/ + break; } - igt_require(connector); - crtc_id = kmstest_find_crtc_for_connector(drm_fd, drm_res, connector, - 0); + igt_info("pipe-%s-%s", kmstest_pipe_name(pipe1), output->name); + + output = igt_get_single_output_for_pipe(&display, pipe1); + igt_require(output); + igt_output_set_pipe(output, pipe1); + + mode = igt_output_get_mode(output); igt_assert(mode); - ms.connector_id = connector->connector_id; + crtc_id = display.pipes[pipe1].crtc_id; + ms.crtc_id = crtc_id; ms.mode = mode; @@ -144,8 +151,7 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 1, 1, 15, 15, get_color(drm_format, 0, 1, 1)); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, crc); @@ -203,8 +209,7 @@ static void get_fill_crc(uint64_t modifier, igt_crc_t *crc) igt_draw_fill_fb(drm_fd, &fb, 0xFF); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, crc); @@ -227,8 +232,7 @@ static void fill_fb_subtest(void) IGT_DRAW_MMAP_WC, 0, 0, fb.width, fb.height, 0xFF); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, &base_crc); @@ -251,40 +255,25 @@ static void fill_fb_subtest(void) static void setup_environment(void) { - int i; - drm_fd = drm_open_driver_master(DRIVER_INTEL); igt_require(drm_fd >= 0); - - drm_res = drmModeGetResources(drm_fd); - igt_require(drm_res); - igt_assert(drm_res->count_connectors <= MAX_CONNECTORS); - - for (i = 0; i < drm_res->count_connectors; i++) - drm_connectors[i] = drmModeGetConnectorCurrent(drm_fd, - drm_res->connectors[i]); + igt_display_require(&display, drm_fd); + igt_display_require_output(&display); kmstest_set_vt_graphics_mode(); bops = buf_ops_create(drm_fd); find_modeset_params(); - pipe_crc = igt_pipe_crc_new(drm_fd, kmstest_get_crtc_idx(drm_res, ms.crtc_id), - INTEL_PIPE_CRC_SOURCE_AUTO); + pipe_crc = igt_pipe_crc_new(drm_fd, pipe1, INTEL_PIPE_CRC_SOURCE_AUTO); } static void teardown_environment(void) { - int i; - igt_pipe_crc_free(pipe_crc); buf_ops_destroy(bops); - for (i = 0; i < drm_res->count_connectors; i++) - drmModeFreeConnector(drm_connectors[i]); - - drmModeFreeResources(drm_res); close(drm_fd); } -- 2.26.2 ^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup 2022-08-03 4:20 ` [igt-dev] [PATCH 2/2] " Nidhi Gupta @ 2022-08-03 7:40 ` Modem, Bhanuprakash 0 siblings, 0 replies; 27+ messages in thread From: Modem, Bhanuprakash @ 2022-08-03 7:40 UTC (permalink / raw) To: Nidhi Gupta, igt-dev On Wed-03-08-2022 09:50 am, Nidhi Gupta wrote: > v2: -Replace drm function call with existing library functions > (Bhanu) > > v3: -Replace PIPE_A with compatible pipe/output combo. > (Bhanu) > > Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com> > --- > tests/i915/kms_draw_crc.c | 67 ++++++++++++++++----------------------- > 1 file changed, 28 insertions(+), 39 deletions(-) > > diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c > index edab2f3b..c1e395d6 100644 > --- a/tests/i915/kms_draw_crc.c > +++ b/tests/i915/kms_draw_crc.c > @@ -31,12 +31,13 @@ > > struct modeset_params { > uint32_t crtc_id; > - uint32_t connector_id; > drmModeModeInfoPtr mode; > }; > > int drm_fd; > -drmModeResPtr drm_res; > +igt_display_t display; > +enum pipe pipe1; > +igt_output_t *output; We are nowhere using these pipe & output except setup_environment(). So, these variables are supposed to be local to setup_environment(). > drmModeConnectorPtr drm_connectors[MAX_CONNECTORS]; > struct buf_ops *bops; > igt_pipe_crc_t *pipe_crc; > @@ -64,27 +65,33 @@ struct modeset_params ms; > > static void find_modeset_params(void) > { > - int i; > uint32_t crtc_id; > - drmModeConnectorPtr connector = NULL; > - drmModeModeInfoPtr mode = NULL; > + drmModeModeInfo *mode; > > - for (i = 0; i < drm_res->count_connectors; i++) { > - drmModeConnectorPtr c = drm_connectors[i]; > + igt_display_reset(&display); > + igt_display_commit(&display); > > - if (c->count_modes) { > - connector = c; > - mode = &c->modes[0]; > - break; > + for_each_connected_output(&display, output) { > + for_each_pipe(&display, pipe1) { > + if (igt_pipe_connector_valid(pipe1, output)) > + /*One pipe is enough*/ > + break; > } > + /*One output is enough*/ > + break; This is wrong. If no pipe is valid for first output, we need to try with next available output. Instead, use for_each_pipe_with_valid_output() or for_each_pipe_with_single_output() > } > - igt_require(connector); > > - crtc_id = kmstest_find_crtc_for_connector(drm_fd, drm_res, connector, > - 0); > + igt_info("pipe-%s-%s", kmstest_pipe_name(pipe1), output->name); > + > + output = igt_get_single_output_for_pipe(&display, pipe1); > + igt_require(output); > + igt_output_set_pipe(output, pipe1); > + > + mode = igt_output_get_mode(output); > igt_assert(mode); > > - ms.connector_id = connector->connector_id; > + crtc_id = display.pipes[pipe1].crtc_id; > + > ms.crtc_id = crtc_id; crtc_id is nowhere useful, please drop it. > ms.mode = mode; > > @@ -144,8 +151,7 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, > igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 1, 1, 15, 15, > get_color(drm_format, 0, 1, 1)); > > - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, > - &ms.connector_id, 1, ms.mode); > + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); hmm, Just realized that we are creating a fb and playing it, but not actually using it. So, I guess we need to set the fb to any plane before commit. Otherwise, you'll get same CRC for any modifier/method/format combo, since we are not using any framebuffer. Example: igt_plane_set_fb(primary, &fb); > igt_assert_eq(rc, 0); > > igt_pipe_crc_collect_crc(pipe_crc, crc); > @@ -203,8 +209,7 @@ static void get_fill_crc(uint64_t modifier, igt_crc_t *crc) > > igt_draw_fill_fb(drm_fd, &fb, 0xFF); > > - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, > - &ms.connector_id, 1, ms.mode); > + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); > igt_assert_eq(rc, 0); > > igt_pipe_crc_collect_crc(pipe_crc, crc); > @@ -227,8 +232,7 @@ static void fill_fb_subtest(void) > IGT_DRAW_MMAP_WC, > 0, 0, fb.width, fb.height, 0xFF); > > - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, > - &ms.connector_id, 1, ms.mode); > + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); > igt_assert_eq(rc, 0); > > igt_pipe_crc_collect_crc(pipe_crc, &base_crc); > @@ -251,40 +255,25 @@ static void fill_fb_subtest(void) > > static void setup_environment(void) > { > - int i; > - > drm_fd = drm_open_driver_master(DRIVER_INTEL); > igt_require(drm_fd >= 0); > - > - drm_res = drmModeGetResources(drm_fd); > - igt_require(drm_res); > - igt_assert(drm_res->count_connectors <= MAX_CONNECTORS); > - > - for (i = 0; i < drm_res->count_connectors; i++) > - drm_connectors[i] = drmModeGetConnectorCurrent(drm_fd, > - drm_res->connectors[i]); > + igt_display_require(&display, drm_fd); > + igt_display_require_output(&display); > > kmstest_set_vt_graphics_mode(); > > bops = buf_ops_create(drm_fd); > > find_modeset_params(); > - pipe_crc = igt_pipe_crc_new(drm_fd, kmstest_get_crtc_idx(drm_res, ms.crtc_id), > - INTEL_PIPE_CRC_SOURCE_AUTO); > + pipe_crc = igt_pipe_crc_new(drm_fd, pipe1, INTEL_PIPE_CRC_SOURCE_AUTO); We can move this statement to find_modset_parms() and drop pipe1 from global declaration. > } > > static void teardown_environment(void) > { > - int i; > - > igt_pipe_crc_free(pipe_crc); > > buf_ops_destroy(bops); > > - for (i = 0; i < drm_res->count_connectors; i++) > - drmModeFreeConnector(drm_connectors[i]); > - > - drmModeFreeResources(drm_res); igt_output_set_pipe(PIPE_NONE); or igt_display_reset(); > close(drm_fd); > } > ^ permalink raw reply [flat|nested] 27+ messages in thread
* [igt-dev] [PATCH 0/2] tests/i915/kms_draw_crc: Test Cleanup @ 2022-08-03 4:15 Nidhi Gupta 2022-08-03 4:15 ` [igt-dev] [PATCH 2/2] " Nidhi Gupta 0 siblings, 1 reply; 27+ messages in thread From: Nidhi Gupta @ 2022-08-03 4:15 UTC (permalink / raw) To: igt-dev; +Cc: Nidhi Gupta Convert all possible subtests to dynamic and replace drm function call with existing library functions. Nidhi Gupta (2): tests/i915/kms_draw_crc: Convert tests to dynamic tests/i915/kms_draw_crc: Test Cleanup tests/i915/kms_draw_crc.c | 125 ++++++++++++++++++++------------------ 1 file changed, 65 insertions(+), 60 deletions(-) -- 2.26.2 ^ permalink raw reply [flat|nested] 27+ messages in thread
* [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup 2022-08-03 4:15 [igt-dev] [PATCH 0/2] " Nidhi Gupta @ 2022-08-03 4:15 ` Nidhi Gupta 0 siblings, 0 replies; 27+ messages in thread From: Nidhi Gupta @ 2022-08-03 4:15 UTC (permalink / raw) To: igt-dev; +Cc: Nidhi Gupta v2: -Replace drm function call with existing library functions (Bhanu) v3: -Replace PIPE_A with compatible pipe/output combo. (Bhanu) Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com> --- tests/i915/kms_draw_crc.c | 71 ++++++++++++++++++--------------------- 1 file changed, 32 insertions(+), 39 deletions(-) diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c index edab2f3b..d3c44c5c 100644 --- a/tests/i915/kms_draw_crc.c +++ b/tests/i915/kms_draw_crc.c @@ -31,12 +31,13 @@ struct modeset_params { uint32_t crtc_id; - uint32_t connector_id; drmModeModeInfoPtr mode; }; int drm_fd; -drmModeResPtr drm_res; +igt_display_t display; +enum pipe pipe1; +igt_output_t *output; drmModeConnectorPtr drm_connectors[MAX_CONNECTORS]; struct buf_ops *bops; igt_pipe_crc_t *pipe_crc; @@ -64,27 +65,37 @@ struct modeset_params ms; static void find_modeset_params(void) { - int i; uint32_t crtc_id; - drmModeConnectorPtr connector = NULL; - drmModeModeInfoPtr mode = NULL; + drmModeModeInfo *mode; - for (i = 0; i < drm_res->count_connectors; i++) { - drmModeConnectorPtr c = drm_connectors[i]; + igt_display_reset(&display); + igt_display_commit(&display); - if (c->count_modes) { - connector = c; - mode = &c->modes[0]; - break; + for_each_connected_output(&display, output) { + + //if (!is_supported(output)) + // continue; + + for_each_pipe(&display, pipe1) { + if (igt_pipe_connector_valid(pipe1, output)) + /*One pipe is enough*/ + break; } + /*One output is enough*/ + break; } - igt_require(connector); - crtc_id = kmstest_find_crtc_for_connector(drm_fd, drm_res, connector, - 0); + igt_info("pipe-%s-%s", kmstest_pipe_name(pipe1), output->name); + + output = igt_get_single_output_for_pipe(&display, pipe1); + igt_require(output); + igt_output_set_pipe(output, pipe1); + + mode = igt_output_get_mode(output); igt_assert(mode); - ms.connector_id = connector->connector_id; + crtc_id = display.pipes[pipe1].crtc_id; + ms.crtc_id = crtc_id; ms.mode = mode; @@ -144,8 +155,7 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 1, 1, 15, 15, get_color(drm_format, 0, 1, 1)); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, crc); @@ -203,8 +213,7 @@ static void get_fill_crc(uint64_t modifier, igt_crc_t *crc) igt_draw_fill_fb(drm_fd, &fb, 0xFF); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, crc); @@ -227,8 +236,7 @@ static void fill_fb_subtest(void) IGT_DRAW_MMAP_WC, 0, 0, fb.width, fb.height, 0xFF); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, &base_crc); @@ -251,40 +259,25 @@ static void fill_fb_subtest(void) static void setup_environment(void) { - int i; - drm_fd = drm_open_driver_master(DRIVER_INTEL); igt_require(drm_fd >= 0); - - drm_res = drmModeGetResources(drm_fd); - igt_require(drm_res); - igt_assert(drm_res->count_connectors <= MAX_CONNECTORS); - - for (i = 0; i < drm_res->count_connectors; i++) - drm_connectors[i] = drmModeGetConnectorCurrent(drm_fd, - drm_res->connectors[i]); + igt_display_require(&display, drm_fd); + igt_display_require_output(&display); kmstest_set_vt_graphics_mode(); bops = buf_ops_create(drm_fd); find_modeset_params(); - pipe_crc = igt_pipe_crc_new(drm_fd, kmstest_get_crtc_idx(drm_res, ms.crtc_id), - INTEL_PIPE_CRC_SOURCE_AUTO); + pipe_crc = igt_pipe_crc_new(drm_fd, pipe1, INTEL_PIPE_CRC_SOURCE_AUTO); } static void teardown_environment(void) { - int i; - igt_pipe_crc_free(pipe_crc); buf_ops_destroy(bops); - for (i = 0; i < drm_res->count_connectors; i++) - drmModeFreeConnector(drm_connectors[i]); - - drmModeFreeResources(drm_res); close(drm_fd); } -- 2.26.2 ^ permalink raw reply related [flat|nested] 27+ messages in thread
* [igt-dev] [PATCH 0/2] tests/i915/kms_draw_crc: Test Cleanup @ 2022-08-02 6:53 Nidhi Gupta 2022-08-02 6:53 ` [igt-dev] [PATCH 2/2] " Nidhi Gupta 0 siblings, 1 reply; 27+ messages in thread From: Nidhi Gupta @ 2022-08-02 6:53 UTC (permalink / raw) To: igt-dev; +Cc: Nidhi Gupta Convert all possible subtests to dynamic and replace drm function call with existing library functions. Nidhi Gupta (2): tests/i915/kms_draw_crc: Convert tests to dynamic tests/i915/kms_draw_crc: Test Cleanup tests/i915/kms_draw_crc.c | 74 ++++++++++++++------------------------- 1 file changed, 26 insertions(+), 48 deletions(-) -- 2.26.2 ^ permalink raw reply [flat|nested] 27+ messages in thread
* [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup 2022-08-02 6:53 [igt-dev] [PATCH 0/2] " Nidhi Gupta @ 2022-08-02 6:53 ` Nidhi Gupta 2022-08-02 9:56 ` Modem, Bhanuprakash 0 siblings, 1 reply; 27+ messages in thread From: Nidhi Gupta @ 2022-08-02 6:53 UTC (permalink / raw) To: igt-dev; +Cc: Nidhi Gupta v2: -Replace drm function call with existing library functions (Bhanu) Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com> --- tests/i915/kms_draw_crc.c | 60 ++++++++++++--------------------------- 1 file changed, 18 insertions(+), 42 deletions(-) diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c index 5c9feac9..eaa200b9 100644 --- a/tests/i915/kms_draw_crc.c +++ b/tests/i915/kms_draw_crc.c @@ -31,12 +31,12 @@ struct modeset_params { uint32_t crtc_id; - uint32_t connector_id; drmModeModeInfoPtr mode; }; int drm_fd; -drmModeResPtr drm_res; +igt_display_t display; +igt_output_t *output; drmModeConnectorPtr drm_connectors[MAX_CONNECTORS]; struct buf_ops *bops; igt_pipe_crc_t *pipe_crc; @@ -64,27 +64,21 @@ struct modeset_params ms; static void find_modeset_params(void) { - int i; uint32_t crtc_id; - drmModeConnectorPtr connector = NULL; - drmModeModeInfoPtr mode = NULL; + drmModeModeInfo *mode; - for (i = 0; i < drm_res->count_connectors; i++) { - drmModeConnectorPtr c = drm_connectors[i]; + igt_display_reset(&display); + igt_display_commit(&display); - if (c->count_modes) { - connector = c; - mode = &c->modes[0]; - break; - } - } - igt_require(connector); - - crtc_id = kmstest_find_crtc_for_connector(drm_fd, drm_res, connector, - 0); + output = igt_get_single_output_for_pipe(&display, PIPE_A); + igt_require(output); + igt_output_set_pipe(output, PIPE_A); + + mode = igt_output_get_mode(output); igt_assert(mode); - ms.connector_id = connector->connector_id; + crtc_id = display.pipes[PIPE_A].crtc_id; + ms.crtc_id = crtc_id; ms.mode = mode; @@ -144,8 +138,7 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 1, 1, 15, 15, get_color(drm_format, 0, 1, 1)); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, crc); @@ -212,8 +205,7 @@ static void get_fill_crc(uint64_t modifier, igt_crc_t *crc) igt_draw_fill_fb(drm_fd, &fb, 0xFF); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, crc); @@ -236,8 +228,7 @@ static void fill_fb_subtest(void) IGT_DRAW_MMAP_WC, 0, 0, fb.width, fb.height, 0xFF); - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, - &ms.connector_id, 1, ms.mode); + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); igt_assert_eq(rc, 0); igt_pipe_crc_collect_crc(pipe_crc, &base_crc); @@ -260,40 +251,25 @@ static void fill_fb_subtest(void) static void setup_environment(void) { - int i; - drm_fd = drm_open_driver_master(DRIVER_INTEL); igt_require(drm_fd >= 0); - - drm_res = drmModeGetResources(drm_fd); - igt_require(drm_res); - igt_assert(drm_res->count_connectors <= MAX_CONNECTORS); - - for (i = 0; i < drm_res->count_connectors; i++) - drm_connectors[i] = drmModeGetConnectorCurrent(drm_fd, - drm_res->connectors[i]); + igt_display_require(&display, drm_fd); + igt_display_require_output(&display); kmstest_set_vt_graphics_mode(); bops = buf_ops_create(drm_fd); find_modeset_params(); - pipe_crc = igt_pipe_crc_new(drm_fd, kmstest_get_crtc_idx(drm_res, ms.crtc_id), - INTEL_PIPE_CRC_SOURCE_AUTO); + pipe_crc = igt_pipe_crc_new(drm_fd, PIPE_A, INTEL_PIPE_CRC_SOURCE_AUTO); } static void teardown_environment(void) { - int i; - igt_pipe_crc_free(pipe_crc); buf_ops_destroy(bops); - for (i = 0; i < drm_res->count_connectors; i++) - drmModeFreeConnector(drm_connectors[i]); - - drmModeFreeResources(drm_res); close(drm_fd); } -- 2.26.2 ^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup 2022-08-02 6:53 ` [igt-dev] [PATCH 2/2] " Nidhi Gupta @ 2022-08-02 9:56 ` Modem, Bhanuprakash 0 siblings, 0 replies; 27+ messages in thread From: Modem, Bhanuprakash @ 2022-08-02 9:56 UTC (permalink / raw) To: Nidhi Gupta, igt-dev Hi Nidhi, Overall, this change looks good to me. Please address some minor comments inline. On Tue-02-08-2022 12:23 pm, Nidhi Gupta wrote: > v2: -Replace drm function call with existing library functions > (Bhanu) > > Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com> > --- > tests/i915/kms_draw_crc.c | 60 ++++++++++++--------------------------- > 1 file changed, 18 insertions(+), 42 deletions(-) > > diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c > index 5c9feac9..eaa200b9 100644 > --- a/tests/i915/kms_draw_crc.c > +++ b/tests/i915/kms_draw_crc.c > @@ -31,12 +31,12 @@ > > struct modeset_params { > uint32_t crtc_id; > - uint32_t connector_id; > drmModeModeInfoPtr mode; > }; > > int drm_fd; > -drmModeResPtr drm_res; > +igt_display_t display; > +igt_output_t *output; > drmModeConnectorPtr drm_connectors[MAX_CONNECTORS]; > struct buf_ops *bops; > igt_pipe_crc_t *pipe_crc; > @@ -64,27 +64,21 @@ struct modeset_params ms; > > static void find_modeset_params(void) > { > - int i; > uint32_t crtc_id; > - drmModeConnectorPtr connector = NULL; > - drmModeModeInfoPtr mode = NULL; > + drmModeModeInfo *mode; > > - for (i = 0; i < drm_res->count_connectors; i++) { > - drmModeConnectorPtr c = drm_connectors[i]; > + igt_display_reset(&display); > + igt_display_commit(&display); > > - if (c->count_modes) { > - connector = c; > - mode = &c->modes[0]; > - break; > - } > - } > - igt_require(connector); > - > - crtc_id = kmstest_find_crtc_for_connector(drm_fd, drm_res, connector, > - 0); > + output = igt_get_single_output_for_pipe(&display, PIPE_A); If PIPE_A is not available or fused, then? Please find a compatible pipe/output combo to proceed. - Bhanu > + igt_require(output); > + igt_output_set_pipe(output, PIPE_A); > + > + mode = igt_output_get_mode(output); > igt_assert(mode); > > - ms.connector_id = connector->connector_id; > + crtc_id = display.pipes[PIPE_A].crtc_id; > + > ms.crtc_id = crtc_id; > ms.mode = mode; > > @@ -144,8 +138,7 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format, > igt_draw_rect_fb(drm_fd, bops, 0, &fb, method, 1, 1, 15, 15, > get_color(drm_format, 0, 1, 1)); > > - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, > - &ms.connector_id, 1, ms.mode); > + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); > igt_assert_eq(rc, 0); > > igt_pipe_crc_collect_crc(pipe_crc, crc); > @@ -212,8 +205,7 @@ static void get_fill_crc(uint64_t modifier, igt_crc_t *crc) > > igt_draw_fill_fb(drm_fd, &fb, 0xFF); > > - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, > - &ms.connector_id, 1, ms.mode); > + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); > igt_assert_eq(rc, 0); > > igt_pipe_crc_collect_crc(pipe_crc, crc); > @@ -236,8 +228,7 @@ static void fill_fb_subtest(void) > IGT_DRAW_MMAP_WC, > 0, 0, fb.width, fb.height, 0xFF); > > - rc = drmModeSetCrtc(drm_fd, ms.crtc_id, fb.fb_id, 0, 0, > - &ms.connector_id, 1, ms.mode); > + rc = igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); > igt_assert_eq(rc, 0); > > igt_pipe_crc_collect_crc(pipe_crc, &base_crc); > @@ -260,40 +251,25 @@ static void fill_fb_subtest(void) > > static void setup_environment(void) > { > - int i; > - > drm_fd = drm_open_driver_master(DRIVER_INTEL); > igt_require(drm_fd >= 0); > - > - drm_res = drmModeGetResources(drm_fd); > - igt_require(drm_res); > - igt_assert(drm_res->count_connectors <= MAX_CONNECTORS); > - > - for (i = 0; i < drm_res->count_connectors; i++) > - drm_connectors[i] = drmModeGetConnectorCurrent(drm_fd, > - drm_res->connectors[i]); > + igt_display_require(&display, drm_fd); > + igt_display_require_output(&display); > > kmstest_set_vt_graphics_mode(); > > bops = buf_ops_create(drm_fd); > > find_modeset_params(); > - pipe_crc = igt_pipe_crc_new(drm_fd, kmstest_get_crtc_idx(drm_res, ms.crtc_id), > - INTEL_PIPE_CRC_SOURCE_AUTO); > + pipe_crc = igt_pipe_crc_new(drm_fd, PIPE_A, INTEL_PIPE_CRC_SOURCE_AUTO); > } > > static void teardown_environment(void) > { > - int i; > - > igt_pipe_crc_free(pipe_crc); > > buf_ops_destroy(bops); > > - for (i = 0; i < drm_res->count_connectors; i++) > - drmModeFreeConnector(drm_connectors[i]); > - > - drmModeFreeResources(drm_res); > close(drm_fd); > } > ^ permalink raw reply [flat|nested] 27+ messages in thread
* [igt-dev] [PATCH 0/2] tests/kms: IGT test cleanup @ 2022-06-10 4:31 Nidhi Gupta 2022-06-10 4:31 ` [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup Nidhi Gupta 0 siblings, 1 reply; 27+ messages in thread From: Nidhi Gupta @ 2022-06-10 4:31 UTC (permalink / raw) To: igt-dev; +Cc: Nidhi Gupta In below test, convert all possible subtests to dynamic and sanitize the system state before starting/exiting the subtest. Nidhi Gupta (2): tests/i915/kms_draw_crc.c: Convert test to dynamic tests/i915/kms_draw_crc: Test Cleanup tests/i915/kms_draw_crc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.26.2 ^ permalink raw reply [flat|nested] 27+ messages in thread
* [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup 2022-06-10 4:31 [igt-dev] [PATCH 0/2] tests/kms: IGT test cleanup Nidhi Gupta @ 2022-06-10 4:31 ` Nidhi Gupta 0 siblings, 0 replies; 27+ messages in thread From: Nidhi Gupta @ 2022-06-10 4:31 UTC (permalink / raw) To: igt-dev; +Cc: Nidhi Gupta Sanitize the system state before starting the subtest. Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com> --- tests/i915/kms_draw_crc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c index 3e68479e..1c87e523 100644 --- a/tests/i915/kms_draw_crc.c +++ b/tests/i915/kms_draw_crc.c @@ -265,6 +265,7 @@ static void setup_environment(void) drm_fd = drm_open_driver_master(DRIVER_INTEL); igt_require(drm_fd >= 0); + igt_display_reset(display); drm_res = drmModeGetResources(drm_fd); igt_require(drm_res); igt_assert(drm_res->count_connectors <= MAX_CONNECTORS); -- 2.26.2 ^ permalink raw reply related [flat|nested] 27+ messages in thread
end of thread, other threads:[~2022-09-05 11:29 UTC | newest] Thread overview: 27+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-08-04 3:40 [igt-dev] [PATCH 0/2] tests/i915/kms_draw_crc: Test Cleanup Nidhi Gupta 2022-08-04 3:40 ` [igt-dev] [PATCH 1/2] tests/i915/kms_draw_crc: Convert tests to dynamic Nidhi Gupta 2022-08-18 14:55 ` Juha-Pekka Heikkila 2022-08-04 3:40 ` [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup Nidhi Gupta 2022-08-08 11:16 ` Gupta, Nidhi1 2022-08-08 14:02 ` Modem, Bhanuprakash 2022-08-09 8:00 ` Modem, Bhanuprakash 2022-08-09 9:08 ` Modem, Bhanuprakash 2022-08-09 12:53 ` Juha-Pekka Heikkila 2022-08-10 10:11 ` Nidhi Gupta 2022-08-10 13:27 ` Nidhi Gupta 2022-08-12 10:37 ` Modem, Bhanuprakash 2022-08-04 4:23 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/i915/kms_draw_crc: Test Cleanup (rev4) Patchwork 2022-08-04 7:49 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2022-08-08 11:28 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/i915/kms_draw_crc: Test Cleanup (rev5) Patchwork 2022-08-10 12:53 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/i915/kms_draw_crc: Test Cleanup (rev6) Patchwork 2022-08-10 14:54 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/i915/kms_draw_crc: Test Cleanup (rev7) Patchwork 2022-08-11 0:45 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork -- strict thread matches above, loose matches on Subject: below -- 2022-09-05 11:24 [igt-dev] [PATCH 0/2] tests/i915/kms_draw_crc: Test Cleanup Nidhi Gupta 2022-09-05 11:24 ` [igt-dev] [PATCH 2/2] " Nidhi Gupta 2022-08-26 5:44 [igt-dev] [PATCH 0/2] " Nidhi Gupta 2022-08-26 5:44 ` [igt-dev] [PATCH 2/2] " Nidhi Gupta 2022-08-22 9:20 [igt-dev] [PATCH 0/2] " Nidhi Gupta 2022-08-22 9:20 ` [igt-dev] [PATCH 2/2] " Nidhi Gupta 2022-08-03 4:20 [igt-dev] [PATCH 0/2] " Nidhi Gupta 2022-08-03 4:20 ` [igt-dev] [PATCH 2/2] " Nidhi Gupta 2022-08-03 7:40 ` Modem, Bhanuprakash 2022-08-03 4:15 [igt-dev] [PATCH 0/2] " Nidhi Gupta 2022-08-03 4:15 ` [igt-dev] [PATCH 2/2] " Nidhi Gupta 2022-08-02 6:53 [igt-dev] [PATCH 0/2] " Nidhi Gupta 2022-08-02 6:53 ` [igt-dev] [PATCH 2/2] " Nidhi Gupta 2022-08-02 9:56 ` Modem, Bhanuprakash 2022-06-10 4:31 [igt-dev] [PATCH 0/2] tests/kms: IGT test cleanup Nidhi Gupta 2022-06-10 4:31 ` [igt-dev] [PATCH 2/2] tests/i915/kms_draw_crc: Test Cleanup Nidhi Gupta
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox