From: Caz Yokoyama <Caz.Yokoyama@intel.com>
To: Katarzyna Dec <katarzyna.dec@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v3 1/1] tests/i915/gem_exec_balancer.c - remove unnecessary simulation check
Date: Thu, 10 Oct 2019 08:31:06 -0700 [thread overview]
Message-ID: <30187291c3b6029df3a4c9d5324c44a1a3210b7c.camel@intel.com> (raw)
In-Reply-To: <20191010075528.GG18974@kdec5-desk.ger.corp.intel.com>
On Thu, 2019-10-10 at 09:55 +0200, Katarzyna Dec wrote:
> On Mon, Aug 05, 2019 at 02:30:35PM -0700, Caz Yokoyama wrote:
>
> Usual approach for patches it to explain WHY we do things. WHAT is
> self-explainable by code.
> Adding commit msg could make patch more noticable.
Agree. For this case however, I followed the advice which asked me to
do not expose Intel Internal information. The explanation why simulator
check is not neccessary should include because the test runs on pre-
sillicon not yet publicly announced XXX chip.
Anyway, I follow the advice of original author.
>
> Moreover - I would talk to author of the code what he thinks of this
> change.
>
> Kasia
>
> > Signed-off-by: Caz Yokoyama <caz.yokoyama@intel.com>
> > ---
> > tests/i915/gem_exec_balancer.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/tests/i915/gem_exec_balancer.c
> > b/tests/i915/gem_exec_balancer.c
> > index b2074486..abf90df6 100644
> > --- a/tests/i915/gem_exec_balancer.c
> > +++ b/tests/i915/gem_exec_balancer.c
> > @@ -1267,8 +1267,6 @@ igt_main
> > {
> > int i915 = -1;
> >
> > - igt_skip_on_simulation();
> > -
> > igt_fixture {
> > i915 = drm_open_driver(DRIVER_INTEL);
> > igt_require_gem(i915);
> > --
> > 2.21.0.5.gaeb582a983
> >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-10-10 15:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 21:30 [igt-dev] [PATCH i-g-t v3 1/1] tests/i915/gem_exec_balancer.c - remove unnecessary simulation check Caz Yokoyama
2019-08-05 22:09 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v3,1/1] " Patchwork
2019-08-06 9:12 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-10-10 7:55 ` [igt-dev] [PATCH i-g-t v3 1/1] " Katarzyna Dec
2019-10-10 8:06 ` Chris Wilson
2019-10-10 22:38 ` Dixit, Ashutosh
2019-10-10 15:31 ` Caz Yokoyama [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30187291c3b6029df3a4c9d5324c44a1a3210b7c.camel@intel.com \
--to=caz.yokoyama@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=katarzyna.dec@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox