From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v3 1/1] tests/i915/gem_exec_balancer.c - remove unnecessary simulation check
Date: Thu, 10 Oct 2019 15:38:47 -0700 [thread overview]
Message-ID: <87mue8kyyw.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <157069481451.18808.9666933287205890328@skylake-alporthouse-com>
On Thu, 10 Oct 2019 01:06:54 -0700, Chris Wilson wrote:
>
> Quoting Katarzyna Dec (2019-10-10 08:55:28)
> > On Mon, Aug 05, 2019 at 02:30:35PM -0700, Caz Yokoyama wrote:
> >
> > Usual approach for patches it to explain WHY we do things. WHAT is
> > self-explainable by code.
> > Adding commit msg could make patch more noticable.
> >
> > Moreover - I would talk to author of the code what he thinks of this change.
>
> No strong opinion; it's a note to say that this igt focusing on sw
> details rather than hw so the test is unlikely to be useful for early
> bringup.
Agreed, though there doesn't seem to be any reason for not merging the
change either...
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-10-10 22:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 21:30 [igt-dev] [PATCH i-g-t v3 1/1] tests/i915/gem_exec_balancer.c - remove unnecessary simulation check Caz Yokoyama
2019-08-05 22:09 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v3,1/1] " Patchwork
2019-08-06 9:12 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-10-10 7:55 ` [igt-dev] [PATCH i-g-t v3 1/1] " Katarzyna Dec
2019-10-10 8:06 ` Chris Wilson
2019-10-10 22:38 ` Dixit, Ashutosh [this message]
2019-10-10 15:31 ` Caz Yokoyama
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mue8kyyw.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox