From: Andrzej Hajda <andrzej.hajda@intel.com>
To: Swati Sharma <swati2.sharma@intel.com>, igt-dev@lists.freedesktop.org
Cc: Chris Wilson <chris.p.wilson@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 2/3] i915/kms_mmap_write_crc: Free the mmap and dma-buf fd
Date: Wed, 21 Jun 2023 12:30:32 +0200 [thread overview]
Message-ID: <31975c2c-3605-78d2-50a6-9cd7950c38c8@intel.com> (raw)
In-Reply-To: <20230621090032.611560-3-swati2.sharma@intel.com>
On 21.06.2023 11:00, Swati Sharma wrote:
> From: Chris Wilson <chris.p.wilson@intel.com>
>
> Release the dma-buf fd (held also by the mmap) after testing so
> that we can check for kernel resource leaks at exit.
>
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Signed-off-by: Chris Wilson <chris.p.wilson@intel.com>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
> tests/i915/kms_mmap_write_crc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/i915/kms_mmap_write_crc.c b/tests/i915/kms_mmap_write_crc.c
> index bc51975f..87f51153 100644
> --- a/tests/i915/kms_mmap_write_crc.c
> +++ b/tests/i915/kms_mmap_write_crc.c
> @@ -165,6 +165,9 @@ static void test(data_t *data)
> /* check that the crc is as expected, which requires that caches got flushed */
> igt_pipe_crc_collect_crc(data->pipe_crc, &crc);
> igt_assert_crc_equal(&crc, &data->ref_crc);
> +
> + munmap(ptr, fb->size);
> + close(dma_buf_fd);
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
> }
>
> static void prepare_crtc(data_t *data)
next prev parent reply other threads:[~2023-06-21 10:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 9:00 [igt-dev] [PATCH i-g-t 0/3] Misc. fixes Swati Sharma
2023-06-21 9:00 ` [igt-dev] [PATCH i-g-t 1/3] i915/kms_busy: Free spinners after use Swati Sharma
2023-06-21 16:35 ` Kamil Konieczny
2023-06-21 9:00 ` [igt-dev] [PATCH i-g-t 2/3] i915/kms_mmap_write_crc: Free the mmap and dma-buf fd Swati Sharma
2023-06-21 10:30 ` Andrzej Hajda [this message]
2023-06-21 9:00 ` [igt-dev] [PATCH i-g-t v2 3/3] lib/igt_draw: Use intel_display_ver() for drawing with blits Swati Sharma
2023-06-21 10:43 ` Andrzej Hajda
2023-06-21 10:15 ` [igt-dev] ✓ Fi.CI.BAT: success for Misc. fixes (rev4) Patchwork
2023-06-21 20:47 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-06-20 14:57 [igt-dev] [PATCH i-g-t 0/3] Misc. fixes Swati Sharma
2023-06-20 14:57 ` [igt-dev] [PATCH i-g-t 2/3] i915/kms_mmap_write_crc: Free the mmap and dma-buf fd Swati Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31975c2c-3605-78d2-50a6-9cd7950c38c8@intel.com \
--to=andrzej.hajda@intel.com \
--cc=chris.p.wilson@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox