Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Chris Wilson <chris.p.wilson@intel.com>
Subject: [igt-dev] [PATCH i-g-t 2/3] i915/kms_mmap_write_crc: Free the mmap and dma-buf fd
Date: Tue, 20 Jun 2023 20:27:36 +0530	[thread overview]
Message-ID: <20230620145737.601858-3-swati2.sharma@intel.com> (raw)
In-Reply-To: <20230620145737.601858-1-swati2.sharma@intel.com>

From: Chris Wilson <chris.p.wilson@intel.com>

Release the dma-buf fd (held also by the mmap) after testing so
that we can check for kernel resource leaks at exit.

Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Signed-off-by: Chris Wilson <chris.p.wilson@intel.com>
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/i915/kms_mmap_write_crc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/i915/kms_mmap_write_crc.c b/tests/i915/kms_mmap_write_crc.c
index bc51975f..87f51153 100644
--- a/tests/i915/kms_mmap_write_crc.c
+++ b/tests/i915/kms_mmap_write_crc.c
@@ -165,6 +165,9 @@ static void test(data_t *data)
 	/* check that the crc is as expected, which requires that caches got flushed */
 	igt_pipe_crc_collect_crc(data->pipe_crc, &crc);
 	igt_assert_crc_equal(&crc, &data->ref_crc);
+
+	munmap(ptr, fb->size);
+	close(dma_buf_fd);
 }
 
 static void prepare_crtc(data_t *data)
-- 
2.25.1

  parent reply	other threads:[~2023-06-20 14:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20 14:57 [igt-dev] [PATCH i-g-t 0/3] Misc. fixes Swati Sharma
2023-06-20 14:57 ` [igt-dev] [PATCH i-g-t 1/3] i915/kms_busy: Free spinners after use Swati Sharma
2023-06-20 15:09   ` Ruhl, Michael J
2023-06-21  7:08   ` Kamil Konieczny
2023-06-20 14:57 ` Swati Sharma [this message]
2023-06-20 14:57 ` [igt-dev] [PATCH i-g-t 3/3] lib/igt_draw: Use intel_display_ver() for drawing with blits Swati Sharma
2023-06-20 15:49 ` [igt-dev] ✓ Fi.CI.BAT: success for Misc. fixes (rev3) Patchwork
2023-06-20 21:57 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2023-06-21  9:00 [igt-dev] [PATCH i-g-t 0/3] Misc. fixes Swati Sharma
2023-06-21  9:00 ` [igt-dev] [PATCH i-g-t 2/3] i915/kms_mmap_write_crc: Free the mmap and dma-buf fd Swati Sharma
2023-06-21 10:30   ` Andrzej Hajda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230620145737.601858-3-swati2.sharma@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=chris.p.wilson@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox