Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Chris Wilson <chris.p.wilson@intel.com>
Subject: [igt-dev] [PATCH i-g-t 1/3] i915/kms_busy: Free spinners after use
Date: Tue, 20 Jun 2023 20:27:35 +0530	[thread overview]
Message-ID: <20230620145737.601858-2-swati2.sharma@intel.com> (raw)
In-Reply-To: <20230620145737.601858-1-swati2.sharma@intel.com>

From: Chris Wilson <chris.p.wilson@intel.com>

Avoid leaking GEM objects between subtests, eventually leading to
warnings for leaking kernel resources at exit.

Cc: Michael J. Ruhl <michael.j.ruhl@intel.com>
Signed-off-by: Chris Wilson <chris.p.wilson@intel.com>
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/i915/kms_busy.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/i915/kms_busy.c b/tests/i915/kms_busy.c
index 3b838cb8..ad96d6b9 100644
--- a/tests/i915/kms_busy.c
+++ b/tests/i915/kms_busy.c
@@ -219,7 +219,7 @@ static void test_atomic_commit_hang(igt_display_t *dpy, igt_plane_t *primary,
 
 	igt_assert(read(dpy->drm_fd, &ev, sizeof(ev)) == sizeof(ev));
 
-	igt_spin_end(t);
+	igt_spin_free(dpy->drm_fd, t);
 	put_ahnd(ahnd);
 }
 
@@ -304,9 +304,8 @@ test_pageflip_modeset_hang(igt_display_t *dpy,
 
 	igt_assert(read(dpy->drm_fd, &ev, sizeof(ev)) == sizeof(ev));
 
-	igt_spin_end(t);
 	put_ahnd(ahnd);
-
+	igt_spin_free(dpy->drm_fd, t);
 	igt_remove_fb(dpy->drm_fd, &fb);
 }
 
-- 
2.25.1

  reply	other threads:[~2023-06-20 14:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20 14:57 [igt-dev] [PATCH i-g-t 0/3] Misc. fixes Swati Sharma
2023-06-20 14:57 ` Swati Sharma [this message]
2023-06-20 15:09   ` [igt-dev] [PATCH i-g-t 1/3] i915/kms_busy: Free spinners after use Ruhl, Michael J
2023-06-21  7:08   ` Kamil Konieczny
2023-06-20 14:57 ` [igt-dev] [PATCH i-g-t 2/3] i915/kms_mmap_write_crc: Free the mmap and dma-buf fd Swati Sharma
2023-06-20 14:57 ` [igt-dev] [PATCH i-g-t 3/3] lib/igt_draw: Use intel_display_ver() for drawing with blits Swati Sharma
2023-06-20 15:49 ` [igt-dev] ✓ Fi.CI.BAT: success for Misc. fixes (rev3) Patchwork
2023-06-20 21:57 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2023-06-21  9:00 [igt-dev] [PATCH i-g-t 0/3] Misc. fixes Swati Sharma
2023-06-21  9:00 ` [igt-dev] [PATCH i-g-t 1/3] i915/kms_busy: Free spinners after use Swati Sharma
2023-06-21 16:35   ` Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230620145737.601858-2-swati2.sharma@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=chris.p.wilson@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox