Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 3/3] lib/igt_draw: Use intel_display_ver() for drawing with blits
Date: Tue, 20 Jun 2023 20:27:37 +0530	[thread overview]
Message-ID: <20230620145737.601858-4-swati2.sharma@intel.com> (raw)
In-Reply-To: <20230620145737.601858-1-swati2.sharma@intel.com>

From: Matt Roper <matthew.d.roper@intel.com>

Display code should check the display version of the platform
rather than the graphics version; on some platforms these
versions won't be the same.

v2: -fixed subject (Kamil)

Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 lib/igt_draw.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/igt_draw.c b/lib/igt_draw.c
index 6f362994..1f814bfc 100644
--- a/lib/igt_draw.c
+++ b/lib/igt_draw.c
@@ -674,7 +674,7 @@ static void draw_rect_blt(int fd, struct cmd_data *cmd_data,
 	struct intel_buf *dst;
 	int blt_cmd_len, blt_cmd_tiling, blt_cmd_depth;
 	uint32_t devid = intel_get_drm_devid(fd);
-	int gen = intel_gen(devid);
+	int ver = intel_display_ver(devid);
 	int pitch;
 
 	if (tiling)
@@ -751,9 +751,9 @@ static void draw_rect_blt(int fd, struct cmd_data *cmd_data,
 			igt_assert(false);
 		}
 
-		blt_cmd_len = (gen >= 8) ?  0x5 : 0x4;
+		blt_cmd_len = (ver >= 8) ?  0x5 : 0x4;
 		blt_cmd_tiling = (tiling) ? XY_COLOR_BLT_TILED : 0;
-		pitch = (gen >= 4 && tiling) ? buf->stride / 4 : buf->stride;
+		pitch = (ver >= 4 && tiling) ? buf->stride / 4 : buf->stride;
 
 		switch_blt_tiling(ibb, tiling, true);
 
-- 
2.25.1

  parent reply	other threads:[~2023-06-20 14:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20 14:57 [igt-dev] [PATCH i-g-t 0/3] Misc. fixes Swati Sharma
2023-06-20 14:57 ` [igt-dev] [PATCH i-g-t 1/3] i915/kms_busy: Free spinners after use Swati Sharma
2023-06-20 15:09   ` Ruhl, Michael J
2023-06-21  7:08   ` Kamil Konieczny
2023-06-20 14:57 ` [igt-dev] [PATCH i-g-t 2/3] i915/kms_mmap_write_crc: Free the mmap and dma-buf fd Swati Sharma
2023-06-20 14:57 ` Swati Sharma [this message]
2023-06-20 15:49 ` [igt-dev] ✓ Fi.CI.BAT: success for Misc. fixes (rev3) Patchwork
2023-06-20 21:57 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230620145737.601858-4-swati2.sharma@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox